Re: svn commit: r1735176 - in /httpd/httpd/trunk: CHANGES modules/http/http_core.c

2016-03-16 Thread Stefan Eissing
I needed to revert r1735174 to make HTTP/1.1 work again. I submitted this to trunk since other people are affected too. Graham: if you are unable to reproduce this and need any additional data, pls let me know. -Stefan > Am 16.03.2016 um 11:52 schrieb Stefan Eissing

Re: [Patch] Ensure HTTP1 filters are only added on HTTP1 requests

2016-03-16 Thread Graham Leggett
On 16 Mar 2016, at 5:57 AM, William A Rowe Jr wrote: > My concern is that this can't and shouldn't change on 2.4.x. > > I love the concept and it is correct, however there are enough modules relying > on the fact that they must remove the http protocol filters that changing

Re: svn commit: r1735176 - in /httpd/httpd/trunk: CHANGES modules/http/http_core.c

2016-03-16 Thread Stefan Eissing
Reverting that change, it still does not handle h1. Digging... > Am 16.03.2016 um 11:47 schrieb Stefan Eissing : > > Only HTTP/2 connections seem to work right now. > > I mean, it's hard for me to complain, but that seems a bit much... > >> Am 16.03.2016 um 10:29

Re: svn commit: r1735176 - in /httpd/httpd/trunk: CHANGES modules/http/http_core.c

2016-03-16 Thread Stefan Eissing
Only HTTP/2 connections seem to work right now. I mean, it's hard for me to complain, but that seems a bit much... > Am 16.03.2016 um 10:29 schrieb Ruediger Pluem : > > > > On 03/16/2016 12:13 AM, minf...@apache.org wrote: >> Author: minfrin >> Date: Tue Mar 15 23:13:43

Re: svn commit: r1735176 - in /httpd/httpd/trunk: CHANGES modules/http/http_core.c

2016-03-16 Thread Ruediger Pluem
On 03/16/2016 12:13 AM, minf...@apache.org wrote: > Author: minfrin > Date: Tue Mar 15 23:13:43 2016 > New Revision: 1735176 > > URL: http://svn.apache.org/viewvc?rev=1735176=rev > Log: > mod_http: Make sure HTTP filters are added on HTTP requests only. > > Modified: >

Re: [Patch] Ensure HTTP1 filters are only added on HTTP1 requests

2016-03-16 Thread Nick Kew
On Tue, 2016-03-15 at 22:57 -0500, William A Rowe Jr wrote: > My concern is that this can't and shouldn't change on 2.4.x. > Thoughts? If someone is independently using a different protocol, or has just tweaked HTTP handling for their own reasons, they could be using hacks/workarounds this'll

Re: [Patch] Ensure HTTP1 filters are only added on HTTP1 requests

2016-03-16 Thread Stefan Eissing
Hmm, I can tell you for certain that modules encountering HTTP/2 connections in 2.4 do not find the filters as they may expect. So far, I have not heard of any breakage related to this. Which is not to say it does not exist. AFAIK the patch will only affect connections where ap_get_protocol()

Re: [Patch] Ensure HTTP1 filters are only added on HTTP1 requests

2016-03-16 Thread Ruediger Pluem
On 03/16/2016 04:57 AM, William A Rowe Jr wrote: > My concern is that this can't and shouldn't change on 2.4.x. > > I love the concept and it is correct, however there are enough modules relying > on the fact that they must remove the http protocol filters that changing the > default behavior

Re: svn commit: r1735174 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/ap_mpm.h include/mpm_common.h modules/proxy/mod_proxy_wstunnel.c server/mpm/event/event.c server/mpm/event/fdqueue.h

2016-03-16 Thread Ruediger Pluem
On 03/15/2016 11:52 PM, minf...@apache.org wrote: > Author: minfrin > Date: Tue Mar 15 22:52:51 2016 > New Revision: 1735174 > > URL: http://svn.apache.org/viewvc?rev=1735174=rev > Log: > mpm: Generalise the ap_mpm_register_socket functions to accept pipes or > sockets. > > Modified: >