Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-08-05 Thread Eric Covener
On Fri, Aug 5, 2016 at 4:58 PM, William A Rowe Jr wrote: > On Thu, Aug 4, 2016 at 2:33 PM, William A Rowe Jr > wrote: >> >> On Thu, Aug 4, 2016 at 2:01 PM, Eric Covener wrote: >>> >>> On Mon, Aug 1, 2016 at 3:22 PM, William A Rowe Jr >>> wrote: >>> > We have a few choices, but the bottom line i

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-08-05 Thread William A Rowe Jr
On Thu, Aug 4, 2016 at 2:33 PM, William A Rowe Jr wrote: > On Thu, Aug 4, 2016 at 2:01 PM, Eric Covener wrote: > >> On Mon, Aug 1, 2016 at 3:22 PM, William A Rowe Jr >> wrote: >> > We have a few choices, but the bottom line is that we treat /r/n >> > as 0x0a 0x15 on ebcdic, and perhaps fix our

Re: svn commit: r1754548 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread William A Rowe Jr
On Aug 4, 2016 3:02 PM, "Roy T. Fielding" wrote: >> >> On Aug 3, 2016, at 2:28 PM, William A Rowe Jr wrote: > >> If not, then stripping trailing whitespace from the line prior to obs-fold and >> eating all leading whitespace on the obs-fold line will result in a single SP >> character, which shou

Re: svn commit: r1755124 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread William A Rowe Jr
On Fri, Aug 5, 2016 at 12:50 PM, Yann Ylavic wrote: > > while adding > > the unnecessary verification of last_len != 0 from line 904, so I'd say > it's > > a > > net loss of legibility in spite of gaining us 4 characters. Just my 2c. > > The 'len' verification is necessary because it can be zero

Re: svn commit: r1755124 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread Yann Ylavic
On Fri, Aug 5, 2016 at 7:33 PM, William A Rowe Jr wrote: > On Fri, Aug 5, 2016 at 10:43 AM, Yann Ylavic wrote: >> >> @@ -903,8 +903,16 @@ AP_DECLARE(void) ap_get_mime_headers_core(request_ >> */ >> continue; >> } >> -else if (last_field != NULL) { >> >>

Re: svn commit: r1755124 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread William A Rowe Jr
On Fri, Aug 5, 2016 at 10:43 AM, Yann Ylavic wrote: > @@ -903,8 +903,16 @@ AP_DECLARE(void) ap_get_mime_headers_core(request_ > */ > continue; > } > -else if (last_field != NULL) { > > +if (last_field == NULL) { > +/* Keep track of t

Re: svn commit: r1755124 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread Yann Ylavic
On Thu, Aug 4, 2016 at 12:58 AM, wrote: > Author: wrowe > Date: Wed Aug 3 22:58:10 2016 > New Revision: 1755124 > > URL: http://svn.apache.org/viewvc?rev=1755124&view=rev > Log: > Reformat for indentation following r1755123, Whitespace Only > > Modified: > httpd/httpd/trunk/server/protocol.c

Re: Core on trunk for t/apache/limits.t

2016-08-05 Thread Jim Jagielski
Looks like r1755343 fixed it... > On Aug 5, 2016, at 11:28 AM, Jim Jagielski wrote: > > This is HEAD >> On Aug 5, 2016, at 11:09 AM, Yann Ylavic wrote: >> >> On Fri, Aug 5, 2016 at 4:06 PM, Jim Jagielski wrote: >>> >>> Will try to recreate on Linux >> >> Can you still reproduce with r175534

Re: Core on trunk for t/apache/limits.t

2016-08-05 Thread Jim Jagielski
This is HEAD > On Aug 5, 2016, at 11:09 AM, Yann Ylavic wrote: > > On Fri, Aug 5, 2016 at 4:06 PM, Jim Jagielski wrote: >> >> Will try to recreate on Linux > > Can you still reproduce with r1755343?

Re: Core on trunk for t/apache/limits.t

2016-08-05 Thread Jim Jagielski
That's the one... :/ > On Aug 5, 2016, at 10:27 AM, Rainer Jung wrote: > > Am 05.08.2016 um 16:06 schrieb Jim Jagielski: >> Testing HEAD on trunk I see t/apache/limits.t failing w/ >> a core dump on OSX 10.11.6: >> >> t/apache/limits.t .. 4/12 # Failed test 4 in t/apache/limits.t at line 168 >

Re: svn commit: r1755343 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread William A Rowe Jr
On Fri, Aug 5, 2016 at 10:08 AM, wrote: > Author: ylavic > Date: Fri Aug 5 15:08:24 2016 > New Revision: 1755343 > > URL: http://svn.apache.org/viewvc?rev=1755343&view=rev > Log: > Follow up to r1755264. > Don't crash when ap_rgetline() returns a NULL field on ENOSPC. > > +

Re: Core on trunk for t/apache/limits.t

2016-08-05 Thread Yann Ylavic
On Fri, Aug 5, 2016 at 4:06 PM, Jim Jagielski wrote: > > Will try to recreate on Linux Can you still reproduce with r1755343?

Re: Core on trunk for t/apache/limits.t

2016-08-05 Thread William A Rowe Jr
On Fri, Aug 5, 2016 at 9:27 AM, Rainer Jung wrote: > Am 05.08.2016 um 16:06 schrieb Jim Jagielski: > >> Testing HEAD on trunk I see t/apache/limits.t failing w/ >> a core dump on OSX 10.11.6: >> >> t/apache/limits.t .. 4/12 # Failed test 4 in t/apache/limits.t at line >> 168 fail #2 >> t/apache/l

Re: svn commit: r1755264 - /httpd/httpd/trunk/server/protocol.c

2016-08-05 Thread Yann Ylavic
On Fri, Aug 5, 2016 at 11:13 AM, wrote: > Author: wrowe > Date: Fri Aug 5 09:13:26 2016 > New Revision: 1755264 > > URL: http://svn.apache.org/viewvc?rev=1755264&view=rev > Log: > Stop reflecting irrelevant data to the request error notes, particularly > for abusive and malformed traffic the non

Re: Core on trunk for t/apache/limits.t

2016-08-05 Thread Rainer Jung
Am 05.08.2016 um 16:06 schrieb Jim Jagielski: Testing HEAD on trunk I see t/apache/limits.t failing w/ a core dump on OSX 10.11.6: t/apache/limits.t .. 4/12 # Failed test 4 in t/apache/limits.t at line 168 fail #2 t/apache/limits.t .. Failed 1/12 subtests (lldb) bt * thread #1: tid = 0x, 0

Core on trunk for t/apache/limits.t

2016-08-05 Thread Jim Jagielski
Testing HEAD on trunk I see t/apache/limits.t failing w/ a core dump on OSX 10.11.6: t/apache/limits.t .. 4/12 # Failed test 4 in t/apache/limits.t at line 168 fail #2 t/apache/limits.t .. Failed 1/12 subtests (lldb) bt * thread #1: tid = 0x, 0x7fff9307f362 libsystem_kernel.dylib`read +

Re: Frequent wake-ups for mpm_event

2016-08-05 Thread Yann Ylavic
On Fri, Aug 5, 2016 at 3:19 PM, Yann Ylavic wrote: > Hi Luca, > > On Fri, Aug 5, 2016 at 2:58 PM, Luca Toscano wrote: >> >> 2016-08-04 17:56 GMT+02:00 Luca Toscano : >>> >>> Would it be possible to avoid them adding APR_POLLSET_WAKEABLE to the >>> event_pollset flags and calling apr_pollset_wakeu

Re: Frequent wake-ups for mpm_event

2016-08-05 Thread Yann Ylavic
Hi Luca, On Fri, Aug 5, 2016 at 2:58 PM, Luca Toscano wrote: > > 2016-08-04 17:56 GMT+02:00 Luca Toscano : >> >> Would it be possible to avoid them adding APR_POLLSET_WAKEABLE to the >> event_pollset flags and calling apr_pollset_wakeup right after >> apr_skiplist_insert? That might be possible,

Re: Frequent wake-ups for mpm_event

2016-08-05 Thread Jim Jagielski
If APR_POLLSET_WAKEABLE was more universal and, therefore, more widely tested, I'd be +1... as it is, let's see what the feedback is. > On Aug 5, 2016, at 8:58 AM, Luca Toscano wrote: > > > > 2016-08-04 17:56 GMT+02:00 Luca Toscano : > Hi Apache Devs, > > there is an interesting bugzilla tick

Re: Proposed, 2 week termination of mod_authnz_ldap component

2016-08-05 Thread Eric Covener
On Thu, Aug 4, 2016 at 9:26 PM, William A Rowe Jr wrote: > It seems time to evict the component from httpd core, given > that it is neither supportable or maintainable. The ABI contract > offered by APR, of no external header dependencies, no binary > dependencies, and all the rest were never obse

Re: Frequent wake-ups for mpm_event

2016-08-05 Thread Luca Toscano
2016-08-04 17:56 GMT+02:00 Luca Toscano : > Hi Apache Devs, > > there is an interesting bugzilla ticket about mpm_event and frequent > wake-ups: https://bz.apache.org/bugzilla/show_bug.cgi?id=57399 > > Would it be possible to avoid them adding APR_POLLSET_WAKEABLE to the > event_pollset flags and

Re: svn commit: r1755263 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/protocol.c

2016-08-05 Thread Yann Ylavic
On Fri, Aug 5, 2016 at 1:25 PM, Yann Ylavic wrote: > On Fri, Aug 5, 2016 at 11:08 AM, wrote: >> >> -if (field[1] != '\0') { >> -/* ...and leading whitespace on an obs-fold line can be >> - * similarly discarded */ >> -while (field[1] ==

Re: svn commit: r1755263 - in /httpd/httpd/trunk: docs/log-message-tags/next-number server/protocol.c

2016-08-05 Thread Yann Ylavic
On Fri, Aug 5, 2016 at 11:08 AM, wrote: > Author: wrowe > Date: Fri Aug 5 09:08:35 2016 > New Revision: 1755263 > > URL: http://svn.apache.org/viewvc?rev=1755263&view=rev > Log: > Treat an empty obs-fold line as abusive traffic > > Modified: > httpd/httpd/trunk/docs/log-message-tags/next-num

RE: [ANNOUNCE] Apache HTTP Server 2.4.23 Released [I]

2016-08-05 Thread Mark Blackman
Thanks for the speedy turn-around! From: Luca Toscano [mailto:toscano.l...@gmail.com] Sent: 04 August 2016 14:08 To: Apache HTTP Server Development List Subject: Re: [ANNOUNCE] Apache HTTP Server 2.4.23 Released [I] https://httpd.apache.org front page updated! Luca --- This e-mail may contai