Re: svn commit: r1836381 - in /httpd/httpd/trunk: ./ include/ modules/proxy/ modules/proxy/balancers/

2018-07-20 Thread William A Rowe Jr
On Fri, Jul 20, 2018, 15:22 Ruediger Pluem wrote: > > BTW: We have the same load order issue issue with the following proxy > modules: > > mod_proxy_connect > mod_proxy_ftp > mod_proxy_http > mod_proxy_fcgi > mod_proxy_scgi > mod_proxy_fdpass > mod_proxy_ajp > mod_proxy_balancer >

Re: svn commit: r1836381 - in /httpd/httpd/trunk: ./ include/ modules/proxy/ modules/proxy/balancers/

2018-07-20 Thread Ruediger Pluem
On 07/20/2018 09:27 PM, rpl...@apache.org wrote: > Author: rpluem > Date: Fri Jul 20 19:27:31 2018 > New Revision: 1836381 > > URL: http://svn.apache.org/viewvc?rev=1836381=rev > Log: > * mod_proxy: Remove load order and link dependency between mod_lbmethod_* > modules and mod_proxy by

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Yann Ylavic
On Fri, Jul 20, 2018 at 4:01 PM, Ruediger Pluem wrote: > > You describe the inconsistency in case c->data_in_input_filters is 1, > I did for the case that c->data_in_input_filters is 0, but yes we could have > inconsistencies in both cases > and the question is if they are always fine. So far it

Re: svn commit: r1832609 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

2018-07-20 Thread William A Rowe Jr
Looks like a good direction. From PR62557, the observed modules to be adjusted, to consume the new opt fn are; --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -423,6 +424,9 @@ SET(mod_http2_extra_sources modules/http2/h2_task.cmodules/http2/h2_util.c modules/http2/h2_workers.c )

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Ruediger Pluem
On 07/20/2018 03:49 PM, Yann Ylavic wrote: > On Fri, Jul 20, 2018 at 2:54 PM, Ruediger Pluem wrote: >> >> On 07/20/2018 02:38 PM, Yann Ylavic wrote: >>> On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: On 07/19/2018 12:36 AM, yla...@apache.org wrote: > > -if

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Yann Ylavic
On Fri, Jul 20, 2018 at 2:54 PM, Ruediger Pluem wrote: > > On 07/20/2018 02:38 PM, Yann Ylavic wrote: >> On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: >>> >>> On 07/19/2018 12:36 AM, yla...@apache.org wrote: -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK)

Re: svn commit: r1832609 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

2018-07-20 Thread Yann Ylavic
On Fri, Jul 20, 2018 at 2:56 PM, Ruediger Pluem wrote: > > So maybe some checking is due there as well if the conditional fetching > should be removed? +1 :)

Re: svn commit: r1834924 - /httpd/httpd/branches/2.4.x/STATUS

2018-07-20 Thread Ruediger Pluem
On 07/20/2018 02:49 PM, Yann Ylavic wrote: > Ping, any objection if I commit this and add it to the backport proposal? Hmm. Looks like MODSSL_ERROR_BAD_GATEWAY is only used when the proxy connects to the backend. So the patch should be fine. Regards Rüdiger > > On Tue, Jul 3, 2018 at

Re: svn commit: r1832609 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

2018-07-20 Thread Ruediger Pluem
On 07/20/2018 02:45 PM, Yann Ylavic wrote: > On Fri, Jul 20, 2018 at 12:13 PM, Ruediger Pluem wrote: >> >> Something like the attached? The mod_lbmethod_byrequests.c part needs to be >> done for lb modules though. > > +/* post_config hook: */ > +static int

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Ruediger Pluem
On 07/20/2018 02:38 PM, Yann Ylavic wrote: > On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: >> >> On 07/19/2018 12:36 AM, yla...@apache.org wrote: >>> >>> -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK) { >>> +if (ap_run_input_pending(c) != OK) { >> >> We have

Re: svn commit: r1834924 - /httpd/httpd/branches/2.4.x/STATUS

2018-07-20 Thread Yann Ylavic
Ping, any objection if I commit this and add it to the backport proposal? On Tue, Jul 3, 2018 at 10:36 AM, Yann Ylavic wrote: > On Tue, Jul 3, 2018 at 8:58 AM, wrote: >> >> +++ httpd/httpd/branches/2.4.x/STATUS Tue Jul 3 06:58:55 2018 >> @@ -179,7 +179,11 @@ PATCHES PROPOSED TO BACKPORT FROM

Re: svn commit: r1832609 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

2018-07-20 Thread Yann Ylavic
On Fri, Jul 20, 2018 at 12:13 PM, Ruediger Pluem wrote: > > Something like the attached? The mod_lbmethod_byrequests.c part needs to be > done for lb modules though. +/* post_config hook: */ +static int lbmethod_byrequests_post_config(apr_pool_t *pconf, apr_pool_t *plog, +apr_pool_t

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Yann Ylavic
On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: > > On 07/19/2018 12:36 AM, yla...@apache.org wrote: >> >> -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK) { >> +if (ap_run_input_pending(c) != OK) { > > We have a different code flow here now. If

Re: Bug in mod_ratelimit?

2018-07-20 Thread Yann Ylavic
Hi Cory, On Thu, Jul 19, 2018 at 11:23 PM, Cory McIntire wrote: > > We’re going to revert to the 2.4.33 version of mod_ratelimit for now. > > HEAD requests with large amount of headers were still problematic in our > testing with both versions of the patch applied. Thanks for letting us know.

Re: svn commit: r1832609 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/howto/ docs/manual/mod/ modules/proxy/ modules/proxy/balancers/

2018-07-20 Thread Ruediger Pluem
On 07/19/2018 08:24 PM, William A Rowe Jr wrote: > On Thu, May 31, 2018 at 8:24 AM, mailto:j...@apache.org>> > wrote: > > Author: jim > Date: Thu May 31 13:24:04 2018 > New Revision: 1832609 > > URL: http://svn.apache.org/viewvc?rev=1832609=rev >

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Ruediger Pluem
On 07/19/2018 12:36 AM, yla...@apache.org wrote: > Author: ylavic > Date: Wed Jul 18 22:36:19 2018 > New Revision: 1836239 > > URL: http://svn.apache.org/viewvc?rev=1836239=rev > Log: > core: integrate data_in_{in,out}put_filter to ap_filter_{in,out}put_pending(). > > Straightforward for

[RESOLVED] Re: Regression with CMake Windows builds, 2.4.29 is the last one passing

2018-07-20 Thread Michal Karm
On 07/19/2018 08:18 PM, William A Rowe Jr wrote: > Hi Michal, thanks for your report. > > On Thu, Jul 19, 2018 at 10:36 AM, Michal Karm > wrote: > > Hi guys, > > I would like to ask whether there are any plans on > accepting [1] patch to 2.4.x as it

Re: AW: ocsp_force_default initialized with UNSET in httpd 2.4.34

2018-07-20 Thread Ruediger Pluem
Proposed for backport as r1836334. Regards Rüdiger On 07/19/2018 11:23 AM, Plüm, Rüdiger, Vodafone Group wrote: > I can do tomorrow and make a proposal in STATUS. Looks like we are all > aligned now how to resolve this. > > Regards > > Rüdiger > >> -Ursprüngliche Nachricht- >> Von:

Re: ocsp_force_default initialized with UNSET in httpd 2.4.34

2018-07-20 Thread Frank Meier
On 18/07/18 13:57, Ruediger Pluem wrote: On 07/18/2018 11:44 AM, Stefan Eissing wrote: Am 18.07.2018 um 11:37 schrieb Yann Ylavic : On Wed, Jul 18, 2018 at 11:29 AM, Ruediger Pluem wrote: Good catch. Maybe a dirty working copy during backport? Yann? Actually the change was in the