Re: [PATCH]: mod_cache: don't store headers that will never be used (fwd)

2007-10-17 Thread Niklas Edmundsson
On Wed, 10 Oct 2007, Graham Leggett wrote: Niklas Edmundsson wrote: What I'd like answered is: - Was the latest patch as suggested OK? The latest patch was the one with a directive, which is +1 from me - though is it possible to add documentation for the directive? Sure. Is

Re: [PATCH]: mod_cache: don't store headers that will never be used (fwd)

2007-10-10 Thread Niklas Edmundsson
! =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= -- Forwarded message -- From: Niklas Edmundsson [EMAIL PROTECTED] To: dev@httpd.apache.org Date: Wed, 8 Aug 2007 09:28:48 +0200 (MEST) Subject: Re: [PATCH]: mod_cache: don't store headers that will never be used Reply-To: dev@httpd.apache.org X-Bogosity: Unsure, tests

Re: [PATCH]: mod_cache: don't store headers that will never be used (fwd)

2007-10-10 Thread Graham Leggett
Niklas Edmundsson wrote: What I'd like answered is: - Was the latest patch as suggested OK? The latest patch was the one with a directive, which is +1 from me - though is it possible to add documentation for the directive? - What's the correct way of getting the mod_cache configuration

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-08-08 Thread Niklas Edmundsson
On Tue, 31 Jul 2007, Niklas Edmundsson wrote: Any opinions on this? Here's a version with a config directive, defaults to disabled. Silly Q; a directive? Or a env var that can be scoped in interesting ways using mod_setenvif and/or mod_rewrite? Most of our proxy behavior overrides are in

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-31 Thread Niklas Edmundsson
On Tue, 31 Jul 2007, Sander Striker wrote: Here's a version with a config directive, defaults to disabled. Silly Q; a directive? Or a env var that can be scoped in interesting ways using mod_setenvif and/or mod_rewrite? Most of our proxy behavior overrides are in terms of envvars. They are

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-30 Thread Niklas Edmundsson
On Sun, 29 Jul 2007, Graham Leggett wrote: What may make this workable is the combination of The body is NOT stale with max-age=0. The danger of not writing the headers is that an entity, once stale, will not be freshened when the spec says it should, and will cause a thundering herd of

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-30 Thread Graham Leggett
On Mon, July 30, 2007 10:40 am, Niklas Edmundsson wrote: What may make this workable is the combination of The body is NOT stale with max-age=0. The danger of not writing the headers is that an entity, once stale, will not be freshened when the spec says it should, and will cause a

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-30 Thread Niklas Edmundsson
On Sun, 29 Jul 2007, Roy T. Fielding wrote: The solution is to NOT rewrite the on-disk headers when the following conditions are true: - The body is NOT stale (ie. HTTP_NOT_MODIFIED when revalidating) - The on-disk header hasn't expired. - The request has max-age=0 This is perfectly OK with

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-30 Thread Niklas Edmundsson
On Mon, 30 Jul 2007, Niklas Edmundsson wrote: However, if stuff is really depending on Date/Expires being what it thinks it is (*shiver*) then I guess there won't be any other options... Here's a version with a config directive, defaults to disabled. Thoughts? /Nikke --

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-30 Thread Sander Striker
On 7/31/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Niklas Edmundsson wrote: On Mon, 30 Jul 2007, Niklas Edmundsson wrote: However, if stuff is really depending on Date/Expires being what it thinks it is (*shiver*) then I guess there won't be any other options... Here's a

[PATCH]: mod_cache: don't store headers that will never be used

2007-07-29 Thread Niklas Edmundsson
Attached is a patch for mod_cache (patch is for httpd-2.2.4) that implements what I suggested in May (see the entire thread at http://mail-archives.apache.org/mod_mbox/httpd-dev/200705.mbox/[EMAIL PROTECTED] ). The problem is that cached objects that gets hammered with Cache-Control:

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-29 Thread Graham Leggett
Niklas Edmundsson wrote: The solution is to NOT rewrite the on-disk headers when the following conditions are true: - The body is NOT stale (ie. HTTP_NOT_MODIFIED when revalidating) - The on-disk header hasn't expired. - The request has max-age=0 This is perfectly OK with RFC2616 10.3.5 and

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-29 Thread Joshua Slive
On 7/29/07, Graham Leggett [EMAIL PROTECTED] wrote: Niklas Edmundsson wrote: The solution is to NOT rewrite the on-disk headers when the following conditions are true: - The body is NOT stale (ie. HTTP_NOT_MODIFIED when revalidating) - The on-disk header hasn't expired. - The request

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-29 Thread Henrik Nordstrom
On sön, 2007-07-29 at 20:34 +0200, Graham Leggett wrote: Niklas Edmundsson wrote: The solution is to NOT rewrite the on-disk headers when the following conditions are true: - The body is NOT stale (ie. HTTP_NOT_MODIFIED when revalidating) - The on-disk header hasn't expired. - The

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-29 Thread Graham Leggett
Joshua Slive wrote: What needs to be validated is if, in fact, the headers with NEVER be used. Is there any configuration directive or client request that could make mod_cache use headers from the cache when max-age=0? I don't think so. The headers will be used by the next request - not just

Re: [PATCH]: mod_cache: don't store headers that will never be used

2007-07-29 Thread Roy T. Fielding
On Jul 29, 2007, at 1:03 AM, Niklas Edmundsson wrote: Attached is a patch for mod_cache (patch is for httpd-2.2.4) that implements what I suggested in May (see the entire thread at http://mail-archives.apache.org/mod_mbox/httpd-dev/200705.mbox/% [EMAIL PROTECTED] ). The problem is that