Justin Erenkrantz wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable
in 15
minute patches and I'll review them.
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
Bill Stoddard wrote:
/* Open the headers file */
-rc = apr_file_open(hfd, headers, APR_READ|APR_BINARY, 0, r-pool);
+rc = apr_file_open(hfd, headers, flags, 0, r-pool);
Should be something like this adapted from core:
core_dir_config *core_config;
core_config = (core_dir_config *)
Brian Akins wrote:
Bill Stoddard wrote:
/* Open the headers file */
-rc = apr_file_open(hfd, headers, APR_READ|APR_BINARY, 0, r-pool);
+rc = apr_file_open(hfd, headers, flags, 0, r-pool);
Should be something like this adapted from core:
core_dir_config *core_config;
core_config =
At 10:46 AM 8/2/2004, Bill Stoddard wrote:
EnableSendfile off is a global directive (?) so only need to check it once at startup
and save it in a static variable?
Oh, no!
Directory /fs1/shared/www
EnableSendfile Off
/Directory
kills sendfile for that mount.
Bill
William A. Rowe, Jr. wrote:
Oh, no!
Directory /fs1/shared/www
EnableSendfile Off
/Directory
kills sendfile for that mount.
Bill
However, in a quick handler, only the global config matters. Am I
correct? Because the per_dir has not been merged until map to storage
and Location is later.
--On Monday, August 2, 2004 10:35 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
-1, Need to check for EnableSendfile off.
No, core_output_filter does that check. Modules don't have that information
whether
Justin Erenkrantz wrote:
--On Monday, August 2, 2004 10:35 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
-1, Need to check for EnableSendfile off.
No, core_output_filter does that check. Modules don't have that
--On Monday, August 2, 2004 1:05 PM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
I should amend my vote a -.5. The patch should work as you've coded it but
opening a file for use with apr_sendfile causes the file to be opened for
overlapped i/o on Windows. I expect some of the codepaths will
Justin Erenkrantz wrote:
--On Monday, August 2, 2004 1:05 PM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
I should amend my vote a -.5. The patch should work as you've coded it
but
opening a file for use with apr_sendfile causes the file to be opened for
overlapped i/o on Windows. I expect
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
Index:
10 matches
Mail list logo