Re: [Patch] non blocking writes in core

2013-11-21 Thread Graham Leggett
On 21 Nov 2013, at 4:50 PM, Plüm, Rüdiger, Vodafone Group wrote: > If this filter sets aside all stuff until eos (or a flush bucket) is seen it > might > cause a huge amount of memory consumption. So we possibly need some limit for > memory consuming > buckets which when passed causes us to se

RE: [Patch] non blocking writes in core

2013-11-21 Thread Plüm , Rüdiger , Vodafone Group
> -Original Message- > From: Graham Leggett [mailto:minf...@sharp.fm] > Sent: Donnerstag, 21. November 2013 14:58 > To: dev@httpd.apache.org > Subject: Re: [Patch] non blocking writes in core > > On 21 Nov 2013, at 10:43 AM, Joe Orton wrote: > > > Those

Re: [Patch] non blocking writes in core

2013-11-21 Thread Graham Leggett
On 21 Nov 2013, at 10:43 AM, Joe Orton wrote: > Those rules are written (explicitly) for resource-level filters. They > would have to be a little different for CONNECTION level, e.g. EOS > handling should probably be different... though I'm not sure how we'd > write the rule. Probably connec

Re: [Patch] non blocking writes in core

2013-11-21 Thread Jim Jagielski
/me like :) On Nov 21, 2013, at 8:57 AM, Graham Leggett wrote: > Given that the world must be given an opportunity to migrate to async > filters, we would need to support both at the same time. > > What I am thinking is that a filter registers itself either as a legacy > synchronous filter (y

Re: [Patch] non blocking writes in core

2013-11-21 Thread Joe Orton
On Tue, Nov 19, 2013 at 07:44:07PM +0200, Graham Leggett wrote: > On 18 Nov 2013, at 1:24 PM, "Plüm, Rüdiger, Vodafone Group" > wrote: > > > +rv = send_brigade_nonblocking(net->client_socket, bb, > > + &(ctx->bytes_written), c); > > +if (APR_S

RE: [Patch] non blocking writes in core

2013-11-19 Thread Bert Huijben
> -Original Message- > From: Graham Leggett [mailto:minf...@sharp.fm] > Sent: dinsdag 19 november 2013 18:44 > To: dev@httpd.apache.org > Subject: Re: [Patch] non blocking writes in core > > On 18 Nov 2013, at 1:24 PM, "Plüm, Rüdiger, Vodafone Group&quo

Re: [Patch] non blocking writes in core

2013-11-19 Thread Graham Leggett
On 19 Nov 2013, at 7:44 PM, Graham Leggett wrote: > This is indeed broken, fixed. > > Some more testing has revealed that mod_ssl's output filter breaks rules 2 > and 5 of the 10 output filter rules published here: > http://httpd.apache.org/docs/trunk/da/developer/output-filters.html#rules >

Re: [Patch] non blocking writes in core

2013-11-19 Thread Graham Leggett
On 18 Nov 2013, at 1:24 PM, "Plüm, Rüdiger, Vodafone Group" wrote: > +rv = send_brigade_nonblocking(net->client_socket, bb, > + &(ctx->bytes_written), c); > +if (APR_STATUS_IS_EAGAIN(rv)) { > +setaside_remaining_output(f, ctx, bb,

RE: [Patch] non blocking writes in core

2013-11-18 Thread Plüm , Rüdiger , Vodafone Group
ot; instead of "EOC" (copy and paste error?) Otherwise looks sensible from a brief look. Regards Rüdiger > -Original Message- > From: Graham Leggett > Sent: Sonntag, 17. November 2013 20:41 > To: dev@httpd.apache.org > Subject: [Patch] non blocking writes

[Patch] non blocking writes in core

2013-11-17 Thread Graham Leggett
Hi all, Continuing on from the discussion about how we might support write completion in mod_ssl, I have come up with the following patch below. I started by changing the event MPM to call all protocol filters instead of just the hard coded write filter: rv = ap_pass_brigade(c->output_