Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-31 Thread Randy Kobes
On Tue, 25 Jul 2006, Randy Kobes wrote: On Tue, 25 Jul 2006, Steve Hay wrote: Yes, that works for me! I tried the individual test and the whole test suite dozens of times over and didn't get a single failure. I'm not sure how it makes any difference, though, or exactly what it does. I

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-31 Thread Philip M. Gollucci
Nevertheless, unless someone objects in the next day or so, I'd like to commit this change, as I think leaving temp files lying around is a worse problem. No objection here :) -- Philip M. Gollucci ([EMAIL PROTECTED])

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-25 Thread Steve Hay
Randy Kobes wrote: On Mon, 24 Jul 2006, Steve Hay wrote: Randy Kobes wrote: Also, just to verify that it is the stray temp files left over that are causing the problem, does it help if you change the APR_EXCL flag in the call to apr_file_mktemp on about line 832 of library/util.c to

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-25 Thread Randy Kobes
On Tue, 25 Jul 2006, Steve Hay wrote: Yes, that works for me! I tried the individual test and the whole test suite dozens of times over and didn't get a single failure. I'm not sure how it makes any difference, though, or exactly what it does. I searched the whole of my httpd-2.2.2 folder

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-24 Thread Philip M. Gollucci
Steve Hay wrote: Sorry, but I'm still seeing quite a few failures. I started with a completely fresh build (with your patch applied) and the top-level nmake test failed a bunch of upload.t tests first time. (So it's not just running the test multiple times that causes the problem.) I then

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-24 Thread Steve Hay
Randy Kobes wrote: On Mon, 24 Jul 2006, Steve Hay wrote: Sorry, but I'm still seeing quite a few failures. I started with a completely fresh build (with your patch applied) and the top-level nmake test failed a bunch of upload.t tests first time. (So it's not just running the test multiple

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-24 Thread Randy Kobes
On Mon, 24 Jul 2006, Steve Hay wrote: Randy Kobes wrote: Also, just to verify that it is the stray temp files left over that are causing the problem, does it help if you change the APR_EXCL flag in the call to apr_file_mktemp on about line 832 of library/util.c to APR_TRUNCATE? Yep, that

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-24 Thread Steve Hay
Philip M. Gollucci wrote: Steve Hay wrote: Sorry, but I'm still seeing quite a few failures. I started with a completely fresh build (with your patch applied) and the top-level nmake test failed a bunch of upload.t tests first time. (So it's not just running the test multiple times that

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-24 Thread Randy Kobes
On Mon, 24 Jul 2006, Steve Hay wrote: Sorry, but I'm still seeing quite a few failures. I started with a completely fresh build (with your patch applied) and the top-level nmake test failed a bunch of upload.t tests first time. (So it's not just running the test multiple times that causes

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-23 Thread Randy Kobes
On Fri, 21 Jul 2006, Philip M. Gollucci wrote: Philip M. Gollucci wrote: Philip M. Gollucci wrote: Randy Kobes wrote: Which means apr_pool_cleanup_register(pool, data, apreq_file_cleanup, apreq_file_cleanup); Contrary to the comment in library/util.c data =

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-21 Thread Philip M. Gollucci
Philip M. Gollucci wrote: Randy Kobes wrote: [Thu Jul 20 23:45:45 2006] [error] [client 127.0.0.1] (OS 80)The file exists. : apreq_brigade_concat failed; TempDir problem? which is coming from about line 288 of module/apache2/filter.c. The file exists message I think comes from the fact

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-21 Thread Philip M. Gollucci
Philip M. Gollucci wrote: Philip M. Gollucci wrote: Randy Kobes wrote: Which means apr_pool_cleanup_register(pool, data, apreq_file_cleanup, apreq_file_cleanup); Contrary to the comment in library/util.c data = apr_palloc(pool, sizeof *data); /* cleanups

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-20 Thread Randy Kobes
On Thu, 20 Jul 2006, Philip M. Gollucci wrote: Steve Hay wrote: repeatedly from the glue/perl sub-directory and see whether or not it ever fails for you. Did you get round to trying that? Just did. 24 times. 100% success. My usual combination of things. Like Steve, I still see this

Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-20 Thread Bojan Smojver
Quoting Philip M. Gollucci [EMAIL PROTECTED]: Please download, test, and VOTE on the following candidate tarball: http://people.apache.org/~pgollucci/apreq2/libapreq2-2.08-RC4.tar.gz The Fedora Extras package (development) will be available after signing. -- Bojan