Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Yann Ylavic
On Fri, Feb 21, 2020 at 5:02 PM Steffen wrote: > > It works. Thanks for testing. > > Patch Output mod_ssl.c: Looks good. > > How to test that the new OPENSSL_init_ssl() API, for OpenSSL = 1.1. is used ? It is used provided the version is >= 1.1.0. Runtime testing would be to make sure

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Steffen
It works. Builds against 1.1.1 and runs with r1874323, Attached the two files, so you can check that the patch is ok ? (With Windows sometimes Patch gets confused) Patch Output mod_ssl.c: patching file modules/ssl/mod_ssl.c Hunk #2 succeeded at 328 (offset -6 lines). patch unexpectedly

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Luca Toscano
Il giorno ven 21 feb 2020 alle ore 13:36 Ruediger Pluem ha scritto: > > > > On 02/21/2020 11:14 AM, Yann Ylavic wrote: > > Hi Steffen, > > > > On Fri, Feb 21, 2020 at 10:23 AM Steffen wrote: > >> > >> Building revision 1874291 failed in Windows. > >> > >> mod_ssl.c(27,10): fatal error C1083:

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Yann Ylavic
On Fri, Feb 21, 2020 at 2:39 PM Ruediger Pluem wrote: > > So we need to have a solution in place that works on Windows and Unix and I > believe the solution from Yann does. What about r1874323 ? Using "ap_config.h" would exclude Windows from the new OPENSSL_init_ssl() API, even for OpenSSL >=

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Ruediger Pluem
On 02/21/2020 02:23 PM, Steffen wrote: > I run without it. > > Does that have a draw back ? Removing it likely breaks the Unix builds. So we need to have a solution in place that works on Windows and Unix and I believe the solution from Yann does. Hence it would be very helpful if you

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Steffen
I run without it. Does that have a draw back ? Steffen > Op 21 feb. 2020 om 13:36 heeft Ruediger Pluem het > volgende geschreven: > >  > >> On 02/21/2020 11:14 AM, Yann Ylavic wrote: >> Hi Steffen, >> >>> On Fri, Feb 21, 2020 at 10:23 AM Steffen wrote: >>> >>> Building revision

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Ruediger Pluem
On 02/21/2020 11:14 AM, Yann Ylavic wrote: > Hi Steffen, > > On Fri, Feb 21, 2020 at 10:23 AM Steffen wrote: >> >> Building revision 1874291 failed in Windows. >> >> mod_ssl.c(27,10): fatal error C1083: Cannot open include file: >> 'ap_config_auto.h': No such file or directory > > Better if

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Steffen
Yesterday it was building fine (before 1874281 ), was no ap_config.. So I removed #include "ap_config_auto.h", builds and runs fine so far. Steffen On Friday 21/02/2020 at 11:14, Yann Ylavic wrote: Hi Steffen, On Fri, Feb 21, 2020 at 10:23 AM Steffen wrote: Building revision

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Yann Ylavic
Hi Steffen, On Fri, Feb 21, 2020 at 10:23 AM Steffen wrote: > > Building revision 1874291 failed in Windows. > > mod_ssl.c(27,10): fatal error C1083: Cannot open include file: > 'ap_config_auto.h': No such file or directory Better if you #include "ap_config.h" instead? Regards, Yann.

Re: Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Steffen
Typo in the subject must be: branches 2.4.x (2.4.42-dev) On Friday 21/02/2020 at 10:23, Steffen wrote: Building revision 1874291 failed in Windows. mod_ssl.c(27,10): fatal error C1083: Cannot open include file: 'ap_config_auto.h': No such file or directory Steffen

Branches 2.4.12-dev fails mod_ssl

2020-02-21 Thread Steffen
Building revision 1874291 failed in Windows. mod_ssl.c(27,10): fatal error C1083: Cannot open include file: 'ap_config_auto.h': No such file or directory Steffen