Re: Bug with mod_xml2enc and docx files

2013-06-06 Thread Thomas Eckert
Would you please let me know once you have completed/commited this ? I much rather copy your fix locally and apply it until the next upgrade where it would be contained anyway, instead of live with another custom patch. On Tue, Jun 4, 2013 at 1:13 AM, Nick Kew n...@webthing.com wrote: On 3 Jun

Re: Bug with mod_xml2enc and docx files

2013-06-03 Thread Thomas Eckert
I attached what I have in mind on how to solve this. It's basically what you suggested. There's one thing I didn't know how to address and that is mod_proxy_html's ProxyHTMLExtended directive. It does suggest not to be turned on by default (

Re: Bug with mod_xml2enc and docx files

2013-06-03 Thread Nick Kew
On 3 Jun 2013, at 14:31, Thomas Eckert wrote: mod_xml2enc_ctype.patch Thanks. Looks a lot like the patch I hacked up but have yet to test or commit :) -- Nick Kew

Bug with mod_xml2enc and docx files

2013-05-29 Thread Thomas Eckert
Downloading a .docx file through a HTML rewriting reverse-proxy suddenly increased file size by 5 kB. So looking at modules/filters/mod_xml2enc :: static apr_status_t xml2enc_ffunc(ap_filter_t* f, apr_bucket_brigade* bb) I saw the following /* only act if starts-with text/ or contains xml

Re: Bug with mod_xml2enc and docx files

2013-05-29 Thread Nick Kew
On 29 May 2013, at 14:28, Thomas Eckert wrote: I saw the following /* only act if starts-with text/ or contains xml */ if (strncmp(ctype, text/, 5) !strstr(ctype, xml)) { ap_remove_output_filter(f); return ap_pass_brigade(f-next, bb) ; } You're right,