Re: Ceph patches for httpd

2014-01-02 Thread Justin Erenkrantz
On Thu, Jan 2, 2014 at 11:04 AM, Kean Johnston wrote: > Why don't you move the integer comparison to ahead of the apr_table_get and > strcmp()? That way relatively expensive options get boolean short-circuited. If we switch it to the default, then yah, that can help short-circuit it. If it's not

Re: Ceph patches for httpd

2014-01-02 Thread Kean Johnston
On 12/30/2013 10:07 PM, Justin Erenkrantz wrote: On Sun, Dec 29, 2013 at 3:48 PM, Jim Jagielski wrote: Index: modules/http/http_filters.c === --- modules/http/http_filters.c (revision 1554304) +++ modules/http/http_filters.c (workin

Re: Ceph patches for httpd

2014-01-02 Thread Jim Jagielski
+1 On Dec 30, 2013, at 3:07 PM, Justin Erenkrantz wrote: > On Sun, Dec 29, 2013 at 3:48 PM, Jim Jagielski wrote: >> Yeah, I'm leaning towards agreeing w/ you there. > > Both directives (HttpContentLengthHeadZero and HttpExpectStrict) > committed in r1554303. See below for how it affects the w

Re: Ceph patches for httpd

2013-12-30 Thread Justin Erenkrantz
On Sun, Dec 29, 2013 at 3:48 PM, Jim Jagielski wrote: > Yeah, I'm leaning towards agreeing w/ you there. Both directives (HttpContentLengthHeadZero and HttpExpectStrict) committed in r1554303. See below for how it affects the wire protocol. Now, let's discuss the defaults. =) I'm +1 to the be

Re: Ceph patches for httpd

2013-12-29 Thread Jim Jagielski
Yeah, I'm leaning towards agreeing w/ you there. On Dec 29, 2013, at 12:44 PM, Justin Erenkrantz wrote: > to trunk. We can discuss the defaults separately. But, the more I > think about it, hiding C-L of 0 on HEAD seems like an incorrect > out-of-the-box behavior. -- justin >

Re: OT (Was: Re: Ceph patches for httpd)

2013-12-29 Thread Jim Jagielski
Agreed. Thx for seeing those patches and proposing them being added! On Dec 29, 2013, at 12:26 PM, Justin Erenkrantz wrote: > This is why I am trying to fold the patches back in. There is a definite > difference between open source and a real community. =) -- justin > > On Dec 29, 2013 10:1

Re: Ceph patches for httpd

2013-12-29 Thread Justin Erenkrantz
On Sun, Dec 29, 2013 at 10:16 AM, Jim Jagielski wrote: > As defaults, I'm -0, but as controllable alternatives: +1 I will whip up a patch for these two - will probably commit straight to trunk. We can discuss the defaults separately. But, the more I think about it, hiding C-L of 0 on HEAD seems

Re: OT (Was: Re: Ceph patches for httpd)

2013-12-29 Thread Justin Erenkrantz
This is why I am trying to fold the patches back in. There is a definite difference between open source and a real community. =) -- justin On Dec 29, 2013 10:17 AM, "Jim Jagielski" wrote: > It is for reasons like this that I tend to dislike Github, > simply because it creates this mentality...

Re: Ceph patches for httpd

2013-12-29 Thread Jim Jagielski
As defaults, I'm -0, but as controllable alternatives: +1 On Dec 27, 2013, at 8:57 AM, Justin Erenkrantz wrote: > Hi all! > > There are two patches that the Ceph community has applied to their httpd > packages in combination with radosgw (S3 endpoint) - (see > https://github.com/ceph/apache2)

OT (Was: Re: Ceph patches for httpd)

2013-12-29 Thread Jim Jagielski
It is for reasons like this that I tend to dislike Github, simply because it creates this mentality... What mentality you may say? The mentality to work separate from the community. I am sure that there are useful things in this repo, but instead of working w/ us, and making us aware of them, they

Re: Ceph patches for httpd

2013-12-27 Thread Justin Erenkrantz
On Fri, Dec 27, 2013 at 10:53 AM, Ask Bjørn Hansen wrote: > > On Dec 27, 2013, at 14:57, Justin Erenkrantz > wrote: > > > The use case here is that someone could store a zero-byte file inside of > radosgw. Amazon's S3 clients expect to see a Content-Length on HEAD > requests - IOW, they don't in

Re: Ceph patches for httpd

2013-12-27 Thread Frederick Miller
Please stop sending me these emails. On Fri, Dec 27, 2013 at 10:53 AM, Ask Bjørn Hansen wrote: > > On Dec 27, 2013, at 14:57, Justin Erenkrantz > wrote: > > > The use case here is that someone could store a zero-byte file inside of > radosgw. Amazon's S3 clients expect to see a Content-Length

Re: Ceph patches for httpd

2013-12-27 Thread Frederick Miller
How can I unsubscribe from these emails? On Fri, Dec 27, 2013 at 10:53 AM, Ask Bjørn Hansen wrote: > > On Dec 27, 2013, at 14:57, Justin Erenkrantz > wrote: > > > The use case here is that someone could store a zero-byte file inside of > radosgw. Amazon's S3 clients expect to see a Content-Len

Re: Ceph patches for httpd

2013-12-27 Thread Ask Bjørn Hansen
On Dec 27, 2013, at 14:57, Justin Erenkrantz wrote: > The use case here is that someone could store a zero-byte file inside of > radosgw. Amazon's S3 clients expect to see a Content-Length on HEAD requests > - IOW, they don't infer the lack of a Content-Length as being '0'. If we > weren't

Ceph patches for httpd

2013-12-27 Thread Justin Erenkrantz
Hi all! There are two patches that the Ceph community has applied to their httpd packages in combination with radosgw (S3 endpoint) - (see https://github.com/ceph/apache2). One of them is to allow Content-Length of '0' to be emitted from HEAD requests: https://github.com/ceph/apache2/commit/0d99