Re: EOS is not being sent for HEAD requests

2004-03-02 Thread Justin Erenkrantz
--On Monday, March 1, 2004 11:20 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote: I've stepped through with gdb, ap_finalize_request_protocol is called and EOS is sent, but it gets lost and doesn't reach the connection output filter. That'd mean that a filter isn't passing it on as it should be.

Re: EOS is not being sent for HEAD requests

2004-03-02 Thread Stas Bekman
Justin Erenkrantz wrote: --On Monday, March 1, 2004 11:20 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote: I've stepped through with gdb, ap_finalize_request_protocol is called and EOS is sent, but it gets lost and doesn't reach the connection output filter. That'd mean that a filter isn't

Re: EOS is not being sent for HEAD requests

2004-03-02 Thread Bojan Smojver
If you have mod_logio configured, this might be its doing. It replaces the EOS with FLUSH. This is in order to make sure all output is counted and logged properly for each request. Here is the code from mod_logio that does that: --- static

Re: EOS is not being sent for HEAD requests

2004-03-02 Thread Stas Bekman
Bojan Smojver wrote: If you have mod_logio configured, this might be its doing. It replaces the EOS with FLUSH. This is in order to make sure all output is counted and logged properly for each request. Here is the code from mod_logio that does that:

Re: EOS is not being sent for HEAD requests

2004-03-02 Thread Bojan Smojver
On Wed, 2004-03-03 at 07:42, Stas Bekman wrote: ... but he just gave a good example where a filter is not well behaved (by a non-existing well-behaved-filters Apache spec). I'm not sure exactly why I can't have a FLUSH bucket followed by an EOS bucket, but I'm pretty sure I wanted to keep

Re: EOS is not being sent for HEAD requests

2004-03-02 Thread Cliff Woolley
On Wed, 3 Mar 2004, Bojan Smojver wrote: If you have mod_logio configured, this might be its doing. It replaces the EOS with FLUSH. This is in order to make sure all output is counted and logged properly for each request. That's bad. :) If you have to do that, then something else is broken.

Re: EOS is not being sent for HEAD requests

2004-03-02 Thread Bojan Smojver
On Wed, 2004-03-03 at 10:27, Cliff Woolley wrote: That would be a problem because then you'd have a FLUSH bucket *after* your EOS bucket in brigade bb (or at least that's what I assume from the context given here without actually pulling up the whole module), which is illegal. I think the

EOS is not being sent for HEAD requests

2004-03-01 Thread Stas Bekman
in 2.0 - Connection output filters don't recieve the EOS bucket when the request method is HEAD. This breaks the idiom of flushing any stored data when the eos bucket is seen. And some filters could be broken because of that. A typical response filter sees this for the following 3 brigades for

Re: EOS is not being sent for HEAD requests

2004-03-01 Thread Andr Malo
* Stas Bekman [EMAIL PROTECTED] wrote: in 2.0 - Connection output filters don't recieve the EOS bucket when the request method is HEAD. This breaks the idiom of flushing any stored data when the eos bucket is seen. And some filters could be broken because of that. I believe that is because

Re: EOS is not being sent for HEAD requests

2004-03-01 Thread Stas Bekman
André Malo wrote: * Stas Bekman [EMAIL PROTECTED] wrote: in 2.0 - Connection output filters don't recieve the EOS bucket when the request method is HEAD. This breaks the idiom of flushing any stored data when the eos bucket is seen. And some filters could be broken because of that. I believe

Re: EOS is not being sent for HEAD requests

2004-03-01 Thread Justin Erenkrantz
--On Monday, March 1, 2004 9:55 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote: I see that with a non-broken handler which sends the response body unconditionally. The output I've posted in my original email is all that's seen by an output connection filter. Why is ap_finalize_request_protocol not

Re: EOS is not being sent for HEAD requests

2004-03-01 Thread Stas Bekman
Justin Erenkrantz wrote: --On Monday, March 1, 2004 9:55 PM -0800 Stas Bekman [EMAIL PROTECTED] wrote: I see that with a non-broken handler which sends the response body unconditionally. The output I've posted in my original email is all that's seen by an output connection filter. Why is