Re: Improve mod_proxy's error marking of workers

2013-05-08 Thread Thomas Eckert
I think you need to screen out 4xx at least to prevent client errors from marking down your backends. Seems like those responses never reach that code. Neither 400 nor 401 or 403 had an effect on the worker's error state, it always remained in state 'OK'. I'd like to say it's not an issue but

Improve mod_proxy's error marking of workers

2013-05-07 Thread Thomas Eckert
Attached patch contains a directive to improve the error marking of workers. Basically, some errors will cause a worker to be marked as in error while others don't. I can't see a reason for this so I added a directive to have all errors mark the error correctly - especially useful for automated

Re: Improve mod_proxy's error marking of workers

2013-05-07 Thread Eric Covener
On Tue, May 7, 2013 at 6:24 AM, Thomas Eckert thomas.r.w.eck...@gmail.com wrote: Attached patch contains a directive to improve the error marking of workers. Basically, some errors will cause a worker to be marked as in error while others don't. I can't see a reason for this so I added a

Re: Improve mod_proxy's error marking of workers

2013-05-07 Thread Jim Jagielski
Agreed... An all or nothing setting will likely create more trouble than not. On May 7, 2013, at 8:08 AM, Eric Covener cove...@gmail.com wrote: On Tue, May 7, 2013 at 6:24 AM, Thomas Eckert thomas.r.w.eck...@gmail.com wrote: Attached patch contains a directive to improve the error marking of

Re: Improve mod_proxy's error marking of workers

2013-05-07 Thread Daniel Ruggeri
On 5/7/2013 2:00 PM, Jim Jagielski wrote: Agreed... An all or nothing setting will likely create more trouble than not. On May 7, 2013, at 8:08 AM, Eric Covener cove...@gmail.com wrote: On Tue, May 7, 2013 at 6:24 AM, Thomas Eckert thomas.r.w.eck...@gmail.com wrote: Attached patch contains