Re: Question and request for comments on patch

2011-07-27 Thread Daniel Ruggeri
On 7/26/2011 6:29 PM, Daniel Ruggeri wrote: > Both points taken and implemented. Regarding invalid directives, I set > it as a warning informing that the directive is being discarded. I never > actually tested apr_tables to see if they were case sensitive but had > assumed they were. The offending

Re: Question and request for comments on patch (now failure to commit)

2011-07-27 Thread William A. Rowe Jr.
On 7/27/2011 1:11 AM, Stefan Fritsch wrote: > On Wednesday 27 July 2011, Daniel Ruggeri wrote: >> That seems to have changed the error message, but no luck actually >> making things stick. I also tried removing the local source tree, >> pulling from https, applying the patch and trying again withou

Re: Question and request for comments on patch (now failure to commit)

2011-07-27 Thread Stefan Fritsch
On Wednesday 27 July 2011, Daniel Ruggeri wrote: > That seems to have changed the error message, but no luck actually > making things stick. I also tried removing the local source tree, > pulling from https, applying the patch and trying again without > luck. Not sure if there are remote logs I'd b

Re: Question and request for comments on patch (now failure to commit)

2011-07-27 Thread Daniel Ruggeri
On 7/26/2011 9:05 PM, Eric Covener wrote: > you have to check out as, or switch to, https to commit. > > I believe "svn switch --relocate http://... https://..."; is close. That seems to have changed the error message, but no luck actually making things stick. I also tried removing the local source

Re: Question and request for comments on patch

2011-07-26 Thread Eric Covener
> > I attempted to commit this, but ran into the following error. This is my > first try to commit, so I very well may be doing something wrong. I'm > attempting from my machine here at home rather than minotaur. Any > suggestions? > > svn checkout http://svn.apache.org/repos/asf/httpd/httpd/trunk

Re: Question and request for comments on patch

2011-07-26 Thread Daniel Ruggeri
On 7/26/2011 5:02 AM, Stefan Fritsch wrote: > This is valid use-case which justifies making it available somehow. > But actually, I think something like > > module *mod = &ap_top_module; > ap_find_command_in_modules(cmd, mod); > > should already work without the need for an additional API. This wa

RE: Question and request for comments on patch

2011-07-26 Thread Plüm, Rüdiger, VF-Group
> -Original Message- > From: Daniel Ruggeri > Sent: Montag, 25. Juli 2011 01:36 > To: dev@httpd.apache.org > Subject: Re: Question and request for comments on patch > and unavailable to core.c where the configuration directive is > implemented? If I'm off,

Re: Question and request for comments on patch

2011-07-26 Thread Stefan Fritsch
On Monday 25 July 2011, Daniel Ruggeri wrote: > On 7/24/2011 2:12 AM, Stefan Fritsch wrote: > > When parsing the list, look in ap_config_hash if a directive > > exists. If not, either log a warning or error out (not sure > > which is better). > > I may be missing something, but isn't ap_config_has

Re: Question and request for comments on patch

2011-07-24 Thread Daniel Ruggeri
On 7/24/2011 2:12 AM, Stefan Fritsch wrote: > On Friday 22 July 2011, Daniel Ruggeri wrote: >> Attached is the final cut of the patch including doco and MMN bump >> as you brought up. I plan to commit this on Monday, time >> permitting (and of course in the absence of objections). I'll >> cobble so

Re: Question and request for comments on patch

2011-07-24 Thread Stefan Fritsch
On Sun, 24 Jul 2011, Stefan Fritsch wrote: and an empty one for some virtual hosts. In the case of an empty list, d->override_list should be set to NULL instead of an empty table for better performance. Well, this would require some additional logic for the config merge. Maybe it's not worth

Re: Question and request for comments on patch

2011-07-24 Thread Stefan Fritsch
On Friday 22 July 2011, Daniel Ruggeri wrote: > Attached is the final cut of the patch including doco and MMN bump > as you brought up. I plan to commit this on Monday, time > permitting (and of course in the absence of objections). I'll > cobble something together afterwards for a 2.2 backport. +

Re: Question and request for comments on patch

2011-07-22 Thread Rich Bowen
On Jul 19, 2011, at 7:44 PM, Daniel Ruggeri wrote: > All; > I am attaching a patch that will allow for a comma separated list of > directives permissable for override. This is something that has been requested by folks on the users mailing list, and on IRC, as far back as I've been watching.

Re: Question and request for comments on patch

2011-07-21 Thread Daniel Ruggeri
On 7/21/2011 3:32 AM, Igor Galić wrote: > I think you're missing an MMN bump, regarding backporting - or API in > general, the wrapper is the right way to go. > Also: Why not patch against trunk? > > i > > Daniel Ruggeri wrote: > >> All; >> I am attaching a patch that will allow for a comma sep

RE: Question and request for comments on patch

2011-07-21 Thread Igor Galić
I think you're missing an MMN bump, regarding backporting - or API in general, the wrapper is the right way to go. Also: Why not patch against trunk? i Daniel Ruggeri wrote: >All; > I am attaching a patch that will allow for a comma separated list of >directives permissable for override. I a

Question and request for comments on patch

2011-07-19 Thread Daniel Ruggeri
All; I am attaching a patch that will allow for a comma separated list of directives permissable for override. I am doing this because the existing AllowOverride list of override-able directives sometimes has too many things, sometimes allows more than is documented and it also forces third part