Re: [Patch] non blocking writes in core

2013-11-21 Thread Joe Orton
On Tue, Nov 19, 2013 at 07:44:07PM +0200, Graham Leggett wrote: On 18 Nov 2013, at 1:24 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: +rv = send_brigade_nonblocking(net-client_socket, bb, + (ctx-bytes_written), c); +

Re: [Patch] non blocking writes in core

2013-11-21 Thread Graham Leggett
On 21 Nov 2013, at 10:43 AM, Joe Orton jor...@redhat.com wrote: Those rules are written (explicitly) for resource-level filters. They would have to be a little different for CONNECTION level, e.g. EOS handling should probably be different... though I'm not sure how we'd write the rule.

RE: [Patch] non blocking writes in core

2013-11-21 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Graham Leggett [mailto:minf...@sharp.fm] Sent: Donnerstag, 21. November 2013 14:58 To: dev@httpd.apache.org Subject: Re: [Patch] non blocking writes in core On 21 Nov 2013, at 10:43 AM, Joe Orton jor...@redhat.com wrote: Those rules are written

Re: [Patch] non blocking writes in core

2013-11-21 Thread Graham Leggett
On 21 Nov 2013, at 4:50 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: If this filter sets aside all stuff until eos (or a flush bucket) is seen it might cause a huge amount of memory consumption. So we possibly need some limit for memory consuming buckets which when

Re: [Patch] non blocking writes in core

2013-11-21 Thread Jim Jagielski
/me like :) On Nov 21, 2013, at 8:57 AM, Graham Leggett minf...@sharp.fm wrote: Given that the world must be given an opportunity to migrate to async filters, we would need to support both at the same time. What I am thinking is that a filter registers itself either as a legacy

Re: [Patch] non blocking writes in core

2013-11-19 Thread Graham Leggett
On 18 Nov 2013, at 1:24 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote: +rv = send_brigade_nonblocking(net-client_socket, bb, + (ctx-bytes_written), c); +if (APR_STATUS_IS_EAGAIN(rv)) { +

Re: [Patch] non blocking writes in core

2013-11-19 Thread Graham Leggett
On 19 Nov 2013, at 7:44 PM, Graham Leggett minf...@sharp.fm wrote: This is indeed broken, fixed. Some more testing has revealed that mod_ssl's output filter breaks rules 2 and 5 of the 10 output filter rules published here:

RE: [Patch] non blocking writes in core

2013-11-19 Thread Bert Huijben
-Original Message- From: Graham Leggett [mailto:minf...@sharp.fm] Sent: dinsdag 19 november 2013 18:44 To: dev@httpd.apache.org Subject: Re: [Patch] non blocking writes in core On 18 Nov 2013, at 1:24 PM, Plüm, Rüdiger, Vodafone Group ruediger.pl...@vodafone.com wrote

RE: [Patch] non blocking writes in core

2013-11-18 Thread Plüm , Rüdiger , Vodafone Group
Some comments: @@ -581,6 +564,33 @@ eor_buckets_in_brigade, morphing_bucket_in_brigade); } +/* Handle non blocking writes. If we saw a non blocking bucket, attempt + * a non blocking write. If the non blocking write would have returned + * APR_EGAIN, set