RE: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: justin.erenkra...@gmail.com Sent: Mittwoch, 25. August 2010 08:14 To: dev@httpd.apache.org Cc: Subversion Development Subject: httpd trunk broken with Subversion: ap_log_rerror busted In r951893, httpd modified a #define for APLOG_MARK to add in a

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Rainer Jung
On 25.08.2010 10:59, Plüm, Rüdiger, VF-Group wrote: -Original Message- From: justin.erenkra...@gmail.com Yes, we could fix this by making mod_authz_svn conditional on the new MMN, but - again, it's about even figuring out that the API is changed and what to do about it. The root

RE: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Rainer Jung Sent: Mittwoch, 25. August 2010 11:15 To: dev@httpd.apache.org Cc: Subversion Development Subject: Re: httpd trunk broken with Subversion: ap_log_rerror busted On 25.08.2010 10:59, Plüm, Rüdiger, VF-Group wrote: -Original Message

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Rainer Jung
On 25.08.2010 11:19, Plüm, Rüdiger, VF-Group wrote: Maybe we should put a link to http://httpd.apache.org/docs/trunk/developer/new_api_2_4.html in the Module Developer Changes section in http://httpd.apache.org/docs/trunk/new_features_2_4.html Done in r988987. Rainer

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Stefan Fritsch
On Tue, 24 Aug 2010, Justin Erenkrantz wrote: In r951893, httpd modified a #define for APLOG_MARK to add in a new parameter called APLOG_MODULE_INDEX (in addition to file and line info). This busts Subversion - specifically, mod_authz_svn which has a function called: static void

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 1:59 AM, Plüm, Rüdiger, VF-Group ruediger.pl...@vodafone.com wrote: Basicly all this stuff is done to use the advanced features of C99 compilers that allow us to check with low effort whether a call to the error logging function is needed at all given the currently

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 4:48 AM, Stefan Fritsch s...@sfritsch.de wrote: I agree that the comments/documentation should be improved. I will write a how-to for adjusting modules to the new API. Here is a constructive suggestion (*grin*): in APR, for some of the more complex declarations (see

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread William A. Rowe Jr.
On 8/25/2010 9:56 AM, Justin Erenkrantz wrote: This is the crux of my concern - should improve performance at the very substantial cost of increasing complexity for understanding the codebase (especially without comments). That is nonsense; providing debug-level granularity of one module and

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Eric Covener
On Wed, Aug 25, 2010 at 11:31 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: On Wed, Aug 25, 2010 at 4:48 AM, Stefan Fritsch s...@sfritsch.de wrote: I agree that the comments/documentation should be improved. I will write a how-to for adjusting modules to the new API. Here is a

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Ruediger Pluem
On 08/25/2010 07:57 PM, William A. Rowe Jr. wrote: On 8/25/2010 9:56 AM, Justin Erenkrantz wrote: This is the crux of my concern - should improve performance at the very substantial cost of increasing complexity for understanding the codebase (especially without comments). That is

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 12:14 PM, Ruediger Pluem rpl...@apache.org wrote: I guess his comment was more about the macro wrappers and the C99 stuff, which saves us the function call if we would not log due to the loglevel currently set. I think this is one aspect of the changes and one were we

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Stefan Fritsch
On Wednesday 25 August 2010, Justin Erenkrantz wrote: On Wed, Aug 25, 2010 at 12:14 PM, Ruediger Pluem rpl...@apache.org wrote: I guess his comment was more about the macro wrappers and the C99 stuff, which saves us the function call if we would not log due to the loglevel currently set. I

Re: httpd trunk broken with Subversion: ap_log_rerror busted

2010-08-25 Thread Justin Erenkrantz
On Wed, Aug 25, 2010 at 2:51 PM, Stefan Fritsch s...@sfritsch.de wrote: This is a good idea. I have started it in r989377. Thanks! -- justin