On Sun, 20 Jan 2008, William A. Rowe, Jr. wrote:
Niklas - I found something telling, we were not sliding out of the
way in insert_filters where we had not initialized our ftp connection
struct. A quick test demonstrates the flaw is fixed.
Try updating to trunk and take another quick whack at
Niklas Edmundsson wrote:
On Wed, 9 Jan 2008, William A. Rowe, Jr. wrote:
Uhm. It seems that the old bug of not delivering http with mod_ftp
loaded is back... Or am I seeing a ghost? Same symptoms as before,
0-length replies...
Ghost is possibly working in trunk without doing the make clean;
Hi,
Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
their md5/asc sigs), take it for a spin, and cast your choice
There is one binding +1, no other votes. I count Guenter's +1 vote
for removing
Hi,
Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
their md5/asc sigs), take it for a spin, and cast your choice
There is one binding +1, no other votes. I count Guenter's +1 vote
for removing
Guenter Knauf wrote:
I wouldn't mind a test for httpd_conffile = , I think your patch
leaves a bit more of a chance for a subtle make install failure.
huh? what you mean?
In my case httpd_conffile wasnt empty but pointed to a non-existant file
On my systems, that would be a bug, and I
Guenter Knauf wrote:
on my box, a SuSE 10.1, the httpd-prefork.conf wasnt found, and thus the 'make
install' broke
I did then insert a test for the file (not sure if this is the correct way, but
at least I could then get past this issue, and finish the build):
You could simply override
Hi,
You could simply override make httpd_conffile=/filepath which is the
preferred way. Long ago this should have become an independent apxs
variable.
ok.
I wouldn't mind a test for httpd_conffile = , I think your patch
leaves a bit more of a chance for a subtle make install failure.
huh?
On Wed, 9 Jan 2008, William A. Rowe, Jr. wrote:
Uhm. It seems that the old bug of not delivering http with mod_ftp loaded
is back... Or am I seeing a ghost? Same symptoms as before, 0-length
replies...
Ghost is possibly working in trunk without doing the make clean; make
I mentioned?
I did
Niklas Edmundsson wrote:
I haven't looked closer at the code, but it seems to me that
something is broken. Should it even try to insert an ftp filter for
non-ftp connections?
It should not, I think. Time for me to spend cycles in 2.2, since all
my testing was on 2.0, and try some dynamic
On Tue, 8 Jan 2008, William A. Rowe, Jr. wrote:
I've heard one + and one - for removing STATUS-FTP, and I think Jorge's
point is well taken, at least for alphas and betas, so it seems it's
worth leaving STATUS-FTP in our alpha and beta packages (and I think
it's also a good point for
Niklas Edmundsson wrote:
The changes in trunk are rational but widely distributed, we now set up
a single initialization where once we had many, for an assortment of
state variables. Those sorts of changes are prone to fallout. If you
are playing with trunk and svn up, be sure to make
William A. Rowe, Jr. wrote on 2008-01-02:
Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
their md5/asc sigs), take it for a spin, and cast your choice
There is one binding +1, no other votes. I count
I actualy like that the status files are packed, why aren't they
packed for the other packages?
But I'd say do what the others do.
On Jan 5, 2008 8:14 PM, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
Guenter Knauf wrote:
See
William A. Rowe, Jr. wrote:
Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
their md5/asc sigs) from:
[X] +1 to release as 0.9.1-alpha
If the announce states this is an alpha for httpd-2.2 I don't
Guenter Knauf wrote:
See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.1/STATUS-FTP
first line of STATUS reads:
MOD_FTP 3.0 STATUS:
a little bit strange the 3.0 while the module has now 0.9.1 version
Fixed. I would be happy to reroll without STATUS if people agree that
it
Sounds good to me.
I compiled a few 3rd party modules on windows and most are not intree
compiling.
So I don't see it as a big loss if mod_ftpd doesn't compile in tree on windows.
On Jan 5, 2008 8:36 PM, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
Guenter Knauf wrote:
I got a few notes on
Guenter Knauf wrote:
I got a few notes on this though:
1) in the 2.0 tree is there a loggers subfolder in the source tree?
I'm not sure been a long time since I looked at it.
2) APACHE2_HOME points to the install dir of apache and not to the
source IIRC? so there wouldn't be a modules
Guenter Knauf wrote:
or should we do similar in ftp_commands.c depending on MODULE_MAGIC_NUMBER ?
The patch I committed for 0.9.2 tests the APR version, which the
real test of this function's availability.
Hi,
OK - here's my thought for 0.9.2 (not really a showstopper for this
alpha release);
* it's supposed to be as simple as copying over an existing httpd
source tree. For win32, that means (minimum) you touch Apache.dsw
and Makefile.win. Maybe ship those as a patch? It's 2
Hi,
Need 2 +1's beyond my own to remove STATUS-FTP from the packages.
you have my +1 now already - since we dont ship STATUS with httpd packages
either.
Guen.
Hi,
or should we do similar in ftp_commands.c depending on
MODULE_MAGIC_NUMBER ?
The patch I committed for 0.9.2 tests the APR version, which the
real test of this function's availability.
seen, that should be ok.
However I came over this already with other (external) modules, so asking me
Guenter Knauf wrote:
Furthermore if we would introduce an APR_VERSION_NUMBER like:
#define APR_VERSION_NUMBER \
(APR_MAJOR_VERSION * 100) + \
(APR_MINOR_VERSION * 1000) + \
APR_PATCH_VERSION
we could do much easier version tests
ABI and API versioning policy prohibits
Hi Bill,
mod_ftp fans;
See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.1/STATUS-FTP
first line of STATUS reads:
MOD_FTP 3.0 STATUS:
a little bit strange the 3.0 while the module has now 0.9.1 version
Guen.
On Jan 3, 2008 4:29 AM, William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
mod_ftp fans;
[ ] -1 for any release of 0.9.1
[X] +1 to release as 0.9.1-alpha
[ ] +1 to release as 0.9.1-beta
[ ] +1 to release as 0.9.1-beta, and ready to tag GA (1.0.0)
Compiles fine on vs 2005 and default
Hi,
http://httpd.apache.org/dev/dist/mod_ftp/
review, take it for a spin, and cast your choice
when compiling for 2.0.x I get an unresolved:
### mwldnlm Linker Error:
# Undefined symbol: apr_strtoff in
# ftp_commands.o
APR 0.9.x seems to lack of apr_strtoff()
should we backport
Hi Jorge,
2) I had to copy mod_log_config.h into mod_ftp's include dir since it
wast in apache include dir... did a recompile of httpd and not there!
so something is either wrong in the httpd makefile and it doesn't get
copied or mod_ftp is looking for it in the wrong place. (in the end I
Hi Guenter,
No it didn't.
I got a few notes on this though:
1) in the 2.0 tree is there a loggers subfolder in the source tree?
I'm not sure been a long time since I looked at it.
2) APACHE2_HOME points to the install dir of apache and not to the
source IIRC? so there wouldn't be a modules
Hi,
No it didn't.
I got a few notes on this though:
1) in the 2.0 tree is there a loggers subfolder in the source tree?
I'm not sure been a long time since I looked at it.
yes.
2) APACHE2_HOME points to the install dir of apache and not to the
source IIRC? so there wouldn't be a modules
On 1/3/08, Guenter Knauf [EMAIL PROTECTED] wrote:
Hi,
No it didn't.
I got a few notes on this though:
1) in the 2.0 tree is there a loggers subfolder in the source tree?
I'm not sure been a long time since I looked at it.
yes.
2) APACHE2_HOME points to the install dir of apache and
Guenter Knauf wrote:
Hi Jorge,
2) I had to copy mod_log_config.h into mod_ftp's include dir since it
wast in apache include dir... did a recompile of httpd and not there!
so something is either wrong in the httpd makefile and it doesn't get
copied or mod_ftp is looking for it in the wrong
Hi,
Guenter Knauf wrote:
its not only for mod_log_config.h , but also mod_dav.h, mod_proxy.h an
probably some more module headers are missing in the installed include
dir...
perhaps we should think of a subfolder 'module_headers' or such, and move
these headers to there, or at least create
Guenter Knauf wrote:
its not only for mod_log_config.h , but also mod_dav.h, mod_proxy.h an probably
some more module headers are missing in the installed include dir...
perhaps we should think of a subfolder 'module_headers' or such, and move these
headers to there, or at least create such a
Jorge Schrauwen wrote:
Compiles fine on vs 2005 and default config works... however...
Sweet
1) I had to copy and rename libapr-1.lib and friends to without the -1 part.
2) I had to copy mod_log_config.h into mod_ftp's include dir since it
wast in apache include dir... did a recompile of
Guenter Knauf wrote:
sweet! Let me please know how you will resolve this so that I can sync with
NetWare installdev.
Crappy solution, I iterate the explicit list of includes just
like Makefile.in spells out.
Why these don't land in include/ during build is beyond me. Our
schema for
34 matches
Mail list logo
