Agreed - thank you (everyone) for the quick rally to fix this and for
confirming we don't have other work needing to be done. I apologize for
taking almost 24 hours to ACK and get us moving again.
I've updated CHANGES and will send a VOTE shortly
--
Daniel Ruggeri
On 7/31/2020 1:28 PM, Rainer
Below said : *) mod_proxy_fcgi: Fix build on Windows
Not agree, just say what really happened.
Better : *) mod_proxy_fcgi: Fix missing macro argument
No, not a fix for build on windows., was/is building fine. APLOGNO is used on
all platforms, only a list of warnings from my Windows build was
Since here were lots of "good-to-go, let's roll" one note though: the
current CHANGES does not yet a section for 2.4.46, cause normally
APLOGNO doesn't get noted on CHANGES. In this case it might be something
like
*) mod_proxy_fcgi: Fix build on Windows.
and credits for Eric (who fixed it
Rainer Jung in gmane.comp.apache.devel (Fri, 31 Jul 2020 15:36:16
+0200):
>Since there wasn't yet any reaction to Daniel's question: Is anybody
>right now working on more warnings fixes for Windows?
AFAIK, Steffen is not working on them and nobody else from the
Apachelounge or Apachehaus
+1
> On Jul 31, 2020, at 9:41 AM, Eric Covener wrote:
>
> On Fri, Jul 31, 2020 at 9:37 AM Rainer Jung wrote:
>>
>> Since there wasn't yet any reaction to Daniel's question: Is anybody
>> right now working on more warnings fixes for Windows?
>>
>
> Not me. I don't think we should wait on
Le 31/07/2020 à 15:36, Rainer Jung a écrit :
Since there wasn't yet any reaction to Daniel's question: Is anybody
right now working on more warnings fixes for Windows?
The most prominent one (missing APLOGNo number = missing macro
argument) IMHO was already fixed by Christophe in r1880438.
On Fri, Jul 31, 2020 at 9:37 AM Rainer Jung wrote:
>
> Since there wasn't yet any reaction to Daniel's question: Is anybody
> right now working on more warnings fixes for Windows?
>
Not me. I don't think we should wait on them.
> The most prominent one (missing APLOGNo number = missing macro
On Fri, Jul 31, 2020 at 3:37 PM Rainer Jung wrote:
>
> Since there wasn't yet any reaction to Daniel's question: Is anybody
> right now working on more warnings fixes for Windows?
>
> The most prominent one (missing APLOGNo number = missing macro argument)
> IMHO was already fixed by Christophe