Re: ap_get_status_line(int)

2016-11-15 Thread Stefan Eissing
Great! > Am 15.11.2016 um 10:09 schrieb Yann Ylavic : > > On Fri, Nov 4, 2016 at 5:51 PM, Stefan Eissing > wrote: >> >> The patch looks fine to me. I do just feel a tad bit uncomfortable with the >> empty description. How about >> +

Re: ap_get_status_line(int)

2016-11-15 Thread Yann Ylavic
On Fri, Nov 4, 2016 at 5:51 PM, Stefan Eissing wrote: > > The patch looks fine to me. I do just feel a tad bit uncomfortable with the > empty description. How about > +return apr_psprintf(p, "%i No Description", status); > > There are probably tons of client

Re: ap_get_status_line(int)

2016-11-04 Thread William A Rowe Jr
Yes, you can find bugzilla entries on this topic. On Fri, Nov 4, 2016 at 11:23 AM, Yann Ylavic wrote: > On Fri, Nov 4, 2016 at 2:09 PM, William A Rowe Jr > wrote: > > > > What would a non-three-digit, >599 response look like? Perhaps we have > > a

Re: ap_get_status_line(int)

2016-11-04 Thread Stefan Eissing
> Am 04.11.2016 um 17:23 schrieb Yann Ylavic : > > On Fri, Nov 4, 2016 at 2:09 PM, William A Rowe Jr wrote: >> >> What would a non-three-digit, >599 response look like? Perhaps we have >> a good case for a NULL response or a generic 500. > > AFAICT,

Re: ap_get_status_line(int)

2016-11-04 Thread Yann Ylavic
On Fri, Nov 4, 2016 at 2:09 PM, William A Rowe Jr wrote: > > What would a non-three-digit, >599 response look like? Perhaps we have > a good case for a NULL response or a generic 500. AFAICT, an empty reason is allowed (the space after the status is required though). So

Re: ap_get_status_line(int)

2016-11-04 Thread William A Rowe Jr
On Thu, Nov 3, 2016 at 12:51 PM, Stefan Eissing < stefan.eiss...@greenbytes.de> wrote: > Like to get your opinion: > > ap_get_status_line(int) converts any status code it does not know into a > 500. This is fine for the use cases we had so far, although it can be > discussed if it is a good idea,