Re: persisting the slotmem (Was: Re: mod_proxy: maximum hostname length for workers)

2013-11-11 Thread Jim Jagielski
Now in trunk and proposed for 2.4... On Nov 9, 2013, at 10:27 AM, Daniel Ruggeri drugg...@primary.net wrote: On 11/8/2013 12:42 PM, Jim Jagielski wrote: This has me thinking... we should likely do something to better error-check the store/restore aspects of slotmem. Even some sort of quick

Re: persisting the slotmem (Was: Re: mod_proxy: maximum hostname length for workers)

2013-11-09 Thread Daniel Ruggeri
On 11/8/2013 12:42 PM, Jim Jagielski wrote: This has me thinking... we should likely do something to better error-check the store/restore aspects of slotmem. Even some sort of quick checksum would be better than what we have now. :/ Gotta mull this over a bit more. +1 to that. I couldn't

mod_proxy: maximum hostname length for workers

2013-11-08 Thread Thomas Eckert
I'm looking at an issue with this log message AH00526: Syntax error on line 6 of myconfig.conf: BalancerMember worker hostname (---dd-eee-ff.us-east-1.elb.amazonaws.com) too long with the root cause being (modules/proxy/mod_proxy.h) #define

Re: mod_proxy: maximum hostname length for workers

2013-11-08 Thread Jim Jagielski
Yeah, it's basically for performance and storage reasons (since those strings are stored in shm)... Nowadays I don't think shm is such an expensive commodity, though I can imagine some setups where the default sizes allowed by the kernel could be kinda small. I'd be +1 in adjusting all of those

Re: mod_proxy: maximum hostname length for workers

2013-11-08 Thread Thomas Eckert
I'd be +1 in adjusting all of those fields bigger, but I'm guessing that constitutes an API change for proxy... API change, why is that ? At least the shm size stuff doesn't look like having a lot of implications other then memory consumption - to make sure of this assumption is why I asked in

Re: mod_proxy: maximum hostname length for workers

2013-11-08 Thread Jim Jagielski
Mostly due to the persist feature... Right now it just does a memcpy (basically). If people don't use it then it's not an issue. On Nov 8, 2013, at 10:00 AM, Thomas Eckert thomas.r.w.eck...@gmail.com wrote: I'd be +1 in adjusting all of those fields bigger, but I'm guessing that constitutes

persisting the slotmem (Was: Re: mod_proxy: maximum hostname length for workers)

2013-11-08 Thread Jim Jagielski
This has me thinking... we should likely do something to better error-check the store/restore aspects of slotmem. Even some sort of quick checksum would be better than what we have now. :/ Gotta mull this over a bit more. On Nov 8, 2013, at 1:29 PM, Jim Jagielski j...@jagunet.com wrote: Mostly