Evgeny Kotkov writes:
>> +1 for the patch, I missed the separate 304 handling in
>> mod_brotli/deflate, thanks for catching this!
>
> Thanks, I will commit it at the earliest opportunity.
Committed and proposed for a backport to 2.4.x:
https://svn.apache.org/r1843242
https://svn.apache.org/
On Thu, Oct 4, 2018 at 7:20 PM William A Rowe Jr wrote:
>
> On Thu, Oct 4, 2018 at 12:09 PM Evgeny Kotkov
> wrote:
>>
>>
>> However, a more important question is whether there is an actual problem to
>> solve. I see that ap_http_header_filter() features a whitelist of headers
>> that are sent f
On Thu, Oct 4, 2018 at 12:09 PM Evgeny Kotkov
wrote:
>
> However, a more important question is whether there is an actual problem to
> solve. I see that ap_http_header_filter() features a whitelist of headers
> that are sent for 304 responses (http_filters.c:1428), and all headers such
> as Cont
Yann Ylavic writes:
>> I am thinking about fixing this with the attached patch and proposing it for
>> backport to 2.4.x.
>>
>> Would there be any objections to that?
>
> +1 for the patch, I missed the separate 304 handling in
> mod_brotli/deflate, thanks for catching this!
Thanks, I will commit
On Wed, Oct 3, 2018 at 5:14 PM Evgeny Kotkov
wrote:
>
> I am thinking about fixing this with the attached patch and proposing it for
> backport to 2.4.x.
>
> Would there be any objections to that?
+1 for the patch, I missed the separate 304 handling in
mod_brotli/deflate, thanks for catching this
Yann Ylavic writes:
> Log:
> http: Enforce consistently no response body with both 204 and 304 statuses.
[...]
> --- httpd/httpd/trunk/modules/filters/mod_deflate.c (original)
> +++ httpd/httpd/trunk/modules/filters/mod_deflate.c Mon Jul 30 13:08:23 2018
> @@ -642,18 +642,19 @@ static apr_statu
