Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-31 Thread Rainer Jung
Am 31.08.2018 um 20:30 schrieb Eric Covener: So the question is probably whether Eric thinks keeping the HTML output stable is more important than adding response duration info and proxy busyness info. I'm open to any decision. I didn't mean I had any issue with the HTML change. I think it's

Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-31 Thread Eric Covener
> So the question is probably whether Eric thinks keeping the HTML output > stable is more important than adding response duration info and proxy > busyness info. I'm open to any decision. I didn't mean I had any issue with the HTML change. I think it's OK too.

Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-31 Thread Rainer Jung
Am 29.08.2018 um 05:45 schrieb Rainer Jung: Am 28.08.2018 um 15:54 schrieb Yann Ylavic: On Tue, Aug 7, 2018 at 4:19 PM wrote: Log: Propose a few monitoring improvements. Those changes look fine (and great) to me, I wanted to +1 but I'm wondering if they really belong in 2.4.x since the

Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-28 Thread Rainer Jung
Am 28.08.2018 um 15:54 schrieb Yann Ylavic: On Tue, Aug 7, 2018 at 4:19 PM wrote: Log: Propose a few monitoring improvements. Those changes look fine (and great) to me, I wanted to +1 but I'm wondering if they really belong in 2.4.x since the output of mod_status is changed in a way that

Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-28 Thread Yann Ylavic
Hi Rainer, On Tue, Aug 28, 2018 at 4:30 PM Rainer Jung wrote: > > Hi Yann, I will try to comment inline per patch. Yes, that's always a > difficult decision. I think for the "?auto" part it should be easy: it > uses a line based key-value format, so adding new keys should be fine > for nearly

Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-28 Thread Jim Jagielski
+1 > On Aug 28, 2018, at 10:30 AM, Eric Covener wrote: > > On Tue, Aug 28, 2018 at 9:54 AM Yann Ylavic wrote: >> >> On Tue, Aug 7, 2018 at 4:19 PM wrote: >>> >>> Author: rjung >>> Date: Tue Aug 7 14:19:31 2018 >>> New Revision: 1837599 >>> >>> URL:

Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-28 Thread Rainer Jung
Hi Yann, I will try to comment inline per patch. Yes, that's always a difficult decision. I think for the "?auto" part it should be easy: it uses a line based key-value format, so adding new keys should be fine for nearly any parser. For the HTML based output the decision is more difficult.

Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-28 Thread Eric Covener
On Tue, Aug 28, 2018 at 9:54 AM Yann Ylavic wrote: > > On Tue, Aug 7, 2018 at 4:19 PM wrote: > > > > Author: rjung > > Date: Tue Aug 7 14:19:31 2018 > > New Revision: 1837599 > > > > URL: http://svn.apache.org/viewvc?rev=1837599=rev > > Log: > > Propose a few monitoring improvements. > > > >

Re: svn commit: r1837599 - /httpd/httpd/branches/2.4.x/STATUS

2018-08-28 Thread Yann Ylavic
On Tue, Aug 7, 2018 at 4:19 PM wrote: > > Author: rjung > Date: Tue Aug 7 14:19:31 2018 > New Revision: 1837599 > > URL: http://svn.apache.org/viewvc?rev=1837599=rev > Log: > Propose a few monitoring improvements. > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified: