Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-31 Thread Brian Akins
Jim Jagielski wrote: I thought that this was about abstracting out scoreboard so that other modules could have scoreboard-like access without mucking around with the real scoreboard... +1. The proxy could just use this mechanism. We need to separate the two issues. I am all in favor of a

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-30 Thread Jean-frederic Clere
Ruediger Pluem wrote: On 07/28/2006 06:34 PM, [EMAIL PROTECTED] wrote: Added: httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c URL:

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-29 Thread Ruediger Pluem
On 07/29/2006 09:59 AM, Ruediger Pluem wrote: But it is not used in this implementation. Instead you use worker-id here. Should it be used by other implementations where worker-id cannot / shouldn't be used? Never mind. Obsoleted by r426732. Regards Rüdiger

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-29 Thread Ruediger Pluem
On 07/28/2006 06:34 PM, [EMAIL PROTECTED] wrote: Added: httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c URL: http://svn.apache.org/viewvc/httpd/httpd/branches/httpd-proxy-scoreboard/modules/proxy/health_checker_util.c?rev=426604view=auto

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread jean-frederic clere
Hi, I have committed the code to get comments on some points: - Does it make sense to include from support objects from modules/proxy? - Does the mod_proxy_health_checker is the right way to go? - I mean: one part is storing the worker information to use it in an external process and

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jean-frederic Clere
Hi, I have committed the code to get comments on some points: - Does it make sense to include from support objects from modules/proxy? - Does the mod_proxy_health_checker is the right to do? - I mean: one part is storing the worker information to use it in an external process and the other is

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Ruediger Pluem
On 28.07.2006 18:34, [EMAIL PROTECTED] wrote: Author: jfclere Date: Fri Jul 28 09:33:58 2006 New Revision: 426604 URL: http://svn.apache.org/viewvc?rev=426604view=rev Log: First try to put togother an external health checker for mod_proxy. Modified:

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jim Jagielski
On Jul 28, 2006, at 12:34 PM, [EMAIL PROTECTED] wrote: Author: jfclere Date: Fri Jul 28 09:33:58 2006 New Revision: 426604 URL: http://svn.apache.org/viewvc?rev=426604view=rev Log: First try to put togother an external health checker for mod_proxy. Just coming back from OSCON, I haven't

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jim Jagielski
On Jul 28, 2006, at 1:54 PM, jean-frederic clere wrote: Hi, I have committed the code to get comments on some points: - Does it make sense to include from support objects from modules/ proxy? - Does the mod_proxy_health_checker is the right way to go? - I mean: one part is storing the

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Davi Arnaut
Em 28/07/2006, às 13:34, [EMAIL PROTECTED] escreveu: Author: jfclere Date: Fri Jul 28 09:33:58 2006 New Revision: 426604 ... + +static const slotmem_storage_method *checkstorage = NULL; +static ap_slotmem_t *myscore=NULL; Indentation consistency ? myscore=NULL + +if (!port) { +

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jean-frederic Clere
Jim Jagielski wrote: On Jul 28, 2006, at 1:54 PM, jean-frederic clere wrote: Hi, I have committed the code to get comments on some points: - Does it make sense to include from support objects from modules/ proxy? - Does the mod_proxy_health_checker is the right way to go? - I mean: one

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jean-frederic Clere
Jim Jagielski wrote: On Jul 28, 2006, at 12:34 PM, [EMAIL PROTECTED] wrote: Author: jfclere Date: Fri Jul 28 09:33:58 2006 New Revision: 426604 URL: http://svn.apache.org/viewvc?rev=426604view=rev Log: First try to put togother an external health checker for mod_proxy. Just coming back

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jim Jagielski
On Jul 28, 2006, at 4:03 PM, Jean-frederic Clere wrote: Jim Jagielski wrote: On Jul 28, 2006, at 1:54 PM, jean-frederic clere wrote: Hi, I have committed the code to get comments on some points: - Does it make sense to include from support objects from modules/ proxy? - Does the

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jim Jagielski
Many compile warnings when compiling with maint-mode: mod_proxy.c: In function 'add_pass': mod_proxy.c:1176: warning: implicit declaration of function 'proxy_checkstorage_add_entry' mod_proxy.c: In function 'proxy_post_config': mod_proxy.c:1870: warning: implicit declaration of function

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jean-frederic Clere
Jim Jagielski wrote: Many compile warnings when compiling with maint-mode: Fixed. Thanks, Cheers Jean-Frederic mod_proxy.c: In function 'add_pass': mod_proxy.c:1176: warning: implicit declaration of function 'proxy_checkstorage_add_entry' mod_proxy.c: In function 'proxy_post_config':

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jean-frederic Clere
Davi Arnaut wrote: Em 28/07/2006, às 13:34, [EMAIL PROTECTED] escreveu: Author: jfclere Date: Fri Jul 28 09:33:58 2006 New Revision: 426604 ... + +static const slotmem_storage_method *checkstorage = NULL; +static ap_slotmem_t *myscore=NULL; Indentation consistency ? myscore=NULL

Re: svn commit: r426604 - in /httpd/httpd/branches/httpd-proxy-scoreboard: modules/proxy/ support/

2006-07-28 Thread Jean-frederic Clere
Ruediger Pluem wrote: On 28.07.2006 18:34, [EMAIL PROTECTED] wrote: Author: jfclere Date: Fri Jul 28 09:33:58 2006 New Revision: 426604 URL: http://svn.apache.org/viewvc?rev=426604view=rev Log: First try to put togother an external health checker for mod_proxy. Modified: