Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4

2016-06-27 Thread Ruediger Pluem
On 06/27/2016 04:35 PM, William A Rowe Jr wrote: > On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem > wrote: > > > On 06/27/2016 03:45 PM, wr...@apache.org wrote: > > Author: wrowe > > Date: Mon Jun 27

Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4

2016-06-27 Thread William A Rowe Jr
On Jun 27, 2016 9:44 AM, "Ruediger Pluem" wrote: > > > > On 06/27/2016 04:35 PM, William A Rowe Jr wrote: > > On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem > wrote: > > > > > > On 06/27/2016 03:45 PM, wr...@apache.org

Re: T 2.4.23 tomorrow (Thurs) ??

2016-06-27 Thread Jens Schleusener
On Mon, 27 Jun 2016, William A Rowe Jr wrote: On Mon, Jun 27, 2016 at 6:00 AM, Jens Schleusener wrote: On Fri, 24 Jun 2016, William A Rowe Jr wrote: On Thu, Jun 23, 2016 at 10:38 AM, Jens Schleusener

Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4

2016-06-27 Thread William A Rowe Jr
On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem wrote: > > On 06/27/2016 03:45 PM, wr...@apache.org wrote: > > Author: wrowe > > Date: Mon Jun 27 13:45:02 2016 > > New Revision: 1750335 > > > > URL: http://svn.apache.org/viewvc?rev=1750335=rev > > Log: > > Ensure not-selected

Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4

2016-06-27 Thread Ruediger Pluem
On 06/27/2016 03:45 PM, wr...@apache.org wrote: > Author: wrowe > Date: Mon Jun 27 13:45:02 2016 > New Revision: 1750335 > > URL: http://svn.apache.org/viewvc?rev=1750335=rev > Log: > Ensure not-selected means 'no', once an APACHE_MODULE enable_foo is processed > > Modified: >

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 3:17 PM, Jim Jagielski wrote: > Doesn't this depend on: > > trunk patch: http://svn.apache.org/r1656259 > http://svn.apache.org/r1656359 (CHANGES entry) > > which, in STATUS, is tagged as still being worked? I don't think so,

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Tue, Jun 28, 2016 at 12:11 AM, Yann Ylavic wrote: > On Mon, Jun 27, 2016 at 11:26 PM, Yann Ylavic wrote: >> On Mon, Jun 27, 2016 at 10:48 AM, Stefan Eissing >> wrote: >>> Am 27.06.2016 um 10:41 schrieb Yann Ylavic

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 6:00 PM, Yann Ylavic wrote: > > PR 57832 does not depend on this (race) condition, hence this change > (r1750301, or actually its successor since I'll revert it for a less > intrusive version) could be applied to 2.4.x without r1656259. New commit is

Re: svn commit: r1750392 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number include/ap_mmn.h modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c modules/proxy/mod_proxy_fcgi.c modu

2016-06-27 Thread Jim Jagielski
> On Jun 27, 2016, at 1:26 PM, yla...@apache.org wrote: > > +apr_bucket_brigade *tmp_bb; > } proxy_conn_rec; > I am missing the reason why this brigade needs to be a field in this struct. Is it simply to prevent us having to create it during each call of ap_proxy_check_backend()?

Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4

2016-06-27 Thread William A Rowe Jr
On Mon, Jun 27, 2016 at 10:14 AM, William A Rowe Jr wrote: > > On Jun 27, 2016 9:44 AM, "Ruediger Pluem" wrote: > > > > > > > > On 06/27/2016 04:35 PM, William A Rowe Jr wrote: > > > On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 10:48 AM, Stefan Eissing wrote: > >> Am 27.06.2016 um 10:41 schrieb Yann Ylavic : >> >> On Mon, Jun 27, 2016 at 10:23 AM, Stefan Eissing wrote: >>> This looks nice for HTTP/1.1, but what about other

Re: svn commit: r1750392 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number include/ap_mmn.h modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c modules/proxy/mod_proxy_fcgi.c modu

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 10:25 PM, Yann Ylavic wrote: > I thought we could later follow up on this change and optimize these > by using the new tmp_bb field (cleanup is faster than > create/destroy)... Something like the attached patch. Index: modules/proxy/mod_proxy_http.c

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 11:26 PM, Yann Ylavic wrote: > On Mon, Jun 27, 2016 at 10:48 AM, Stefan Eissing > wrote: >> >>> Am 27.06.2016 um 10:41 schrieb Yann Ylavic : >>> >>> On Mon, Jun 27, 2016 at 10:23 AM, Stefan Eissing

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Jim Jagielski
Doesn't this depend on: trunk patch: http://svn.apache.org/r1656259 http://svn.apache.org/r1656359 (CHANGES entry) which, in STATUS, is tagged as still being worked? > On Jun 27, 2016, at 4:23 AM, Stefan Eissing wrote: > > This looks nice for

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Stefan Eissing
This looks nice for HTTP/1.1, but what about other protocols? Do I read it correctly that any pending data downstream will reopen the connection? > Am 27.06.2016 um 10:00 schrieb yla...@apache.org: > > Author: ylavic > Date: Mon Jun 27 08:00:30 2016 > New Revision: 1750301 > > URL:

Re: T 2.4.23 tomorrow (Thurs) ??

2016-06-27 Thread William A Rowe Jr
On Mon, Jun 27, 2016 at 6:00 AM, Jens Schleusener < jens.schleuse...@t-online.de> wrote: > On Fri, 24 Jun 2016, William A Rowe Jr wrote: > > On Thu, Jun 23, 2016 at 10:38 AM, Jens Schleusener < >> jens.schleuse...@t-online.de> wrote: >> >> 1) Just a pure ./configure (probably equivalent to using

RE: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Plüm , Rüdiger , Vodafone Group
> -Original Message- > From: Stefan Eissing [mailto:ste...@eissing.org] > Sent: Montag, 27. Juni 2016 10:24 > To: dev@httpd.apache.org > Subject: Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: > mod_proxy.h proxy_util.c > > This looks nice for HTTP/1.1, but what about

Re: T 2.4.23 tomorrow (Thurs) ??

2016-06-27 Thread Jens Schleusener
On Fri, 24 Jun 2016, William A Rowe Jr wrote: On Thu, Jun 23, 2016 at 10:38 AM, Jens Schleusener wrote: ... good news. So now nearly superfluous info but just for completeness: Your first patch for modules/proxy/config.m4 sent at "Thu, 23 Jun 2016 07:32:02

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Yann Ylavic
On Mon, Jun 27, 2016 at 10:23 AM, Stefan Eissing wrote: > This looks nice for HTTP/1.1, but what about other protocols? Do I read it > correctly that any pending data downstream will reopen the connection? Hmm, I did not think about mod_proxy_h2, but correct (I'd rather say

Re: svn commit: r1750301 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.h proxy_util.c

2016-06-27 Thread Stefan Eissing
> Am 27.06.2016 um 10:41 schrieb Yann Ylavic : > > On Mon, Jun 27, 2016 at 10:23 AM, Stefan Eissing wrote: >> This looks nice for HTTP/1.1, but what about other protocols? Do I read it >> correctly that any pending data downstream will reopen the