start of possible replacement for mod-include

2002-03-28 Thread Ian Holsman
I started working on this a while ago, and seeing how we've had a spate of issues with mod-include recently I thought I'd bring it up. The code implements a alternative parser (http://webperf.org/a2/include/) is 90% complete. it passes most of the tests but I haven't had any time to follow it th

Re: cvs commit: httpd-2.0/modules/filters mod_include.c

2002-03-28 Thread Brian Pane
Cliff Woolley wrote: >On 29 Mar 2002 [EMAIL PROTECTED] wrote: > >> -while (*path && *(path+1) != '/') >> +while (*path && (*path != '/')) { >> +++path; >> +} >> +if (*path == '/') { >> ++path; >> +} >> > >Alternatively: > >wh

Re: cvs commit: httpd-2.0/modules/filters mod_include.c

2002-03-28 Thread Cliff Woolley
On 29 Mar 2002 [EMAIL PROTECTED] wrote: > -while (*path && *(path+1) != '/') > +while (*path && (*path != '/')) { > +++path; > +} > +if (*path == '/') { >++path; > +} Alternatively: while (*path && *(path++) != '/')

Re: cvs commit: httpd-2.0/modules/filters mod_include.c

2002-03-28 Thread Brian Pane
[EMAIL PROTECTED] wrote: >bnicholes02/03/28 16:39:56 > > Modified:modules/filters mod_include.c > Log: > Stop the while loop from incrementing twice per iteration before checking for > the NULL terminator. This was causing the while loop to walk off the end of any > string with an o

Re: [PATCH] Re: mod_include bug(s)?

2002-03-28 Thread Brian Pane
Paul J. Reder wrote: > That patch seems to solve at least one of the problems that I am seeing, > but I have at least one other problem and a core dump inside > send_parsed_content. I'm currently stepping though, trying to find the > source of the core dump. Thanks, I'll commit this patch for

Re: [PATCH] Re: mod_include bug(s)?

2002-03-28 Thread Brad Nicholes
I don't know if this has anything to do with the problems that you are seeing but there is a while loop in is_only_below that is running off the end of the string. while (*path && *(path++) != '/') ++path; The while loop increments "path" twice in one iteration which means

Re: [PATCH] Re: mod_include bug(s)?

2002-03-28 Thread Cliff Woolley
On Thu, 28 Mar 2002, Paul J. Reder wrote: > That patch seems to solve at least one of the problems that I am seeing, > but I have at least one other problem and a core dump inside > send_parsed_content. I'm currently stepping though, trying to find the > source of the core dump. > I'll let you kn

Re: [PATCH] Re: mod_include bug(s)?

2002-03-28 Thread Paul J. Reder
That patch seems to solve at least one of the problems that I am seeing, but I have at least one other problem and a core dump inside send_parsed_content. I'm currently stepping though, trying to find the source of the core dump. I'll let you know what I find. Paul J. Reder Brian Pane wrote: >

[PATCH] elminate warning in http_config.h

2002-03-28 Thread sterling
when building with -Werror -Wall it seems http_config.h bjorks my module build. This patch should fix it - any objections? sterling Index: include/http_config.h === RCS file: /home/cvspublic/httpd-2.0/include/http_config.h,v retr

RE: requesting guidance on converting a mod to 2.0

2002-03-28 Thread Ryan Bloom
I am in the process of converting an apache module that I have working with Apache 1.3 to work with 2.0. This crufty bit of code handles the dynamic content portion of Specweb99. I must admit my knowledge of Apache modules is less than it should be as my first module work was convertin

requesting guidance on converting a mod to 2.0

2002-03-28 Thread David Hill
Hi all,   I am in the process of converting an apache module that I have working with Apache 1.3 to work with 2.0. This crufty bit of code handles the dynamic content portion of Specweb99. I must admit my knowledge of Apache modules is less than it should be as my first module work was conver

connect to listener warning message

2002-03-28 Thread David Hill
Hi all,     When I run 2.0.32 on Compaq Tru64 and give it a bit of a load (ok, I whack it good :-), I get warnings similar to the following looping into the error log file. I am getting one per second, even well after the load is removed.I do not get any of these until after the load has bee

FreeBSD sendfile

2002-03-28 Thread Igor Sysoev
Hi, apr_sendfile() for FreeBSD has workaround for "nbytes!=0 bug" but this bug had fixed in CURRENT: http://www.FreeBSD.org/cgi/cvsweb.cgi/src/sys/kern/uipc_syscalls.c#rev1.103 So I think code should be following: #ifdef __FreeBSD_version < 500029 for (i = 0; i < hdtr->numheaders; i++) {

Re: [PATCH] Removal of old, old SCOREBOARD_FILE fluff

2002-03-28 Thread Jim Jagielski
William A. Rowe, Jr. wrote: > > Nothing that I know of says they cannot define an shmem backing file and > map that file for monitoring the server. > > There simply won't be a 'file'-based scoreboard API, right? > Yes, this does *not* affect the named stuff at all. It's still there, as it sho

Re: 1.3.24 mod_proxy patch: multiple set-cookies fix

2002-03-28 Thread Jim Jagielski
There is actually one fix in 1.3.24 and another (better) fix in 1.3.25-dev. :) Michael Best wrote: > > Well that patch is against 1.3.24, so I'm not sure how it is fixed in > 1.3.24. > > I'm currently experiencing something similar with Zope 2.4.3 and ProxyPass. > > Our user authentication (in

[PATCH] HTTP proxy, ab, and Host: as a hop-by-hop header?

2002-03-28 Thread Taisuke Yamada
Hi. I do believe it's been discussed at least once, but I have a question on Host: header generated by ab(1). The problem I'm encountering is that ab(1) generates Host: header pointing to proxy server instead of real destination host. Due to this behavior, proxy server (not mod_proxy, BTW) is f

Re: 1.3.24 mod_proxy patch: multiple set-cookies fix

2002-03-28 Thread Graham Leggett
Michael Best wrote: > I'm pretty sure it's not the syntax and it's somehow related to this > multiple cookie issue, as when testing I get one cookie but not the other. > > I have tested 1.3.23 and 1.3.24. > > I am going to go test 1.3 CVS now. The original fix was based on the idea that all du