Re: [PATCH] allow implicit ServerRoot via apxs

2003-11-04 Thread Mike Cramer
Geoffrey Young wrote: +if ($base = $self-{inherit_config}-{ServerRoot}) { +debug using inherited ServerRoot $base to resolve $file; +} +elsif ($base = $self-apxs('PREFIX')) { +warning using apxs-derived ServerRoot $base to resolve $file; +} +

Re: [PATCH] allow implicit ServerRoot via apxs

2003-11-04 Thread Geoffrey Young
+elsif (file_name_is_absolute($file)) { Shouldn't the file_name_is_absolute case be first? indeed - I only noticed that case after I had coded the others. clearly not enough coffee yet :) --Geoff

Redo of: Diff for flood_net_ssl.c [Ref A1]

2003-11-04 Thread Norman Tuttle
See below for explanation of change; attached diff now correct. -Norman Tuttle, OpenDemand Systems Developer [EMAIL PROTECTED] On Mon, 13 Oct 2003, Norman Tuttle wrote: To Apache Flood development team: Other than some small touch-ups, these changes to flood_net_ssl.c involve 1) taking

Re: [PATCH] allow implicit ServerRoot via apxs

2003-11-04 Thread Stas Bekman
Geoffrey Young wrote: [...] +elsif ($base = $self-apxs('PREFIX')) { +warning using apxs-derived ServerRoot $base to resolve $file; May be better to say it all? warning since ServerRoot is not defined, . using apxs-derived PREFIX $base to resolve $file;

Re: [PATCH] allow implicit ServerRoot via apxs

2003-11-04 Thread Geoffrey Young
Stas Bekman wrote: Geoffrey Young wrote: [...] +elsif ($base = $self-apxs('PREFIX')) { +warning using apxs-derived ServerRoot $base to resolve $file; May be better to say it all? warning since ServerRoot is not defined, . using apxs-derived PREFIX

Re: [PATCH] allow implicit ServerRoot via apxs

2003-11-04 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: Geoffrey Young wrote: [...] +elsif ($base = $self-apxs('PREFIX')) { +warning using apxs-derived ServerRoot $base to resolve $file; May be better to say it all? warning since ServerRoot is not defined, . using

Re: [PATCH] allow implicit ServerRoot via apxs

2003-11-04 Thread Geoffrey Young
and it's an absolute_path. no sense checking that - rel2abs returns an absolute path by definition. what if it fails? the call to rel2abs? since it does no check of the underlying filesystem I doubt that's realistic. I'm definitely a fan of error checking where it makes sense, but I also

Re: [PATCH] allow implicit ServerRoot via apxs

2003-11-04 Thread Geoffrey Young
the call to rel2abs? since it does no check of the underlying filesystem I doubt that's realistic. you are right, I've confused with the opposite operation abs2rel, which may fail if the base doesn't fit. In any case it's a good idea to check that rel2abs gives you a path that exists, no?

should input filter return the exact amount of bytes asked for?

2003-11-04 Thread Stas Bekman
I'm trying to get rid of ap_get_client_block(), but I don't understand a few things. ap_get_client_block() asks for readbytes from the upstream filter. What happens if the filter returns less bytes (while there is still more data coming?) What happens if the filter returns more bytes than

RE: mod_ldap SEGV while caching on FreeBSD 4.8-STABLE

2003-11-04 Thread CHOU,TAIR-SHIAN (HP-Cupertino,ex1)
Hi Matthieu, We are also seeing the same problem on HP-UX running 2.0.47 with mod_ldap enabled. We have done some analysis and we think we might have found the problem. The cache memory is shared by all processes(one process creates it and other processes just attaches to it). After a process

Re: piped log files

2003-11-04 Thread Jeff Trawick
Bastiaan van der Put wrote: CustomLog |/usr/local/apache2/bin/logresolve /home/accounts/x/x/logs/access_log combined unless somebody speaks up soon, I'll commit the patch to Apache 2.1-dev Works now, When stopping apache i still get piped log program '/usr/local/apache2/bin/logresolve

Re: mod_ldap SEGV while caching on FreeBSD 4.8-STABLE

2003-11-04 Thread Matthieu Estrade
Hi Chou, I dunno if you looked into the patch i pointed in my last mail, but this is what the patch is doing: SHM is now initialised in post_config hook, so apr_shm_create and apr_rmm_init are just called one time when apache is startup. Then, all the lock are now using the module structure to

Re: Submitting module

2003-11-04 Thread Ben Laurie
Jeff Trawick wrote: Piras Velandai Thiyagarajan wrote: To better serve the Apache user community for easy integration, it would be nice if during configure compilation option, --with-mod-sun-plugin, that way just be simple effect of compilation, the customers get what they want. I'd

can someone confirm or deny my interpretation of global mutices?

2003-11-04 Thread Jonathan Gold
when i first started using 2.0.47, i was concerned that mod_rewrite no longer wrote a visible lockfile when using RewriteLock with an external map program. i realize there was some type of bug related to this in 2.0.39 ( 9534 -- http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9534 ), which is

Re: htdocs in 1.3 CVS tree?

2003-11-04 Thread Geoffrey Young
hi again I'm still seeing this error on my local system. since those who tried were not able to reproduce, I decided to try on cvs.apache.org hostname minotaur.apache.org mkdir src cd src cvs -z9 -d:pserver:[EMAIL PROTECTED]:/home/cvspublic checkout apache-1.3 cvs server: Updating

Re: can someone confirm or deny my interpretation of global mutices?

2003-11-04 Thread Jeff Trawick
Jonathan Gold wrote: i'm not a great C programmer, but i think i understand, from the comments on the method which creates the mutex, that an actual file is used only if the operating system needs it to implement the locking. correct your Linux build is probably defaulting to SysV semaphores*,

RE: mod_ldap SEGV while caching on FreeBSD 4.8-STABLE

2003-11-04 Thread CHOU,TAIR-SHIAN (HP-Cupertino,ex1)
Hi Matthieu, I was speaking about the actual code we saw in 2.0.47. I will try your patch and see what happens. Thanks, Chou -Original Message- From: Matthieu Estrade [mailto:[EMAIL PROTECTED] Sent: Tuesday, November 04, 2003 4:29 AM To: [EMAIL PROTECTED] Subject: Re: mod_ldap

Re: can someone confirm or deny my interpretation of global mutices?

2003-11-04 Thread Jonathan Gold
indeed it does use APR_USE_SYSVSEM_SERIALIZE. thanks for looking. jon On Tue, 4 Nov 2003, Jeff Trawick wrote: Jonathan Gold wrote: i'm not a great C programmer, but i think i understand, from the comments on the method which creates the mutex, that an actual file is used only if the