Stas Bekman wrote:
Geoffrey Young wrote: [...]
+ elsif ($base = $self->apxs('PREFIX')) {
+ warning "using apxs-derived ServerRoot $base to resolve $file";
May be better to say it all?
warning "since ServerRoot is not defined, " . "using apxs-derived PREFIX $base to resolve $file";
I suppose the wording could be reworked.
While you are at it, I'd also add a check that $base exists and it's a directory before you call rel2abs, because it can be a broken value.
I think it's safe to assume if you pass in $base you know what you're doing (especially since nobody appears to be passing in $base :)
as for checking the resulting ServerRoot, yeah, I thought about that. I suppose it can't hurt.
And also check that rel2abs gives us a an existing filename
this function is starting to explode a bit...
and it's an absolute_path.
no sense checking that - rel2abs returns an absolute path by definition.
or die otherwise.
I don't think we should die here - it's not fatal to the build process if 'perl Makefile.PL' can't resolve testing files.
--Geoff
