Re: Broken URI-unescaping in mod_proxy

2007-09-09 Thread Ruediger Pluem
On 09/09/2007 02:21 AM, Nick Kew wrote: PR 41798 and many related ones (eg 39746, 38980 - both of which I've closed today) show a history of incorrect URL-unescaping in mod_proxy. For PR41798, the attached patch looks like a fix: it just uses r-unparsed_uri (escaped) instead of r-uri

Re: svn commit: r573831 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml modules/mappers/mod_rewrite.c

2007-09-09 Thread Ruediger Pluem
On 09/08/2007 02:46 PM, wrote: Author: niq Date: Sat Sep 8 05:46:10 2007 New Revision: 573831 URL: http://svn.apache.org/viewvc?rev=573831view=rev Log: Add option to escape backreferences in RewriteRule. PR 34602 and PR 39746 Patch by Guenther Gsenger Modified:

Re: svn commit: r573903 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2007-09-09 Thread Ruediger Pluem
On 09/08/2007 10:29 PM, [EMAIL PROTECTED] wrote: Author: niq Date: Sat Sep 8 13:29:14 2007 New Revision: 573903 URL: http://svn.apache.org/viewvc?rev=573903view=rev Log: mod_proxy: Don't lose bytes when a response line arrives in small chunks. PR 40894 Modified:

Corrupted archive file?

2007-09-09 Thread Dan Schwartz
The file http://archive.apache.org/dist/tomcat/tomcat-5/v5.5.17/bin/apache-tomcat-5.5.17.exe appears to be corrupted. In fact it seems to be about half the size it should be, as compared with other distributions of Tomcat. Could you please check this and let me know? I need this version

Re: Corrupted archive file?

2007-09-09 Thread William A. Rowe, Jr.
I'm sure you ment to send this to the tomcat devs. Dan Schwartz wrote: The file http://archive.apache.org/dist/tomcat/tomcat-5/v5.5.17/bin/apache-tomcat-5.5.17.exe appears to be corrupted. In fact it seems to be about half the size it should be, as compared with other distributions

Re: svn commit: r573831 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml modules/mappers/mod_rewrite.c

2007-09-09 Thread Nick Kew
On Sun, 09 Sep 2007 11:41:53 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: On 09/08/2007 02:46 PM, wrote: Author: niq Date: Sat Sep 8 05:46:10 2007 New Revision: 573831 URL: http://svn.apache.org/viewvc?rev=573831view=rev Log: Add option to escape backreferences in

Re: svn commit: r573903 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2007-09-09 Thread Nick Kew
On Sun, 09 Sep 2007 11:51:37 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: On 09/08/2007 10:29 PM, [EMAIL PROTECTED] wrote: Author: niq Date: Sat Sep 8 13:29:14 2007 New Revision: 573903 URL: http://svn.apache.org/viewvc?rev=573903view=rev Log: mod_proxy: Don't lose bytes

Re: Broken URI-unescaping in mod_proxy

2007-09-09 Thread Nick Kew
On Sun, 09 Sep 2007 11:25:26 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: On 09/09/2007 02:21 AM, Nick Kew wrote: PR 41798 and many related ones (eg 39746, 38980 - both of which I've closed today) show a history of incorrect URL-unescaping in mod_proxy. For PR41798, the attached

Re: svn commit: r573264 - /httpd/httpd/trunk/include/scoreboard.h

2007-09-09 Thread Jim Jagielski
Of course, the *real* fix is to make the scoreboard and its entire allocation something which is more callable/usable by modules, which is something we talked about several times and is like a major aspect of 3.0. But the current discussion tries to somehow say that lb_score shouldn't know that

Re: svn commit: r573264 - /httpd/httpd/trunk/include/scoreboard.h

2007-09-09 Thread Jim Jagielski
On Sep 7, 2007, at 6:20 PM, Ruediger Pluem wrote: On 09/07/2007 03:03 PM, Jim Jagielski wrote: On Sep 7, 2007, at 6:29 AM, jean-frederic clere wrote: I think I have patched it. Could you try it? Ahh... this is much nicer that my idea of breaking out the data struct defs from the rest

Re: SSL_VERSION_LIBRARY

2007-09-09 Thread Ruediger Pluem
On 09/08/2007 08:40 PM, Zvi Har'El wrote: Hi, I installed the new httpd 2.2.6 on several machines. One of them runs RedHat Enterprise Linux. Another is Solaris 2.9. When looking at the SSL environment variables in a simple CGI, I notticed that on the Linux machine, SSL_VERSION_LIBRARY is

Re: svn commit: r573903 - in /httpd/httpd/trunk: CHANGES modules/proxy/proxy_util.c

2007-09-09 Thread Ruediger Pluem
On 09/09/2007 04:16 PM, Nick Kew wrote: On Sun, 09 Sep 2007 11:51:37 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: I am slightly confused here: IMHO apr_cpystrn does exactly what you do here (it terminates pos with \0 and sets the pointer of pos to the terminating \0) But it avoids reading

Re: svn commit: r573264 - /httpd/httpd/trunk/include/scoreboard.h

2007-09-09 Thread Ruediger Pluem
On 09/09/2007 07:24 PM, Jim Jagielski wrote: On Sep 7, 2007, at 6:20 PM, Ruediger Pluem wrote: On 09/07/2007 03:03 PM, Jim Jagielski wrote: On Sep 7, 2007, at 6:29 AM, jean-frederic clere wrote: I think I have patched it. Could you try it? Ahh... this is much nicer that my idea

Re: mod_proxy: Is smax=0 allowed ?

2007-09-09 Thread Phil Endecott
Phil Endecott wrote: Phil Endecott wrote: I'm going to have another look at the source, and see whether I can change the sentinel value for smax not specified from 0 to -1, so that 0 can really mean zero. I have tried the following: Index: proxy_util.c

Re: Broken URI-unescaping in mod_proxy

2007-09-09 Thread Ruediger Pluem
On 09/09/2007 04:30 PM, Nick Kew wrote: On Sun, 09 Sep 2007 11:25:26 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: On 09/09/2007 02:21 AM, Nick Kew wrote: PR 41798 and many related ones (eg 39746, 38980 - both of which I've closed today) show a history of incorrect URL-unescaping in

Re: SSL_VERSION_LIBRARY

2007-09-09 Thread Zvi Har'El
Yes. This fixed the problem: Now I get SSL_VERSION_LIBRARY=OpenSSL/0.9.8e On 09/09/07 22:12, Ruediger Pluem wrote: On 09/08/2007 08:40 PM, Zvi Har'El wrote: Hi, I installed the new httpd 2.2.6 on several machines. One of them runs RedHat Enterprise Linux. Another is Solaris 2.9. When

Re: svn commit: r573264 - /httpd/httpd/trunk/include/scoreboard.h

2007-09-09 Thread Jim Jagielski
Ruediger Pluem wrote: Because it was int ap_proxy_lb_workers(void); and not PROXY_DECLARE(int)ap_proxy_lb_workers(void); Yep. Ideally, of course, a design like mod_ssl with the ssl_private.h usage is nice, because there you can expose functions that need to be shared amoung files

Re: Broken URI-unescaping in mod_proxy

2007-09-09 Thread Nick Kew
On Sun, 09 Sep 2007 22:00:25 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: [chop] Thanks for the analysis. It's the insights I was looking for together with some points I'd argue. But I need to give it more think-time before proposing a revised patch. -- Nick Kew Application Development

Re: SSL_VERSION_LIBRARY

2007-09-09 Thread William A. Rowe, Jr.
Zvi Har'El wrote: This looks similar to PR 43334 (https://issues.apache.org/bugzilla/show_bug.cgi?id=43334). Could you please test my diagnostic patch from there? Yup - that patch would solve it since we don't reinit static char*library to null on every unload/reload cycle. The fix is