Re: Fwd: FYI: change to travis-ci emailer could cause moderation headaches

2022-01-27 Thread Christophe JAILLET
Le 26/01/2022 à 14:58, Eric Covener a écrit : I noticed I stopped getting "Travis CI" emails for httpd around 10/21. But I see people still discussing CI failures, so I am a little confused. Maybe they are only seeing it in the context of PRs. For me, manual check of https://app.travis-ci.co

Re: mpm event assertion failures

2022-01-27 Thread Ruediger Pluem
On 1/27/22 9:57 AM, Ruediger Pluem wrote: > > > On 1/26/22 6:34 PM, Yann Ylavic wrote: >> On Wed, Jan 26, 2022 at 5:07 PM Graham Leggett wrote: >>> >>> We need to clarify expectations at this point. >>> >>> The trunk of httpd has a policy called “commit then review” (CTR), meaning >>> that c

Re: mpm event assertion failures

2022-01-27 Thread Stefan Eissing
Testing my changes, I noticed that the poxy/ssl tests now take about 4 minutes to complete. I reverted and it stays the same on current trunk: trunk (r81897548), unchanged: t/ssl/proxy.t .. ok All tests successful. Files=1, Tests=290, 249 wallclock secs ( 0.12 usr 0.01 sys + 0.73 cusr 0.16 cs

Re: svn commit: r1897472 - in /httpd/httpd/trunk: include/httpd.h server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/winnt/child.c server/mpm/worker/worker.c server/util.c

2022-01-27 Thread Yann Ylavic
On Thu, Jan 27, 2022 at 9:40 AM Ruediger Pluem wrote: > > On 1/25/22 9:28 PM, yla...@apache.org wrote: > > > > -#if AP_HAS_THREAD_LOCAL > > -/* Create an apr_thread_t for the main child thread to set up its > > - * Thread Local Storage. Since it's detached and it won't > > - * apr_thre

Re: svn commit: r1897460 - in /httpd/httpd/trunk: include/ modules/core/ modules/http2/ modules/ssl/ server/ server/mpm/event/ server/mpm/prefork/ server/mpm/winnt/ server/mpm/worker/

2022-01-27 Thread Yann Ylavic
On Thu, Jan 27, 2022 at 9:36 AM Ruediger Pluem wrote: > > Would it make sense to move the above code to mpm_common.c as it looks very > similar for each MPM? Good point, in r1897543 I replaced ap_thread_current_create() by ap_thread_main_create() which is how it's used in httpd anyway. That's st

Re: mpm event assertion failures

2022-01-27 Thread Stefan Eissing
> Am 26.01.2022 um 17:06 schrieb Graham Leggett : > > On 26 Jan 2022, at 13:49, Stefan Eissing wrote: > >> Guys, we have changes in a central part of the server and our CI fails.=20= >> >> It is not good enough to give other people unspecific homework to fix = >> it.=20 >> >> Analyze what y

Re: mpm event assertion failures

2022-01-27 Thread Ruediger Pluem
On 1/26/22 6:34 PM, Yann Ylavic wrote: > On Wed, Jan 26, 2022 at 5:07 PM Graham Leggett wrote: >> >> We need to clarify expectations at this point. >> >> The trunk of httpd has a policy called “commit then review” (CTR), meaning >> that changes are applied first, and then review is done to see

Re: svn commit: r1897472 - in /httpd/httpd/trunk: include/httpd.h server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/winnt/child.c server/mpm/worker/worker.c server/util.c

2022-01-27 Thread Ruediger Pluem
On 1/25/22 9:28 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Jan 25 20:28:28 2022 > New Revision: 1897472 > > URL: http://svn.apache.org/viewvc?rev=1897472&view=rev > Log: > core: Follow up to r1897460: Implement and use ap_thread_current_after_fork(). > > thread_local variables a

Re: svn commit: r1897460 - in /httpd/httpd/trunk: include/ modules/core/ modules/http2/ modules/ssl/ server/ server/mpm/event/ server/mpm/prefork/ server/mpm/winnt/ server/mpm/worker/

2022-01-27 Thread Ruediger Pluem
On 1/25/22 6:34 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Jan 25 17:34:57 2022 > New Revision: 1897460 > > URL: http://svn.apache.org/viewvc?rev=1897460&view=rev > Log: > core: Efficient ap_thread_current() when apr_thread_local() is missing. > > #define ap_thread_create, ap_th