Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58

+1 Built/tested on: CentOS 6 CentOS 7 AlmaLinux 9 Ubuntu 20.04 Ubuntu 22.04 Regards, Cory McIntire | Lead – cPanel Application Security Team | Release Manager – EasyApache cory.mcint...@webpros.com | cPanel – a webpros company From: Stefan Eissing via dev

Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58

+1 for me, Slackware64 15.0. Thanks for the RM, yes. On Mon, Oct 16, 2023 at 11:43 AM Joe Orton wrote: > On Mon, Oct 16, 2023 at 05:08:11PM +0200, Stefan Eissing via dev wrote: > > Hi all, > > > > after fixing my merge mistake in rc2 (sorry!), we go again: > > > > Please find below the proposed

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x:./modules/http2/h2.h

Thanks Joe. #include "apr_tables.h" does not help. Steffen On Monday 16/10/2023 at 15:41, Joe Orton wrote: On Mon, Oct 16, 2023 at 03:12:24PM +0200, SteffenAL wrote: checkout. Looks like h2_ws.h : Generating Code... h2_ws.h C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error

Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58

On Mon, Oct 16, 2023 at 05:08:11PM +0200, Stefan Eissing via dev wrote: > Hi all, > > after fixing my merge mistake in rc2 (sorry!), we go again: > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE

Re: svn commit: r1913028 - /httpd/httpd/tags/2.4.58-rc2-candidate/

Yes > Op 16 okt 2023 om 17:02 heeft Ruediger Pluem het volgende > geschreven: > > Windows 64 bit is fine? > > Regards > > Rüdiger > >> On 10/16/23 3:52 PM, SteffenAL wrote: >> No go. All other modules fine, only mod_http2 error. >> >> Recap: >> >> On windows 32: >> >> Generating Code...

[VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58

Hi all, after fixing my merge mistake in rc2 (sorry!), we go again: Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.58-rc3 as 2.4.58: [ ]

Re: svn commit: r1913028 - /httpd/httpd/tags/2.4.58-rc2-candidate/

Windows 64 bit is fine? Regards Rüdiger On 10/16/23 3:52 PM, SteffenAL wrote: > No go. All other modules fine, only mod_http2 error. > > Recap: > > On windows 32: > > Generating Code... > h2_ws.h > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax > error: missing ';'

Re: windows block

On Mon, Oct 16, 2023 at 04:45:29PM +0200, Stefan Eissing via dev wrote: > Do I make an rc3 nevertheless? Do we know someone else using VC? > > Advice appreciated. +1 for rc3 at r1913027. Someone using VC needs to work out how to fix that rather than just report it's broken, it shouldn't hold

windows block

Do I make an rc3 nevertheless? Do we know someone else using VC? Advice appreciated. - Stefan

Re: svn commit: r1913028 - /httpd/httpd/tags/2.4.58-rc2-candidate/

Steffen, > Am 16.10.2023 um 15:52 schrieb SteffenAL : > > No go. All other modules fine, only mod_http2 error. > > Recap: > > On windows 32: > > Generating Code... > h2_ws.h > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax > error: missing ';' before '*' >

Re: svn commit: r1913028 - /httpd/httpd/tags/2.4.58-rc2-candidate/

No go. All other modules fine, only mod_http2 error. Recap: On windows 32: Generating Code... h2_ws.h C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax error: missing ';' before '*' C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C4430: missing type

Re: [VOTE] Release httpd-2.4.58-rc2 as httpd-2.4.58

> Am 16.10.2023 um 15:40 schrieb Ruediger Pluem : > > I am sorry, but #include "apr_encode.h" is still unconditional in h2_ws.c in > 2.4.x. Fixed in r1913027. Thanks for catching this. > > Regards > > Rüdiger > > > On 10/16/23 3:31 PM, Stefan Eissing via dev wrote: >> Hi all, >> >>

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./modules/http2/h2.h

On 10/16/23 3:18 PM, Stefan Eissing via dev wrote: > >> Am 16.10.2023 um 15:12 schrieb SteffenAL : >> >> checkout. >> >> Looks like h2_ws.h : >> >> Generating Code... >> h2_ws.h >> C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax >> error: missing ';' before '*' >>

Re: [VOTE] Release httpd-2.4.58-rc2 as httpd-2.4.58

I am sorry, but #include "apr_encode.h" is still unconditional in h2_ws.c in 2.4.x. Fixed in r1913027. Regards Rüdiger On 10/16/23 3:31 PM, Stefan Eissing via dev wrote: > Hi all, > > after some hickups with getting the new WebSockets support to > compile on Joe's old computers, we try

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./modules/http2/h2.h

On Mon, Oct 16, 2023 at 03:12:24PM +0200, SteffenAL wrote: > > checkout. > > > Looks like h2_ws.h : > > > Generating Code... > h2_ws.h > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax > error: missing ';' before '*' >

[VOTE] Release httpd-2.4.58-rc2 as httpd-2.4.58

Hi all, after some hickups with getting the new WebSockets support to compile on Joe's old computers, we try again! Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./modules/http2/h2.h

> Am 16.10.2023 um 15:12 schrieb SteffenAL : > > checkout. > > Looks like h2_ws.h : > > Generating Code... > h2_ws.h > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax > error: missing ';' before '*' > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C4430:

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

On Mon, Oct 16, 2023 at 9:13 AM Joe Orton wrote: > > On Mon, Oct 16, 2023 at 02:54:58PM +0200, Ruediger Pluem wrote: > > Fails for me as well. Not sure what fails for Joe such that he removed the > > include, but if it fails in case H2_USE_WEBSOCKETS is > > not 1 I guess we could move the

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

> Am 16.10.2023 um 15:12 schrieb Joe Orton : > > On Mon, Oct 16, 2023 at 02:54:58PM +0200, Ruediger Pluem wrote: >> Fails for me as well. Not sure what fails for Joe such that he removed the >> include, but if it fails in case H2_USE_WEBSOCKETS is >> not 1 I guess we could move the include

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./modules/http2/h2.h

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

On Mon, Oct 16, 2023 at 02:54:58PM +0200, Ruediger Pluem wrote: > Fails for me as well. Not sure what fails for Joe such that he removed the > include, but if it fails in case H2_USE_WEBSOCKETS is > not 1 I guess we could move the include (or even all) below the > > #if H2_USE_WEBSOCKETS > >

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./ modules/http2/h2.h

Steffen, just to be sure: did you test a 2.4.x checkout or did you apply the patch from Joe yourself? if there is not other feedback, I'll make a new candidate soon. > Am 16.10.2023 um 14:06 schrieb SteffenAL : > > The new h2h gives now on Windows 32 : > > syntax error: identifier 'conn_rec'

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

> Am 16.10.2023 um 14:54 schrieb Ruediger Pluem : > > > > On 10/16/23 2:38 PM, Stefan Eissing via dev wrote: >> >> >>> Am 16.10.2023 um 14:28 schrieb jor...@apache.org: >>> >>> Author: jorton >>> Date: Mon Oct 16 12:28:13 2023 >>> New Revision: 1913019 >>> >>> URL:

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

On 10/16/23 2:38 PM, Stefan Eissing via dev wrote: > > >> Am 16.10.2023 um 14:28 schrieb jor...@apache.org: >> >> Author: jorton >> Date: Mon Oct 16 12:28:13 2023 >> New Revision: 1913019 >> >> URL: http://svn.apache.org/viewvc?rev=1913019=rev >> Log: >> Further h2 compile fixes: >> >> *

Re: [VOTE] Release httpd-2.4.58-rc1 as httpd-2.4.58

rc1 vote is cancelled. There will be a rc2 soon. Thanks for testing. > Am 16.10.2023 um 12:07 schrieb Stefan Eissing via dev : > > Hi all, > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over

Re: [PATCH] fix mod_h2 with older nghttp2

On 10/16/23 2:38 PM, Joe Orton wrote: > BTW is modules/http2 really CTR for 2.4.x? STATUS says only > mod_proxy_http2 is. > > Anyway: I am +1 for r1913005 and r1913019 for 2.4.x, latter was > sufficient to get 2.4 building on RHEL8 again (if only we had a CI to do > this, oh...). I am also

Re: [PATCH] fix mod_h2 with older nghttp2

> Am 16.10.2023 um 14:38 schrieb Joe Orton : > > BTW is modules/http2 really CTR for 2.4.x? STATUS says only > mod_proxy_http2 is. I have made peace with myself to spend afterlife in hell. > Anyway: I am +1 for r1913005 and r1913019 for 2.4.x, latter was > sufficient to get 2.4 building

Re: [PATCH] fix mod_h2 with older nghttp2

BTW is modules/http2 really CTR for 2.4.x? STATUS says only mod_proxy_http2 is. Anyway: I am +1 for r1913005 and r1913019 for 2.4.x, latter was sufficient to get 2.4 building on RHEL8 again (if only we had a CI to do this, oh...). Regards, Joe

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

> Am 16.10.2023 um 14:28 schrieb jor...@apache.org: > > Author: jorton > Date: Mon Oct 16 12:28:13 2023 > New Revision: 1913019 > > URL: http://svn.apache.org/viewvc?rev=1913019=rev > Log: > Further h2 compile fixes: > > * modules/http2/h2_session.c (h2_session_start): > Restrict WebSockets

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./ modules/http2/h2.h

Hi Steffen, > Am 16.10.2023 um 14:06 schrieb SteffenAL : > > The new h2h gives now on Windows 32 : > > syntax error: identifier 'conn_rec' mod_http2 > C:\VS17\Win32\httpd-2.4\modules\http2\h2_ws.h 31 syntax error: missing ';' > before '*' mod_http2 C:\VS17\Win32\httpd-2.4\modules\http2\h2.h

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./ modules/http2/h2.h

Re: svn commit: r1913010 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS

Thanks for merging. I am fine with this one not making in into the final 2.4.58 release (but of course also if it goes in in case we need a seconds rc). Am 16.10.23 um 13:45 schrieb rpl...@apache.org: Author: rpluem Date: Mon Oct 16 11:45:19 2023 New Revision: 1913010 URL:

Re: [PATCH] fix mod_h2 with older nghttp2

I will do. Regards Rüdiger On 10/16/23 1:13 PM, Stefan Eissing via dev wrote: > I added that patch to trunk and merged it into 2.4.x. > > I'll make another release candidate soonish. Someone wants to merge the back > ports idling in STATUS? > > Cheers, > Stefan > >> Am 16.10.2023 um 12:55

Re: [PATCH] fix mod_h2 with older nghttp2

I added that patch to trunk and merged it into 2.4.x. I'll make another release candidate soonish. Someone wants to merge the back ports idling in STATUS? Cheers, Stefan > Am 16.10.2023 um 12:55 schrieb Joe Orton : > > Looks like this broke with the websockets backport. mod_h2 is failing to

Re: [VOTE] Release httpd-2.4.58-rc1 as httpd-2.4.58

> Am 16.10.2023 um 12:28 schrieb Ruediger Pluem : > > First of all thanks for RM. > It looks to me that we have 2 accepted backports in the STATUS that have not > been merged. > This seems unfortunate. Well, I asked people to bring in the changes they want. I am not a merge machine for

[PATCH] fix mod_h2 with older nghttp2

Looks like this broke with the websockets backport. mod_h2 is failing to compile on versions of nghttp2 without NGHTTP2_SETTINGS_ENABLE_CONNECT_PROTOCOL - looks like this was added in nghttp2 v1.34.0 [1] so how about something like this, or is there a better way? (configure check for a

Re: [VOTE] Release httpd-2.4.58-rc1 as httpd-2.4.58

First of all thanks for RM. It looks to me that we have 2 accepted backports in the STATUS that have not been merged. This seems unfortunate. Regards Rüdiger On 10/16/23 12:07 PM, Stefan Eissing via dev wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > >

Httpd PR to edit balancer member HC timeout

Hello all, I hope this email finds you well. I have recently opened a PR on apache httpd project ( https://github.com/apache/httpd/pull/385) . After upgrading to httpd version 55, we have lost the capability to define a timeout for the health check that is different from that of the request. As

[VOTE] Release httpd-2.4.58-rc1 as httpd-2.4.58

Hi all, Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.58-rc1 as 2.4.58: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have