Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
On Mon, Oct 16, 2023 at 5:10 PM Stefan Eissing via dev wrote: > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.58-rc3 as 2.4.58: [X] +1: It's not just good, it's good enough! Tested on Debian 12 and 13. Thanks for RMing Stefan!
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
> Am 17.10.2023 um 20:37 schrieb SteffenAL : > > Found it. > > My error, had included h2_ws.h as extra library (sorry!). > > Vote now is +1 Thanks, Steffen. Good that you found the mistake. > > Steffen > >> --- Original message --- >> Subject: Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58 >> From: Steffen >> To: >> Date: Tuesday, 17/10/2023 18:29 >> >> For me still -1. >> >>> Op 17 okt 2023 om 18:18 heeft Stefan Eissing via dev >>> het volgende geschreven: >>> >>> Just got a reply from a contact that build rc3 on win64 and ran it >>> successfully. I invited him to participate here, not sure if he will feel >>> like it. >>> >>> I count that as a +1 on win64 unless someone objects. >>> >>> Cheers, >>> Stefan >>> >>> Am 17.10.2023 um 12:05 schrieb Stefan Eissing via dev : I am trying to contact another person that builds regularly mod_h2 on Windows. >> Am 17.10.2023 um 11:30 schrieb Steffen : > > Same error on win64. > Yes the reported mod_http2 errors on 32 and 64. > Yes, I am not able to tell what is wrong, only I can report the errors. I > am not a developer, just building and testing. > > Regards, Steffen > >> Op 17 okt 2023 om 11:08 heeft Stefan Eissing via dev >> het volgende geschreven: >> >> >> >>> Am 17.10.2023 um 08:41 schrieb Steffen : >>> >>> -1 does not build on windows. >> >> If I understood your reports from yesterday correctly, the situation is >> - you can build on win64 >> - you get compiler errors on your win32 build >> - you are not able to tell us what is wrong >> >> Correct? >> >> Cheers, >> Stefan >> >>> >>> Steffen >>> > Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev > het volgende geschreven: Hi all, after fixing my merge mistake in rc2 (sorry!), we go again: Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.58-rc3 as 2.4.58: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 *httpd-2.4.58-rc3.tar.gz sha512: 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 *httpd-2.4.58-rc3.tar.gz The SVN candidate source is found at tags/2.4.58-rc3-candidate. Cheers, Stefan >>> >> > >>> > > <1pixel.gif>
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
Found it. My error, had included h2_ws.h as extra library (sorry!). Vote now is +1 Steffen --- Original message --- Subject: Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58 From: Steffen To: Date: Tuesday, 17/10/2023 18:29 For me still -1. Op 17 okt 2023 om 18:18 heeft Stefan Eissing via dev het volgende geschreven: Just got a reply from a contact that build rc3 on win64 and ran it successfully. I invited him to participate here, not sure if he will feel like it. I count that as a +1 on win64 unless someone objects. Cheers, Stefan Am 17.10.2023 um 12:05 schrieb Stefan Eissing via dev : I am trying to contact another person that builds regularly mod_h2 on Windows. Am 17.10.2023 um 11:30 schrieb Steffen : Same error on win64. Yes the reported mod_http2 errors on 32 and 64. Yes, I am not able to tell what is wrong, only I can report the errors. I am not a developer, just building and testing. Regards, Steffen Op 17 okt 2023 om 11:08 heeft Stefan Eissing via dev het volgende geschreven: Am 17.10.2023 um 08:41 schrieb Steffen : -1 does not build on windows. If I understood your reports from yesterday correctly, the situation is - you can build on win64 - you get compiler errors on your win32 build - you are not able to tell us what is wrong Correct? Cheers, Stefan Steffen Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev het volgende geschreven: Hi all, after fixing my merge mistake in rc2 (sorry!), we go again: Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.58-rc3 as 2.4.58: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 *httpd-2.4.58-rc3.tar.gz sha512: 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 *httpd-2.4.58-rc3.tar.gz The SVN candidate source is found at tags/2.4.58-rc3-candidate. Cheers, Stefan
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
Steve Hay was a great resource once upon a time ago, but meh, you can't draw blood from a stone forever. On Tue, Oct 17, 2023 at 12:32 PM Steffen wrote: > For me still -1. > > > Op 17 okt 2023 om 18:18 heeft Stefan Eissing via dev < > dev@httpd.apache.org> het volgende geschreven: > > > > Just got a reply from a contact that build rc3 on win64 and ran it > successfully. I invited him to participate here, not sure if he will feel > like it. > > > > I count that as a +1 on win64 unless someone objects. > > > > Cheers, > > Stefan > > > > > >> Am 17.10.2023 um 12:05 schrieb Stefan Eissing via dev < > dev@httpd.apache.org>: > >> > >> I am trying to contact another person that builds regularly mod_h2 on > Windows. > >> > Am 17.10.2023 um 11:30 schrieb Steffen : > >>> > >>> Same error on win64. > >>> Yes the reported mod_http2 errors on 32 and 64. > >>> Yes, I am not able to tell what is wrong, only I can report the > errors. I am not a developer, just building and testing. > >>> > >>> Regards, Steffen > >>> > Op 17 okt 2023 om 11:08 heeft Stefan Eissing via dev < > dev@httpd.apache.org> het volgende geschreven: > > > > > Am 17.10.2023 um 08:41 schrieb Steffen : > > > > -1 does not build on windows. > > If I understood your reports from yesterday correctly, the situation > is > - you can build on win64 > - you get compiler errors on your win32 build > - you are not able to tell us what is wrong > > Correct? > > Cheers, > Stefan > > > > > Steffen > > > >>> Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev < > dev@httpd.apache.org> het volgende geschreven: > >> > >> Hi all, > >> > >> after fixing my merge mistake in rc2 (sorry!), we go again: > >> > >> Please find below the proposed release tarball and signatures: > >> > >> https://dist.apache.org/repos/dist/dev/httpd/ > >> > >> I would like to call a VOTE over the next few days to release > >> this candidate tarball httpd-2.4.58-rc3 as 2.4.58: > >> [ ] +1: It's not just good, it's good enough! > >> [ ] +0: Let's have a talk. > >> [ ] -1: There's trouble in paradise. Here's what's wrong. > >> > >> The computed digests of the tarball up for vote are: > >> sha256: > 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 > *httpd-2.4.58-rc3.tar.gz > >> sha512: > 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 > *httpd-2.4.58-rc3.tar.gz > >> > >> The SVN candidate source is found at tags/2.4.58-rc3-candidate. > >> > >> Cheers, > >> Stefan > > > > >>> > >> > > > >
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
For me still -1. > Op 17 okt 2023 om 18:18 heeft Stefan Eissing via dev > het volgende geschreven: > > Just got a reply from a contact that build rc3 on win64 and ran it > successfully. I invited him to participate here, not sure if he will feel > like it. > > I count that as a +1 on win64 unless someone objects. > > Cheers, > Stefan > > >> Am 17.10.2023 um 12:05 schrieb Stefan Eissing via dev : >> >> I am trying to contact another person that builds regularly mod_h2 on >> Windows. >> Am 17.10.2023 um 11:30 schrieb Steffen : >>> >>> Same error on win64. >>> Yes the reported mod_http2 errors on 32 and 64. >>> Yes, I am not able to tell what is wrong, only I can report the errors. I >>> am not a developer, just building and testing. >>> >>> Regards, Steffen >>> Op 17 okt 2023 om 11:08 heeft Stefan Eissing via dev het volgende geschreven: > Am 17.10.2023 um 08:41 schrieb Steffen : > > -1 does not build on windows. If I understood your reports from yesterday correctly, the situation is - you can build on win64 - you get compiler errors on your win32 build - you are not able to tell us what is wrong Correct? Cheers, Stefan > > Steffen > >>> Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev >>> het volgende geschreven: >> >> Hi all, >> >> after fixing my merge mistake in rc2 (sorry!), we go again: >> >> Please find below the proposed release tarball and signatures: >> >> https://dist.apache.org/repos/dist/dev/httpd/ >> >> I would like to call a VOTE over the next few days to release >> this candidate tarball httpd-2.4.58-rc3 as 2.4.58: >> [ ] +1: It's not just good, it's good enough! >> [ ] +0: Let's have a talk. >> [ ] -1: There's trouble in paradise. Here's what's wrong. >> >> The computed digests of the tarball up for vote are: >> sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 >> *httpd-2.4.58-rc3.tar.gz >> sha512: >> 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 >> *httpd-2.4.58-rc3.tar.gz >> >> The SVN candidate source is found at tags/2.4.58-rc3-candidate. >> >> Cheers, >> Stefan > >>> >> >
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
Just got a reply from a contact that build rc3 on win64 and ran it successfully. I invited him to participate here, not sure if he will feel like it. I count that as a +1 on win64 unless someone objects. Cheers, Stefan > Am 17.10.2023 um 12:05 schrieb Stefan Eissing via dev : > > I am trying to contact another person that builds regularly mod_h2 on Windows. > >> Am 17.10.2023 um 11:30 schrieb Steffen : >> >> Same error on win64. >> Yes the reported mod_http2 errors on 32 and 64. >> Yes, I am not able to tell what is wrong, only I can report the errors. I am >> not a developer, just building and testing. >> >> Regards, Steffen >> >>> Op 17 okt 2023 om 11:08 heeft Stefan Eissing via dev >>> het volgende geschreven: >>> >>> >>> Am 17.10.2023 um 08:41 schrieb Steffen : -1 does not build on windows. >>> >>> If I understood your reports from yesterday correctly, the situation is >>> - you can build on win64 >>> - you get compiler errors on your win32 build >>> - you are not able to tell us what is wrong >>> >>> Correct? >>> >>> Cheers, >>> Stefan >>> Steffen >> Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev >> het volgende geschreven: > > Hi all, > > after fixing my merge mistake in rc2 (sorry!), we go again: > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.58-rc3 as 2.4.58: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 > *httpd-2.4.58-rc3.tar.gz > sha512: > 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 > *httpd-2.4.58-rc3.tar.gz > > The SVN candidate source is found at tags/2.4.58-rc3-candidate. > > Cheers, > Stefan >>> >> >
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
On Mon, Oct 16, 2023 at 11:10 AM Stefan Eissing via dev wrote: > > Hi all, > > after fixing my merge mistake in rc2 (sorry!), we go again: > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.58-rc3 as 2.4.58: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 > *httpd-2.4.58-rc3.tar.gz > sha512: > 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 > *httpd-2.4.58-rc3.tar.gz > > The SVN candidate source is found at tags/2.4.58-rc3-candidate. +1 AIX/xlc
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
I think William Rowe can help. He is the guy who helped a lot with windows. > Op 17 okt 2023 om 12:05 heeft Stefan Eissing via dev > het volgende geschreven: > > I am trying to contact another person that builds regularly mod_h2 on > Windows. > >> Am 17.10.2023 um 11:30 schrieb Steffen : >> >> Same error on win64. >> Yes the reported mod_http2 errors on 32 and 64. >> Yes, I am not able to tell what is wrong, only I can report the errors. I am >> not a developer, just building and testing. >> >> Regards, Steffen >> Op 17 okt 2023 om 11:08 heeft Stefan Eissing via dev het volgende geschreven: >>> >>> >>> Am 17.10.2023 um 08:41 schrieb Steffen : -1 does not build on windows. >>> >>> If I understood your reports from yesterday correctly, the situation is >>> - you can build on win64 >>> - you get compiler errors on your win32 build >>> - you are not able to tell us what is wrong >>> >>> Correct? >>> >>> Cheers, >>> Stefan >>> Steffen >> Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev >> het volgende geschreven: > > Hi all, > > after fixing my merge mistake in rc2 (sorry!), we go again: > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.58-rc3 as 2.4.58: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 > *httpd-2.4.58-rc3.tar.gz > sha512: > 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 > *httpd-2.4.58-rc3.tar.gz > > The SVN candidate source is found at tags/2.4.58-rc3-candidate. > > Cheers, > Stefan >>> >> >
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
I am trying to contact another person that builds regularly mod_h2 on Windows. > Am 17.10.2023 um 11:30 schrieb Steffen : > > Same error on win64. > Yes the reported mod_http2 errors on 32 and 64. > Yes, I am not able to tell what is wrong, only I can report the errors. I am > not a developer, just building and testing. > > Regards, Steffen > >> Op 17 okt 2023 om 11:08 heeft Stefan Eissing via dev >> het volgende geschreven: >> >> >> >>> Am 17.10.2023 um 08:41 schrieb Steffen : >>> >>> -1 does not build on windows. >> >> If I understood your reports from yesterday correctly, the situation is >> - you can build on win64 >> - you get compiler errors on your win32 build >> - you are not able to tell us what is wrong >> >> Correct? >> >> Cheers, >> Stefan >> >>> >>> Steffen >>> > Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev > het volgende geschreven: Hi all, after fixing my merge mistake in rc2 (sorry!), we go again: Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.58-rc3 as 2.4.58: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 *httpd-2.4.58-rc3.tar.gz sha512: 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 *httpd-2.4.58-rc3.tar.gz The SVN candidate source is found at tags/2.4.58-rc3-candidate. Cheers, Stefan >>> >> >
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
> Am 16.10.2023 um 17:08 schrieb Stefan Eissing via dev : > > Hi all, > > after fixing my merge mistake in rc2 (sorry!), we go again: > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.58-rc3 as 2.4.58: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 > *httpd-2.4.58-rc3.tar.gz > sha512: > 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 > *httpd-2.4.58-rc3.tar.gz > > The SVN candidate source is found at tags/2.4.58-rc3-candidate. > > Cheers, > Stefan +1 on macOS Ventura 13.5.2 - Stefan
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
Same error on win64. Yes the reported mod_http2 errors on 32 and 64. Yes, I am not able to tell what is wrong, only I can report the errors. I am not a developer, just building and testing. Regards, Steffen > Op 17 okt 2023 om 11:08 heeft Stefan Eissing via dev > het volgende geschreven: > > > >> Am 17.10.2023 um 08:41 schrieb Steffen : >> >> -1 does not build on windows. > > If I understood your reports from yesterday correctly, the situation is > - you can build on win64 > - you get compiler errors on your win32 build > - you are not able to tell us what is wrong > > Correct? > > Cheers, > Stefan > >> >> Steffen >> Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev het volgende geschreven: >>> >>> Hi all, >>> >>> after fixing my merge mistake in rc2 (sorry!), we go again: >>> >>> Please find below the proposed release tarball and signatures: >>> >>> https://dist.apache.org/repos/dist/dev/httpd/ >>> >>> I would like to call a VOTE over the next few days to release >>> this candidate tarball httpd-2.4.58-rc3 as 2.4.58: >>> [ ] +1: It's not just good, it's good enough! >>> [ ] +0: Let's have a talk. >>> [ ] -1: There's trouble in paradise. Here's what's wrong. >>> >>> The computed digests of the tarball up for vote are: >>> sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 >>> *httpd-2.4.58-rc3.tar.gz >>> sha512: >>> 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 >>> *httpd-2.4.58-rc3.tar.gz >>> >>> The SVN candidate source is found at tags/2.4.58-rc3-candidate. >>> >>> Cheers, >>> Stefan >> >
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
> Am 17.10.2023 um 08:41 schrieb Steffen : > > -1 does not build on windows. If I understood your reports from yesterday correctly, the situation is - you can build on win64 - you get compiler errors on your win32 build - you are not able to tell us what is wrong Correct? Cheers, Stefan > > Steffen > >> Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev >> het volgende geschreven: >> >> Hi all, >> >> after fixing my merge mistake in rc2 (sorry!), we go again: >> >> Please find below the proposed release tarball and signatures: >> >> https://dist.apache.org/repos/dist/dev/httpd/ >> >> I would like to call a VOTE over the next few days to release >> this candidate tarball httpd-2.4.58-rc3 as 2.4.58: >> [ ] +1: It's not just good, it's good enough! >> [ ] +0: Let's have a talk. >> [ ] -1: There's trouble in paradise. Here's what's wrong. >> >> The computed digests of the tarball up for vote are: >> sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 >> *httpd-2.4.58-rc3.tar.gz >> sha512: >> 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 >> *httpd-2.4.58-rc3.tar.gz >> >> The SVN candidate source is found at tags/2.4.58-rc3-candidate. >> >> Cheers, >> Stefan >
Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x:./modules/http2/h2.h
If you revert r1913027, r1913024, r1913006, hence
--- modules/http2/h2.h (revision 1913024)
+++ modules/http2/h2.h (revision 1913006)
@@ -20,8 +20,6 @@
#include
#include
-#include
-
struct h2_session;
struct h2_stream;
@@ -41,9 +39,7 @@
#define H2_USE_POLLFD_FROM_CONN 0
#endif
+#if H2_USE_PIPES
-/* WebSockets support requires apr 1.7.0 for apr_encode.h, plus the
- * WebSockets features of nghttp2 1.34.0 and later. */
-#if H2_USE_PIPES && defined(NGHTTP2_VERSION_NUM) && NGHTTP2_VERSION_NUM >=
0x012200 && APR_VERSION_AT_LEAST(1,7,0)
#define H2_USE_WEBSOCKETS 1
#else
#define H2_USE_WEBSOCKETS 0
reverted:
--- modules/http2/h2_ws.c (revision 1913027)
+++ modules/http2/h2_ws.c (revision 1913024)
@@ -19,6 +19,7 @@
#include "apr.h"
#include "apr_strings.h"
#include "apr_lib.h"
+#include "apr_encode.h"
#include "apr_sha1.h"
#include "apr_strmatch.h"
@@ -44,8 +45,6 @@
#if H2_USE_WEBSOCKETS
-#include "apr_encode.h" /* H2_USE_WEBSOCKETS is conditional on APR 1.6+ */
-
static ap_filter_rec_t *c2_ws_out_filter_handle;
struct ws_filter_ctx {
it works again on win32?
Regards
Rüdiger
On 10/16/23 6:04 PM, SteffenAL wrote:
> Thanks Joe.
>
> #include "apr_tables.h" does not help.
>
> Steffen
>
>
> On Monday 16/10/2023 at 15:41, Joe Orton wrote:
>> On Mon, Oct 16, 2023 at 03:12:24PM +0200, SteffenAL wrote:
>>>
>>> checkout.
>>>
>>>
>>> Looks like h2_ws.h :
>>>
>>>
>>> Generating Code...
>>> h2_ws.h
>>> C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax
>>> error: missing ';' before '*'
>>> C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C4430: missing
>>> type specifier - int assumed. Note: C++ does not support default-int
>>
>> Windows compiler errors are often specific to the Windows, you should
>> not assume anybody else here will understand (or care) about them. So
>> rather than reporting, can you work out what the problem is? Line 173
>> uses apr_table_t, does adding #include "apr_tables.h" somewhere help
>> here?
>>
>> Regards, Joe
>>
>
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
-1 does not build on windows. Steffen > Op 16 okt 2023 om 17:10 heeft Stefan Eissing via dev > het volgende geschreven: > > Hi all, > > after fixing my merge mistake in rc2 (sorry!), we go again: > > Please find below the proposed release tarball and signatures: > > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release > this candidate tarball httpd-2.4.58-rc3 as 2.4.58: > [ ] +1: It's not just good, it's good enough! > [ ] +0: Let's have a talk. > [ ] -1: There's trouble in paradise. Here's what's wrong. > > The computed digests of the tarball up for vote are: > sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 > *httpd-2.4.58-rc3.tar.gz > sha512: > 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 > *httpd-2.4.58-rc3.tar.gz > > The SVN candidate source is found at tags/2.4.58-rc3-candidate. > > Cheers, > Stefan
Re: [VOTE] Release httpd-2.4.58-rc3 as httpd-2.4.58
On 10/16/23 17:08, Stefan Eissing via dev wrote: Hi all, after fixing my merge mistake in rc2 (sorry!), we go again: Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball httpd-2.4.58-rc3 as 2.4.58: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. The computed digests of the tarball up for vote are: sha256: 503a7da4a4a27fd496037998b17078dc9fe004db32c657c96cce8356b8aa2eb6 *httpd-2.4.58-rc3.tar.gz sha512: 5c11faf0572035ef67b27775d975999411c689cb774553175299a9e99b63d3d7138b0c7f15048ec28038494d8513689f916202c2289d557947d8b190d46ca9f3 *httpd-2.4.58-rc3.tar.gz The SVN candidate source is found at tags/2.4.58-rc3-candidate. +1 builds and works fine on OpenBSD 7.4 and Fedora 38. Thanks for the RM. Giovanni OpenPGP_signature.asc Description: OpenPGP digital signature
