Re: svn commit: r1588244 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS docs/manual/mod/mod_headers.xml modules/metadata/mod_headers.c

2014-04-17 Thread Marion Christophe JAILLET
Hi, Changelog entry is about Header and RequestHeader but doc has only been updated for the first one. Moreover, a compatibility note should be, IMO, added for the updated syntax. CJ Le 17/04/2014 15:36, j...@apache.org a écrit : Changes with Apache 2.4.10 + *) mod_headers: Allow

Re: svn commit: r1584896 - /httpd/httpd/trunk/modules/filters/mod_proxy_html.c

2014-04-17 Thread Marion Christophe JAILLET
r1588356 Should you share my analysis and should a CHANGE be useful for what I think is a corner case, feel free to add something, or I can do it by the end of the week. Does this fix a crash or a parsing error or ...? (CHANGES)

Re: svn commit: r1584896 - /httpd/httpd/trunk/modules/filters/mod_proxy_html.c

2014-04-15 Thread Marion Christophe JAILLET
Hi, AFAIK, no crash has ever been reported for that. I just noted this while looking at PR56287 and found it odd. A file such as: +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+- htmlhead meta http-equiv=Conten contentheadbody/body/html +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+- will trigger the scan past the end

Re: svn commit: r1584941 - /httpd/httpd/branches/2.4.x/STATUS

2014-04-05 Thread Marion Christophe JAILLET
Hi, I've gone quickly thru the module and I have a few remarks: - What is the use of FN_LOG_MARK on line 87? Couldn't we use APLOG_MARK instead? 'connect_to_peer' is called only in one place with module_index=APLOG_MODULE_INDEX - Do things like

Re: svn commit: r1584582 - /httpd/httpd/branches/2.4.x/STATUS

2014-04-04 Thread Marion Christophe JAILLET
Le 04/04/2014 13:59, Yann Ylavic a écrit : On Fri, Apr 4, 2014 at 1:35 PM, Eric Covener cove...@gmail.com wrote: FYI not necessary to propose docs-only changes in STATUS, they are CTR. Oh, I see, thanks for the information. Should I (or one) backport it if no one else screams for a while

Re: AW: APR_FOPEN_BUFFERED and small files

2014-02-14 Thread Marion Christophe JAILLET
lol, sure Le 14/02/2014 21:44, Plüm, Rüdiger, Vodafone Group a écrit : -Ursprüngliche Nachricht- Von: Christophe JAILLET Gesendet: Freitag, 14. Februar 2014 21:39 An: dev@httpd.apache.org Betreff: APR_FOPEN_BUFFERED and small files Hi, when a file is opened using apr_file_open

Re: [VOTE] obscuring (or not) commit logs/CHANGES for fixes to vulnerabilities

2014-01-10 Thread Marion Christophe JAILLET
Le 10/01/2014 14:38, Jeff Trawick a écrit : [ ] It is an accepted practice (but not required) to obscure or omit the vulnerability impact in CHANGES or commit log information when committing fixes for vulnerabilities to any branch. [X] It is mandatory to provide best available description

Re: svn commit: r1556914 - /httpd/httpd/trunk/modules/dav/lock/locks.c

2014-01-09 Thread Marion Christophe JAILLET
Sure, but I personally prefer to keep only one exit point in functions. Just a matter of taste. CJ Le 09/01/2014 20:17, Rainer Jung a écrit : On 09.01.2014 19:48, jaillet...@apache.org wrote: Author: jailletc36 Date: Thu Jan 9 18:48:11 2014 New Revision: 1556914 URL:

Re: Some redundant code and comment typos in mod_remoteip

2013-12-13 Thread Marion Christophe JAILLET
Not correct, this is just a french man who didn't take time to check in a dictionary... :) I update... Thx CJ Le 13/12/2013 19:57, Mike Rumph a écrit : equivalant versus equivalent Perhaps this is a difference in British versus American spelling, correct? Anyway, thanks for the

Re: svn commit: r1490290 - /httpd/httpd/trunk/modules/lua/lua_passwd.c

2013-06-06 Thread Marion Christophe JAILLET
Correct. This was introduced in r1465115. Fixed in trunk in r1490507. Le 06/06/2013 17:54, Guenter Knauf a écrit : ua/lua_passwd.c T

Re: svn commit: r1476694 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS docs/manual/mod/mod_authnz_ldap.xml include/ap_mmn.h include/httpd.h modules/aaa/mod_authnz_ldap.c server/util.c

2013-04-27 Thread Marion Christophe JAILLET
Le 28/04/2013 01:14, minf...@apache.org a écrit : Author: minfrin Date: Sat Apr 27 23:14:11 2013 New Revision: 1476694 URL: http://svn.apache.org/r1476694 Log: mod_authnz_ldap: Allow using exec: callouts like SSLPassphraseDialog for AuthLDAPBindPassword. trunk patch:

Re: svn commit: r1463045 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c

2013-03-31 Thread Marion Christophe JAILLET
Hi, they are 3 similar constructions in server/log.c CJ Le 31/03/2013 22:13, s...@apache.org a écrit : Author: sf Date: Sun Mar 31 20:13:48 2013 New Revision: 1463045 URL: http://svn.apache.org/r1463045 Log: ap_log_error already logs the error string, no need to log it twice Modified:

Re: svn commit: r1463049 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c

2013-03-31 Thread Marion Christophe JAILLET
Hi, doc also has to be clean the same way. CJ Le 31/03/2013 22:38, s...@apache.org a écrit : Author: sf Date: Sun Mar 31 20:38:17 2013 New Revision: 1463049 URL: http://svn.apache.org/r1463049 Log: Remove partial non-working implementation of MD5-sess and qop=auth-int. If anyone wants to

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-22 Thread Marion Christophe JAILLET
Yes, i work and test on trunk. I'll give it a try. Thx CJ Le 22/03/2013 22:14, Stefan Fritsch a écrit : On Tuesday 19 March 2013, Marion Christophe JAILLET wrote: Le 18/03/2013 22:43, Stefan Fritsch a écrit : On Thursday 14 March 2013, you wrote: BTW, I tried to activate pool debug

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-19 Thread Marion Christophe JAILLET
Le 18/03/2013 22:43, Stefan Fritsch a écrit : On Thursday 14 March 2013, you wrote: BTW, I tried to activate pool debug with using |-enable-pool-debug=all but the server crashes while starting on my test machine. Do you know if it is supposed to work (and I do something wrong) or no one uses

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-13 Thread Marion Christophe JAILLET
My goal was to check for useless memory allocation when calling logging function. Logging with TRACE is unlikely to output something on a production machine. However, function called as parameters of the logging function will still be called. I made a check on the whole source code to check

Re: svn commit: r1455225 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/ docs/manual/howto/ docs/manual/mod/ include/ modules/filters/ modules/generators/ modules/slotmem/ os/unix/ server/ support/

2013-03-11 Thread Marion Christophe JAILLET
Le 11/03/2013 20:32, Gregg Smith a écrit : On 3/11/2013 9:38 AM, j...@apache.org wrote: Author: jim Date: Mon Mar 11 16:38:39 2013 New Revision: 1455225 URL: http://svn.apache.org/r1455225 Log: Merge r1442865, r1442759, r1442326, r1442309, r1448171, r1418556, r1448453, r1425771, r1425772,

Re: svn commit: r1451478 - /httpd/httpd/trunk/server/util_script.c

2013-03-03 Thread Marion Christophe JAILLET
Le 01/03/2013 11:43, Guenter Knauf a écrit : Hi Christophe, Am 01.03.2013 08:00, schrieb Christophe JAILLET: To quick... you can fix the svn log with: svn propedit -r 1451478 --revprop svn:log Gün. Thanks, done. CJ

Question about memory allocation in 'substring_conf' (server/util.c)

2013-02-05 Thread Marion Christophe JAILLET
Hi, This may look useless, but I can't figure out why in function 'substring_conf' (line 752 in server/util.c) we allocate len+2 bytes ? This seems to have been like that forever. IMO, len+1 should be enough. Changing that would be a huge memory usage improvement :). Does any one has an

Re: svn commit: r1422549 - in /httpd/httpd/trunk: include/ap_mmn.h include/httpd.h server/util.c server/util_md5.c

2012-12-17 Thread Marion Christophe JAILLET
Le 17/12/2012 00:20, Stefan Fritsch a écrit : +AP_DECLARE(void) ap_bin2hex(const void *src, apr_size_t srclen, char *dest) +{ +const unsigned char *in = src; +unsigned char *out = (unsigned char *)dest; +apr_size_t i; + +for (i = 0; i srclen; i++) { +*out++ =

Re: svn commit: r1420377 - in /httpd/httpd/trunk: docs/manual/mod/mod_lua.xml modules/lua/lua_apr.c modules/lua/lua_apr.h modules/lua/mod_lua.c

2012-12-12 Thread Marion Christophe JAILLET
Here are a few things triggered by cppcheck. Le 11/12/2012 21:08, humbed...@apache.org a écrit : Author: humbedooh Date: Tue Dec 11 20:08:24 2012 New Revision: 1420377 URL: http://svn.apache.org/viewvc?rev=1420377view=rev Log: mod_lua: Add a lot of core httpd/apr functionality to mod_lua

Re: svn commit: r1419755 - /httpd/httpd/trunk/modules/http/http_filters.c

2012-12-10 Thread Marion Christophe JAILLET
Le 10/12/2012 21:53, jaillet...@apache.org a écrit : Author: jailletc36 Date: Mon Dec 10 20:53:24 2012 New Revision: 1419755 URL: http://svn.apache.org/viewvc?rev=1419755view=rev Log: Avoid unnecessary %s substitution Modified: httpd/httpd/trunk/modules/http/http_filters.c Modified:

Re: svn commit: r1417892 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/ docs/manual/mod/ include/ modules/proxy/

2012-12-06 Thread Marion Christophe JAILLET
Le 06/12/2012 14:59, j...@apache.org a écrit : Author: jim Date: Thu Dec 6 13:59:32 2012 New Revision: 1417892 URL: http://svn.apache.org/viewvc?rev=1417892view=rev Log: Merge r1404653 from trunk: Allow for setting of sticky session split char... Bugz 53893 [...] ---

<    1   2