Re: Re: unreaped zombie children of mod_fcgid

2013-09-11 Thread Pqf 潘庆峰
Hi, Yes, you are right, a httpd process marks a fcgid process as busy and then suddenly dies would cause the zombie issue. I agree with your idea except: don't move process to error list, but a new create process list (like zombie list?). Because a processs busy timeout not necessary

Re: unreaped zombie children of mod_fcgid

2013-09-10 Thread Pqf 潘庆峰
> I presume that this is the reason why mod_fcgid does not use a SIGCHLD > handler. mod_fcgid have to work on both UNIX and Win32, so the it pick a portable way to make it done on both platforms. > Given the above, I can not find any holes in the mod_fcgid logic which could > lead to unreaped zo

Re: Re: Anyone interested in a patch to mod_fcgid(with pay)

2013-07-22 Thread Pqf 潘庆峰
Yes, split process control from mod_fcgid, merge proxy_fcgi(with load balance) and mod_fcgid(with authXX support) is a good idea, admins can use httpd as process manager, or 3rd party process managers as they like. But don't just make a patch to make mod_fcgid support TCP/IP, it's ugly... > >

Anyone interested in a patch to mod_fcgid(with pay)

2013-07-19 Thread Pqf 潘庆峰
Hi, guys A company need a "TCP/IP patch of mod_fcgid or alternative", and will pay for it, anyone interested? I really like to take it but I don't have too much time... Anyone interested please reply to me and I will forward the email address of them. Our company is hosting a website wit

Re: Re: Re: mod_fcgid concurrency bottleneck, issue#53693

2012-09-04 Thread pqf
Hi, all I took some times to setup a stress test for mod_fcgid, to see is there any other concurrency bottleneck left, it seems fine to me. I did a stress test with callgrind on mod_fcgid, this is the big picture: http://people.apache.org/~pqf/mod_fcgid_performance/performance.png and this is

Re: Pull request: server/util_md5.c:58 - replace magic number with constant arithmetic

2012-08-29 Thread pqf
Some C compilers don't support this: result[2*APR_MD5_DIGESTSIZE+1] ? Hello, dev@. I request a little change to HTTPD code. On line 58 of server/util_md5.c, please replace char *r, result[33]; /* (MD5_DIGESTSIZE * 2) + 1 */ with char *r, result[2*APR_MD5_DIGESTSIZE+1]; There's o

回复: Re: Re: Re: mod_fcgid concurrency bottleneck, issue#53693

2012-08-27 Thread pqf
httpd(or mod_fcgid) either drop client connections or delay a while, there is no other way out? Another question. Is it necessary to call procmgr_init_spawn_cmd() from inside the for loop ? I took a brief look, it seems not necessary. I will move it out of loop and test. 2012-08-28 pqf 发件人

回复: Re: Re: mod_fcgid concurrency bottleneck, issue#53693

2012-08-16 Thread pqf
How about this: 1. procmgr_post_spawn_cmd() now return a status code from PM, so process handler now know the spawn request is denyed or not. 2. if a new process is created, no sleep is needed. 3. if no process is created, sleep a while 2012-08-16 pqf 发件人:Lazy 发送时间:2012-08-16 16:47 主题:Re

Re: Re: mod_fcgid concurrency bottleneck, issue#53693

2012-08-16 Thread pqf
procmgr_post_spawn_cmd(maybe it should be renamed to procmgr_send_spawn_cmd) will keep blocking while PM is creating a new process, after procmgr_post_spawn_cmd() return, there should be a process ready there waiting for accept. 2012-08-16 pqf 发件人:William A. Rowe Jr. 发送时间:2012-08-16 15

Re: Re: mod_fcgid concurrency bottleneck, issue#53693

2012-08-15 Thread pqf
But since someone said remove this sleep(), the server work fine without bottleneck(Maybe he didn't notise the warm up issue?), so I thought remove the sleep() is a good idea. But reduce the time of sleep() is fine to me too. Any other idea? Regards, Ryan Pan 2012-08-16 pqf 发件人:Lazy 发送时

Re: mod_fcgid concurrency bottleneck, issue#53693

2012-08-15 Thread pqf
ss slot */ procmgr_post_spawn_cmd(&fcgi_request, r); + +/* Try again */ +bucket_ctx->procnode = apply_free_procnode(r, &fcgi_request); +if (bucket_ctx->procnode) +break; } /* Connect to the fastcgi server */ 2

回复: mod_fcgid concurrency bottleneck, issue#53693

2012-08-14 Thread pqf
Hi, Mike It's really a problem...I will take a look and find a solution for it 2012-08-15 pqf 发件人:Mike M 发送时间:2012-08-15 04:29 主题:mod_fcgid concurrency bottleneck, issue#53693 收件人:"dev" 抄送: Ahoy! With mod_fcgid I've observed a performance bottleneck in which concu

Re: Re: mod_fcgid can kill all the services on the server via kill -15 -1

2011-05-03 Thread pqf
0, sizeof(procnode->proc_id)); return APR_CHILD_DONE; } 2011-05-04 Ryan 发件人: "pqf" 发送时间: 2011-04-18 09:58 主 题: Re: mod_fcgid can kill all the services on the server via kill -15 -1 收件人: "dev" Hi, all Another question, does proc_wait_process() sho

Re: mod_fcgid can kill all the services on the server via kill -15 -1

2011-04-17 Thread pqf
Hi, all Another question, does proc_wait_process() should update procnode->proc_id to 0 too? or else mod_fcgid may send a signal to another irrelevant process while apache is shutting down? I don't follow up mod_fcgid for a while, I just took a glance, maybe it's updated somewhere else? By the w

Re: [mod_fcgid PATCH] catch errors from setuid()/seteuid()

2010-01-21 Thread pqf
Hi, Jeff Your concerns are right, +1 for your patch :) Thanks -- From: "Jeff Trawick" Sent: Thursday, January 21, 2010 9:23 PM To: Subject: Re: [mod_fcgid PATCH] catch errors from setuid()/seteuid() > On Wed, Jan 20, 2010 at

Re: [mod_fcgid PATCH] catch errors from setuid()/seteuid()

2010-01-20 Thread pqf
I man seteuid in my Linux box, there are two types of errors: ERRORS The seteuid() function shall fail if: EINVAL The value of the uid argument is invalid and is not supported by the implementation. EPERM The process does not have appropriate privileges and uid does not

Re: svn commit: r888840 - in /httpd/mod_fcgid/trunk/modules/fcgid: fcgid_bridge.c fcgid_pm_main.c

2009-12-15 Thread pqf
nges :) Thanks -- From: "Jeff Trawick" Sent: Tuesday, December 15, 2009 10:49 PM To: Subject: Re: svn commit: r40 - in /httpd/mod_fcgid/trunk/modules/fcgid: fcgid_bridge.c fcgid_pm_main.c > On Wed, Dec 9, 2009 at 10:36 AM, wrote: >> Author: pqf >> Date:

Re: [mod_fcgid] Feedback / Suggestions

2009-11-24 Thread pqf
-- From: "Jeff Trawick" Sent: Tuesday, November 24, 2009 11:24 PM To: Subject: Re: [mod_fcgid] Feedback / Suggestions > On Tue, Nov 24, 2009 at 10:05 AM, Edgar Frank wrote: >> Hi dev, >> >> I'd like to suggest to following changes / offer feedba

Re: svn commit: r835406 - in /httpd/mod_fcgid/trunk/modules/fcgid: fcgid_pm_main.c fcgid_proc_unix.c fcgid_proc_win.c fcgid_proctbl.h mod_fcgid.c

2009-11-12 Thread pqf
- From: "Jeff Trawick" Sent: Friday, November 13, 2009 5:08 AM To: Subject: Re: svn commit: r835406 - in /httpd/mod_fcgid/trunk/modules/fcgid: fcgid_pm_main.c fcgid_proc_unix.c fcgid_proc_win.c fcgid_proctbl.h mod_fcgid.c > On Thu, Nov 12, 2009 at 10:05 AM, wrote: >> A

Re: Re: mod_fcgid: add mod_status support?

2009-11-11 Thread pqf
> > Jeff Trawick wrote: > > 2009/11/9 pqf : > >> Hi, all > >>I am new to this community, I am think to add mod_status support to > >> mod_fcgid, which provide more internal information to administrators. Is > >> it a good idea? I am wo

mod_fcgid: add mod_status support?

2009-11-09 Thread pqf
Hi, all I am new to this community, I am think to add mod_status support to mod_fcgid, which provide more internal information to administrators. Is it a good idea? I am working on it now, but if someone think it's not a good idea, please let me know. BTW, I did test spin lock on share m

Re: mod_fcgid: different instances of the same program

2009-11-09 Thread pqf
Hi, Yes, mod_fcgid search process node base on file's inode and deviceid(plus share_group_id, virtual host name). The goal is to create as less process as possible. Some administrators like the idea that all virtual hosts share one PHP process pool. (But some other don't, they can turn that o

[mod_fcgid] how about spin lock on share memory

2009-10-13 Thread pqf
Hi, all I am Ryan Pan, who wrote the first version of mod_fcgid. While I uesd mod_fastcgi(not mod_fcgid), one issue that bother me is: while a fastcgi process(created by mod_fastcgi's process manager process)in a dead loop, no one is respond to kick it out. So from time to time, some fastc

Re: Transfer Patch Rights for mod_fcgid ASF

2009-01-11 Thread pqf
5 AM Subject: Re: Transfer Patch Rights for mod_fcgid ASF > Chris Darroch wrote: >> pqf wrote: >> >>> Now both authors have subscribe this maillist and claimed to transfer >>> all rights to the patch >>> to the Apache Software Foundation, is it OK? Can we move

Re: Transfer Patch Rights for mod_fcgid ASF

2009-01-08 Thread pqf
Hi, Thank you Tim Jensen :) These are the "Major patchs" which I thought I should ask the patch authors: Major patches version 1.10 ( Jul 3rd 2006 ) 1. Use poll() instead of select() in UNIX. It becomes problematic on apache2 with large number of logfiles. Apache2 calls poll() (

Re: Re: mod_fcgid license questions

2009-01-01 Thread pqf
Hi, guys Good news is I track down another author now. We are talking about the license questions now, so far so good :) Thanks > -原始邮件- > 发件人: "Chris Darroch" > 发送时间: 2009年1月1日 星期四 > 收件人: dev@httpd.apache.org > 抄送: > 主题: Re: mod_fcgid license questions > > Hi -- > > > On 31 Dec 20

Re: mod_fcgid license questions

2008-12-30 Thread pqf
;, I think these patchs can be put to "minor patch" group too. Thanks - Original Message - From: "Chris Darroch" To: Sent: Wednesday, December 31, 2008 1:31 PM Subject: Re: mod_fcgid license questions > pqf wrote: > >> version 1.10 ( Jul 3rd 2006 ) &g

Re: mod_fcgid license questions

2008-12-18 Thread pqf
Hi, all Sorry for the delay, I have track down all patches base on my ChangeLog( I keep my mail archive), so here is my brief: the "Inside job" version 0.76 ( Jul 6th 2004 ) 1. Code fix. Replace the depreciated BRIGADE_FOREACH macro, which compi

Re: mod_fcgid license questions

2008-12-16 Thread pqf
aturday, December 13, 2008 11:18 AM Subject: Re: mod_fcgid license questions > pqf wrote: >> Hi, guys >> Nice to meet you :) I hope I can help to clarify the questions. > > Likewise :) > >>>When you wrote mod_fcgid, was there any code which you borrowed >

Re: mod_fcgid license questions

2008-12-11 Thread pqf
Hi, guys Nice to meet you :) I hope I can help to clarify the questions. >When you wrote mod_fcgid, was there any code which you borrowed >from mod_fastcgi? No. I didn't borrow any code from mod_fastcgi. >Your current intention is for mod_fcgid to be available under >the GPL v