non thread safe functions used in apache httpd project

2011-01-12 Thread Kevin J Walters
Hi, Whilst looking at a thread safety issue in mod_fastcgi, i noticed there's some suspicious looking code in apache httpd project. server/mpm_common.c (2.2.17) has two functions ap_uname2id and ap_gname2id which call getpwnam and getgrnam, two non-reentrant functions. Comparing with typical ap

ap_reclaim_child_processes() and initialisation of waittime

2009-12-29 Thread Kevin J Walters
>>>>> "K" == Kevin J Walters writes: K> I noticed this in 2.2.14 and trunk in ./httpd/server/mpm_unix.c - it K> looks unusual in the sense that waittime is initialised with an K> integer value rather than using apr_time_msec()? K> void ap_reclaim_

ap_reclaim_child_processes() and initialisation of waittime

2009-12-29 Thread Kevin J Walters
Hi, I noticed this in 2.2.14 and trunk in ./httpd/server/mpm_unix.c - it looks unusual in the sense that waittime is initialised with an integer value rather than using apr_time_msec()? void ap_reclaim_child_processes(int terminate) { apr_time_t waittime = 1024 * 16; regards |

ap_process_child_status() and child pid exit signal logging

2009-12-02 Thread Kevin J Walters
Hi, I've noticed that all versions of apache (1.3 to 2.2) will produce error log output like this, [Mon Jan 1 00:00:00 2009] [notice] child pid 12345 exit signal Segmentation fault (11) In the case of a segmentation fault or anything that produces a core dump this is a relatively serious erro

Re: Mitigating the Slowloris DoS attack

2009-06-24 Thread Kevin J Walters
> "M" == Matthieu Estrade writes: M> More granular timeout and maybe adaptative timeout is also IMHO a good M> way to improve resistance to this kind of attack. The current 1.3, 2.0 and 2.2 documentation is in agreement too! I believe the ssl module also takes its timeout value from this s

testing for connections with keep-alive property from modules

2009-06-23 Thread Kevin J Walters
Hi, What's the recommended way to check for a connection having the property of being kept alive? I was expecting to see tests like c->keepalive == AP_CONN_KEEPALIVE but i see that mod_proxy.c is testing c->keepalives which is the incrementing counter of requests processed on that connection. Ar