Re: svn commit: r1897123 - /httpd/httpd/patches/2.4.x/httpd-2.4-ldap-expr.patch

[Graham Leggett]

On 16 Jan 2022, at 18:54, Yann Ylavic  wrote:

> Maybe "ldap_escape" would be a more appropriate name, should there be
> a need for another ldap function (e.g. "ldap_unescape") later?

This doesn’t follow the existing “short” naming pattern of the existing 
entries. I image that we’d add something like “unldap" to match “unbase64”.

Regards,
Graham
—

Re: svn commit: r1897123 - /httpd/httpd/patches/2.4.x/httpd-2.4-ldap-expr.patch

[Yann Ylavic]

On Sun, Jan 16, 2022 at 2:42 PM  wrote:
>
> +Index: server/util_expr_eval.c
> +===
> +--- server/util_expr_eval.c(revision 1897120)
>  server/util_expr_eval.c(working copy)
[]
> +@@ -1667,6 +1678,9 @@
> + { unbase64_func,"unbase64",   NULL, 0 },
> + { sha1_func,"sha1",   NULL, 0 },
> + { md5_func, "md5",NULL, 0 },
> ++#if APR_VERSION_AT_LEAST(1,6,0)
> ++{ ldap_func,"ldap",   NULL, 0 },
> ++#endif
> + { NULL, NULL, NULL}
> + };

Maybe "ldap_escape" would be a more appropriate name, should there be
a need for another ldap function (e.g. "ldap_unescape") later?

Regards;
Yann.