Re: AW: svn commit: r1776575 - in /httpd/httpd/trunk: docs/log-message-tags/next-number docs/manual/mod/mod_remoteip.xml modules/metadata/mod_remoteip.c

2017-02-04 Thread Daniel Ruggeri
On 1/30/2017 4:45 AM, Ruediger Pluem wrote: > Thinking of all the above it might be best if you read in mode > AP_MODE_SPECULATIVE on your own from upstream until > you have MIN_HDR_LEN data. If the PROXY header is present, read MIN_HDR_LEN > in AP_MODE_READBYTES to finally consume the > data an

Re: AW: svn commit: r1776575 - in /httpd/httpd/trunk: docs/log-message-tags/next-number docs/manual/mod/mod_remoteip.xml modules/metadata/mod_remoteip.c

2017-01-30 Thread Ruediger Pluem
On 01/28/2017 07:14 PM, Daniel Ruggeri wrote: > > On 1/25/2017 9:02 PM, Daniel Ruggeri wrote: >> On 1/25/2017 6:53 PM, Daniel Ruggeri wrote: >>> I'd say that not returning until ctx->bb has enough information to >>> determine if the header is present or not would be sufficient. Isn't >>> this al

Re: AW: svn commit: r1776575 - in /httpd/httpd/trunk: docs/log-message-tags/next-number docs/manual/mod/mod_remoteip.xml modules/metadata/mod_remoteip.c

2017-01-28 Thread Daniel Ruggeri
On 1/25/2017 9:02 PM, Daniel Ruggeri wrote: > On 1/25/2017 6:53 PM, Daniel Ruggeri wrote: >> I'd say that not returning until ctx->bb has enough information to >> determine if the header is present or not would be sufficient. Isn't >> this already done in the potentially repeated calls to ap_get_b

Re: AW: svn commit: r1776575 - in /httpd/httpd/trunk: docs/log-message-tags/next-number docs/manual/mod/mod_remoteip.xml modules/metadata/mod_remoteip.c

2017-01-25 Thread Daniel Ruggeri
On 1/25/2017 6:53 PM, Daniel Ruggeri wrote: > I'd say that not returning until ctx->bb has enough information to > determine if the header is present or not would be sufficient. Isn't > this already done in the potentially repeated calls to ap_get_brigade on > line no 1056 inside the loop verifying

Re: AW: svn commit: r1776575 - in /httpd/httpd/trunk: docs/log-message-tags/next-number docs/manual/mod/mod_remoteip.xml modules/metadata/mod_remoteip.c

2017-01-25 Thread Daniel Ruggeri
First, my apologies, but it looks like line wrapping is going to exceed the usual number of columns so formatting may get wonky in this reply. On 1/17/2017 3:48 AM, Plüm, Rüdiger, Vodafone Group wrote: > >> -Ursprüngliche Nachricht- >> Von: Daniel Ruggeri [mailto:drugg...@primary.net] >> G

AW: svn commit: r1776575 - in /httpd/httpd/trunk: docs/log-message-tags/next-number docs/manual/mod/mod_remoteip.xml modules/metadata/mod_remoteip.c

2017-01-17 Thread Plüm , Rüdiger , Vodafone Group
> -Ursprüngliche Nachricht- > Von: Daniel Ruggeri [mailto:drugg...@primary.net] > Gesendet: Dienstag, 17. Januar 2017 00:57 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r1776575 - in /httpd/httpd/trunk: docs/log- > message-tags/next-number docs/manual/mod/mod_remoteip.xml > modul