Re: Patch for implementing ap_document_root as a hook

2007-04-26 Thread Jim Jagielski
On Apr 23, 2007, at 10:46 AM, Brian J. France wrote: On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. The

Re: Patch for implementing ap_document_root as a hook

2007-04-26 Thread Brian J. France
On Apr 26, 2007, at 8:35 AM, Jim Jagielski wrote: We currently hack the doc root in the post read hook in 1.3, would like to be able to do it with out hacking the core and screwing around with internal structs at runtime. VERY doubtful that 1.3 will be updated to do this. I don't need it

Re: RFC: replace r-subprocess_env was Re: Patch for implementing ap_document_root as a hook

2007-04-25 Thread Jakob Goldbach
Thoughts? I like it. I prefer this generel env. API rather than making ap_add_{common,cgi}_vars hook'able. /Jakob

Patch for implementing ap_document_root as a hook

2007-04-23 Thread Jakob Goldbach
Hi, Attached is a patch which implements ap_document_root(r) as a hook. This way modules can set document_root on the fly. (think vhost_alias) AND get the right DOCUMENT_ROOT env. variable (as set by ap_add_common_vars(r)). The patch also changes ap_core_translate to use ap_document_root(r)

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Jakob Goldbach
It is now in bugzilla as #42192 /Jakob

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread William A. Rowe, Jr.
Jakob Goldbach wrote: Hi, Attached is a patch which implements ap_document_root(r) as a hook. This way modules can set document_root on the fly. (think vhost_alias) AND get the right DOCUMENT_ROOT env. variable (as set by ap_add_common_vars(r)). The patch also changes ap_core_translate

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Jakob Goldbach
-1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. The problem is not really doing the translation. I can always provide my own translate handler in my module. But in

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Brian J. France
On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. The problem is not really doing the translation. I can

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Paul Querna
Brian J. France wrote: On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. The problem is not really doing the

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Akins, Brian
On 4/23/07 11:33 AM, Paul Querna [EMAIL PROTECTED] wrote: +1, I've been down this road before too. +1 on the concept. Still looking at patch. -- Brian Akins Chief Operations Engineer Turner Digital Media Technologies

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread William A. Rowe, Jr.
Brian J. France wrote: On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. Actually it does both. An amusing

RFC: replace r-subprocess_env was Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Akins, Brian
This idea has been rattling around in my head off and on for a while. What is we replaced all the r-subprocess_env with something a little more interesting... General environment API: /* directly set an env variable. Will always show up in env list */ apr_status_t ap_set_env(request_rec *r,

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread William A. Rowe, Jr.
William A. Rowe, Jr. wrote: Brian J. France wrote: On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. Actually