Re: OpenSSL locking was Re: mod_ssl broken as DSO in HEAD

2003-06-18 Thread Geoff Thorpe
Hi, On June 18, 2003 02:28 am, Justin Erenkrantz wrote: > Finally got a chance to dig some more and found that if I add: > > CRYPTO_set_id_callback(openssl_id); > > to ssl_hook_pre_config before the ENGINE_load_builtin_engines and where > openssl_id is defined as: > > static unsigned long openssl_

RE: OpenSSL locking was Re: mod_ssl broken as DSO in HEAD

2003-06-18 Thread MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)
-Original Message- >From: Justin Erenkrantz [mailto:[EMAIL PROTECTED] >[SNIP] > >On this same tangent, do we need to be doing all of the CRYPTO_ stuff? >I don't believe we are doing that. And, I know in flood, we had lots of >problems until we called them. So, I think mod_ssl should be

Re: mod_ssl broken as DSO in HEAD

2003-06-18 Thread Geoff Thorpe
Hi there, On June 16, 2003 10:14 pm, William A. Rowe, Jr. wrote: > At 08:13 PM 6/16/2003, Justin Erenkrantz wrote: > >The change to move OpenSSL's initialization to ssl_hook_pre_config is > > busted when mod_ssl is a DSO. It will try to call all of the OpenSSL > > init sequences twice which I don

OpenSSL locking was Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Justin Erenkrantz
--On Tuesday, June 17, 2003 4:34 PM -0400 Geoff Thorpe <[EMAIL PROTECTED]> wrote: Well first off, the original backtrace showed a segfault down inside the bowels of the error handlers, something to do with CRYPTO_thread_id() IIRC. That you were getting this, combined with the fact you couldn't ge

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Geoff Thorpe
Hi, On June 17, 2003 04:06 pm, Justin Erenkrantz wrote: > --On Tuesday, June 17, 2003 12:46 PM -0500 "William A. Rowe, Jr." > > <[EMAIL PROTECTED]> wrote: > > If folks would be so kind as to cvs up their httpd-2.1 trees and > > check out the latest cleanup reordering and introduction of ENGINE_ >

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread William A. Rowe, Jr.
Actually, that is Geoff's code; would you mind taking a look? I suppose I should point out that I was building libssl/libcrypto into mod_ssl, which is why I never observed this bug. No matter which ultimate solution we adopt - we need to stay cognizant of both static and dynamic (the one I forgot

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Justin Erenkrantz
--On Tuesday, June 17, 2003 12:46 PM -0500 "William A. Rowe, Jr." <[EMAIL PROTECTED]> wrote: If folks would be so kind as to cvs up their httpd-2.1 trees and check out the latest cleanup reordering and introduction of ENGINE_ and CONF_ cleanups - I would be most grateful. Geoff, if you could revi

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread William A. Rowe, Jr.
[Resending from an account I know will fly] At 07:28 AM 6/17/2003, Jeff Trawick wrote: >William A. Rowe, Jr. wrote: >>At 09:15 PM 6/16/2003, Jeff Trawick wrote: >> >>>Justin Erenkrantz wrote: >>> Since pre_config doesn't get the process info, we can't use the userdata trick to prevent dou

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Jeff Trawick
William A. Rowe, Jr. wrote: My bad - setenv() will 'work' on win32 to modify the program's 'C' environment table. Where it falls down is modifying the 'inherited' environment, which must be maintained with SetEnvironmentVariable. Why setenv() on Win32 didn't do this has always puzzled me. By the

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread William A. Rowe, Jr.
If folks would be so kind as to cvs up their httpd-2.1 trees and check out the latest cleanup reordering and introduction of ENGINE_ and CONF_ cleanups - I would be most grateful. Geoff, if you could review the latest commit for sanity, I'd appreciate that, too. Bill At 12:17 PM 6/17/2003, Geoff

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Greg Stein
On Tue, Jun 17, 2003 at 08:53:43AM -0700, Justin Erenkrantz wrote: >... > As I said before, post_config gets the process pool, so why doesn't > pre_config? That seems like the best solution so far. However, that means > that we can't backport the mod_ssl changes to 2.0 or we have to come up >

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Jeff Trawick
Justin Erenkrantz wrote: --On Tuesday, June 17, 2003 12:07 PM -0400 Jeff Trawick <[EMAIL PROTECTED]> wrote: ap_hook_pre_config_ex() should work I'd be fine with a new hook in 2.0, but 2.1+ should just have pre_config modified to always take that pool parameter. I don't see a need to keep cru

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread William A. Rowe, Jr.
At 07:28 AM 6/17/2003, Jeff Trawick wrote: >William A. Rowe, Jr. wrote: >>At 09:15 PM 6/16/2003, Jeff Trawick wrote: >> >>>Justin Erenkrantz wrote: >>> Since pre_config doesn't get the process info, we can't use the userdata trick to prevent double initialization. My solution would be to

RE: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Sander Striker
> From: Justin Erenkrantz [mailto:[EMAIL PROTECTED] > Sent: Tuesday, June 17, 2003 6:11 PM > --On Tuesday, June 17, 2003 12:07 PM -0400 Jeff Trawick > <[EMAIL PROTECTED]> wrote: > > > ap_hook_pre_config_ex() should work > > I'd be fine with a new hook in 2.0, but 2.1+ should just have pre_confi

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Justin Erenkrantz
--On Tuesday, June 17, 2003 12:07 PM -0400 Jeff Trawick <[EMAIL PROTECTED]> wrote: ap_hook_pre_config_ex() should work I'd be fine with a new hook in 2.0, but 2.1+ should just have pre_config modified to always take that pool parameter. I don't see a need to keep cruft around just for cruft's

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Jeff Trawick
Justin Erenkrantz wrote: --On Monday, June 16, 2003 11:15 PM -0500 "William A. Rowe, Jr." <[EMAIL PROTECTED]> wrote: I just wonder why the global pool ID is "Unknowable". Why did we ever decree that the 'one true root pool' is unknowable to the masses (modules)? That would be a really sweet pl

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Justin Erenkrantz
--On Monday, June 16, 2003 11:15 PM -0500 "William A. Rowe, Jr." <[EMAIL PROTECTED]> wrote: I just wonder why the global pool ID is "Unknowable". Why did we ever decree that the 'one true root pool' is unknowable to the masses (modules)? That would be a really sweet place to drop process-lifetim

Re: mod_ssl broken as DSO in HEAD

2003-06-17 Thread Jeff Trawick
William A. Rowe, Jr. wrote: At 09:15 PM 6/16/2003, Jeff Trawick wrote: Justin Erenkrantz wrote: Since pre_config doesn't get the process info, we can't use the userdata trick to prevent double initialization. My solution would be to grow the pre_config hook to get the process info. But, that ca

Re: mod_ssl broken as DSO in HEAD

2003-06-16 Thread William A. Rowe, Jr.
At 09:15 PM 6/16/2003, Jeff Trawick wrote: >Justin Erenkrantz wrote: >>Since pre_config doesn't get the process info, we can't use the userdata trick to >>prevent double initialization. My solution would be to grow the pre_config hook to >>get the process info. But, that can't be what was inten

Re: mod_ssl broken as DSO in HEAD

2003-06-16 Thread Jeff Trawick
Justin Erenkrantz wrote: Since pre_config doesn't get the process info, we can't use the userdata trick to prevent double initialization. My solution would be to grow the pre_config hook to get the process info. But, that can't be what was intended. =) -- justin set an environment variable o

Re: mod_ssl broken as DSO in HEAD

2003-06-16 Thread William A. Rowe, Jr.
At 08:13 PM 6/16/2003, Justin Erenkrantz wrote: >The change to move OpenSSL's initialization to ssl_hook_pre_config is busted when >mod_ssl is a DSO. It will try to call all of the OpenSSL init sequences twice which >I don't believe OpenSSL supports. We may need to register proper 'cleanups' to

mod_ssl broken as DSO in HEAD

2003-06-16 Thread Justin Erenkrantz
The change to move OpenSSL's initialization to ssl_hook_pre_config is busted when mod_ssl is a DSO. It will try to call all of the OpenSSL init sequences twice which I don't believe OpenSSL supports. Namely, that is a problem for ENGINE_load_builtin_engines() which will 'detect' conflicting en