Re: svn commit: r1584941 - /httpd/httpd/branches/2.4.x/STATUS

2014-04-05 Thread Jeff Trawick
First, thanks for looking! On Sat, Apr 5, 2014 at 2:24 AM, Marion & Christophe JAILLET < christophe.jail...@wanadoo.fr> wrote: > Hi, > > I've gone quickly thru the module and I have a few remarks: > - What is the use of FN_LOG_MARK on line 87? Couldn't we use > APLOG_MARK instead? > 'co

Re: svn commit: r1584941 - /httpd/httpd/branches/2.4.x/STATUS

2014-04-04 Thread Marion & Christophe JAILLET
Hi, I've gone quickly thru the module and I have a few remarks: - What is the use of FN_LOG_MARK on line 87? Couldn't we use APLOG_MARK instead? 'connect_to_peer' is called only in one place with module_index=APLOG_MODULE_INDEX - Do things like AP_MODULE_MAGIC_AT_LEAST(20130702,2