Re: svn commit: r1787104 - /httpd/httpd/branches/2.4.x/STATUS

2017-03-21 Thread Jim Jagielski
I am find w/ either adding both to docs and TAKE1 or dropping the extra. Whatever we want/decide should be done on trunk 1st and we can add that as an addition. > On Mar 21, 2017, at 2:27 AM, Marion & Christophe JAILLET > wrote: > > Hi, > > +static const char *cmd_servertype(cmd_parms *cmd, voi

Re: svn commit: r1787104 - /httpd/httpd/branches/2.4.x/STATUS

2017-03-20 Thread Marion & Christophe JAILLET
Hi, +static const char *cmd_servertype(cmd_parms *cmd, void *in_dconf, + const char *val) +{ +[...] +else if (!strcasecmp(val, "FPM") || !strcasecmp(val, "PHP-FPM")) { Why? PHP-FPM is not documented, neither in the doc, nor in AP_INIT_TAKE1. In thi

Re: svn commit: r1787104 - /httpd/httpd/branches/2.4.x/STATUS

2017-03-20 Thread Eric Covener
On Mon, Mar 20, 2017 at 5:50 PM, Jacob Champion wrote: > One last question before I promote -- the "ProxyFCGIBackend FPM" case > currently just fixes up the SCRIPT_NAME and nothing else. Are you both okay > with releasing that way, since there's a good chance any further fixups we > discover will

Re: svn commit: r1787104 - /httpd/httpd/branches/2.4.x/STATUS

2017-03-20 Thread Jacob Champion
On 03/15/2017 03:30 PM, cove...@apache.org wrote: Author: covener Date: Wed Mar 15 22:30:23 2017 New Revision: 1787104 URL: http://svn.apache.org/viewvc?rev=1787104&view=rev Log: vote Modified: httpd/httpd/branches/2.4.x/STATUS Modified: httpd/httpd/branches/2.4.x/STATUS URL: http://svn.