Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-14 Thread Jeff Trawick
On 9/13/06, Nick Kew [EMAIL PROTECTED] wrote: On Wednesday 13 September 2006 22:31, Jeff Trawick wrote: On 9/13/06, Nick Kew [EMAIL PROTECTED] wrote: On Wednesday 13 September 2006 20:33, Ruediger Pluem wrote: Wouldn't it make sense to return OK even if rv != APR_SUCCESS in the case

Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-14 Thread Plüm , Rüdiger , VF EITO
-Ursprüngliche Nachricht- Von: Jeff Trawick Yes, I am supporting Rüdiger's proposition. Don't make up some HTTP status code for the aborted-connection condition. We already have a way to record this issue (%c). I guess by %c you mean what is now %X in, mod_log_config, right?

Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-14 Thread Jeff Trawick
On 9/14/06, Plüm, Rüdiger, VF EITO [EMAIL PROTECTED] wrote: -Ursprüngliche Nachricht- Von: Jeff Trawick Yes, I am supporting Rüdiger's proposition. Don't make up some HTTP status code for the aborted-connection condition. We already have a way to record this issue (%c). I

Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-13 Thread Ruediger Pluem
On 09/13/2006 01:44 AM, wrote: Author: niq Date: Tue Sep 12 16:44:12 2006 New Revision: 442758 URL: http://svn.apache.org/viewvc?view=revrev=442758 Log: PR 31759 (mutated) - reported by Jo Rhett Don't return apr_status_t error value from input filter chain. Modified:

Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-13 Thread Nick Kew
On Wednesday 13 September 2006 20:33, Ruediger Pluem wrote: Wouldn't it make sense to return OK even if rv != APR_SUCCESS in the case that c-aborted is set, just like in the default handler? I'm not sure. Presumably if c-aborted is set, then we have no client to respond to, so this is just

Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-13 Thread Ruediger Pluem
On 09/13/2006 10:17 PM, Nick Kew wrote: On Wednesday 13 September 2006 20:33, Ruediger Pluem wrote: Wouldn't it make sense to return OK even if rv != APR_SUCCESS in the case that c-aborted is set, just like in the default handler? I'm not sure. Presumably if c-aborted is set, then we

Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-13 Thread Jeff Trawick
On 9/13/06, Nick Kew [EMAIL PROTECTED] wrote: On Wednesday 13 September 2006 20:33, Ruediger Pluem wrote: Wouldn't it make sense to return OK even if rv != APR_SUCCESS in the case that c-aborted is set, just like in the default handler? I'm not sure. Presumably if c-aborted is set, then we

Re: svn commit: r442758 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-13 Thread Nick Kew
On Wednesday 13 September 2006 22:31, Jeff Trawick wrote: On 9/13/06, Nick Kew [EMAIL PROTECTED] wrote: On Wednesday 13 September 2006 20:33, Ruediger Pluem wrote: Wouldn't it make sense to return OK even if rv != APR_SUCCESS in the case that c-aborted is set, just like in the default