Re: Unused variables in code

2017-01-31 Thread Yakov Zhdanov
Thanks, Alexander! I looked this through and it seems fine to me. Anton V, can you also review and merge if it is OK to you? --Yakov 2017-01-31 12:49 GMT+03:00 Александр Меньшиков : > And result of testing: > http://ci.ignite.apache.org/project.html?projectId=IgniteTests=

[jira] [Created] (IGNITE-4632) AffinityFunction unchecked exception handling (unassigned backup)

2017-01-31 Thread Alexandr Kuramshin (JIRA)
Alexandr Kuramshin created IGNITE-4632: -- Summary: AffinityFunction unchecked exception handling (unassigned backup) Key: IGNITE-4632 URL: https://issues.apache.org/jira/browse/IGNITE-4632

Re: Python Platform for Ignite

2017-01-31 Thread Shashank Gandham
Okay, I will start look into the C++ shared libraries. > On 31-Jan-2017, at 1:44 AM, Denis Magda wrote: > > Hi Shashank, > > I’ve prepared tickets related to this activity: > https://issues.apache.org/jira/browse/IGNITE-4600 >

Re: Review for IGNITE-4436 API to collect list of running SQL queries

2017-01-31 Thread Denis Magda
> On Jan 31, 2017, at 4:24 PM, Alexey Kuznetsov wrote: > > Denis, > >>> I would make it transparent for the user giving ability to work with > LOCAL queries as well. How difficult is to support this? > I think it not should be very hard, but I will need some help from

Re: Review for IGNITE-4436 API to collect list of running SQL queries

2017-01-31 Thread Alexey Kuznetsov
Denis, >> I would make it transparent for the user giving ability to work with LOCAL queries as well. How difficult is to support this? I think it not should be very hard, but I will need some help from our SQL experts. >> Isn’t the goal of this task to support all SQL queries? Don’t get why you

Re: moving to geronimo JCache jar

2017-01-31 Thread Alexander Fedotov
Denis, it is my mistake to leave the header unchanged. It should be fixed because from now on the generation of license notes for dependencies under Apache Software License is enabled according to the point 3 in JIRA . I'll fix it and your notes

Re: moving to geronimo JCache jar

2017-01-31 Thread Denis Magda
Alexander, provided review notes in the Upsource. However, I’m still a bit concerned about the content of ignite-core-licenses.txt (see attached). The file says that it contains licenses different from the Apache Software license but in fact lists shmem, Intellij IDEA annotations and JSR 107

Re: Integration with RocketMQ

2017-01-31 Thread Denis Magda
Roman, Do you have any progress on this? It will be perfect to have the feature in 1.9. Please join the discussion: http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Ignite-1-9-td14170.html

Apache Ignite 1.9

2017-01-31 Thread Denis Magda
Igniters, Looks like 2.0 will be slightly delayed since the community requires more time to make the new page memory architecture faster. At the same time we have a plenty of bug fixes and performance improvements that were merged or close to be merged into the master and ready to be released.

Re: Review for IGNITE-4436 API to collect list of running SQL queries

2017-01-31 Thread Denis Magda
Hi Alex, >> 1) Current implementation will collect info and cancel only "TwoStep" >> queries. >>Should we also support LOCAL queries? >> I would make it transparent for the user giving ability to work with LOCAL queries as well. How difficult is to support this? >> 2) Should we also

Re: IGNITE-4212 (Ignite Benchmarking Simplification and Automation)

2017-01-31 Thread Denis Magda
Oleg, Thanks for the clarification. My opinion is that we should leave ‘modules/yardstick/README.txt’ and ‘modules/yardstick/DEVNOTES.txt’ either unchanged or have only those instructions there that explain how to build and run benchmarks from ‘modules/yardstick’. This existing files can

[GitHub] ignite pull request #1484: IGNITE-4631 Added check to ensure QueryEntity 'ke...

2017-01-31 Thread skalashnikov
GitHub user skalashnikov opened a pull request: https://github.com/apache/ignite/pull/1484 IGNITE-4631 Added check to ensure QueryEntity 'keyFields' is subset o… …f 'fields' You can merge this pull request into a Git repository by running: $ git pull

Re:

2017-01-31 Thread Denis Magda
Hi, Yes, you can and need to check changes incorporated in a pull-request using TeamCity. Refer to this documentation section: https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-1.CreateGitHubpull-request

[GitHub] ignite pull request #1483: IGNITE-4570 Parsing for CREATE INDEX and DROP IND...

2017-01-31 Thread alexpaschenko
GitHub user alexpaschenko opened a pull request: https://github.com/apache/ignite/pull/1483 IGNITE-4570 Parsing for CREATE INDEX and DROP INDEX You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4570

[GitHub] ignite pull request #1482: IGNITE-4630 return valid date for org.apache.igni...

2017-01-31 Thread ezhuravl
GitHub user ezhuravl opened a pull request: https://github.com/apache/ignite/pull/1482 IGNITE-4630 return valid date for org.apache.ignite.lang.IgniteProductVersion.releaseDate You can merge this pull request into a Git repository by running: $ git pull

Re: How to improve SQL testing

2017-01-31 Thread Oleg Ostanin
Hi, If there are no objections, I'd like implement this feature. Oleg On Tue, Jan 31, 2017 at 12:07 AM, Denis Magda wrote: > Hi, > > That’s true that the utility/testing framework needs to be as flexible as > possible. If the community can’t reuse an existing one let’s make

Re: How to improve SQL testing

2017-01-31 Thread Evgeniy Stanilovskiy
Sergey, did you take a look into https://en.wikipedia.org/wiki/YCSB ? https://github.com/joshwilliams/YCSB there is simple jdbc connector looks like it would be ok for us ? Hi, That’s true that the utility/testing framework needs to be as flexible as possible. If the community can’t reuse an