[GitHub] ignite pull request #3893: IGNITE-8342: When creating an index, unexpected n...

2018-04-20 Thread shroman
GitHub user shroman opened a pull request: https://github.com/apache/ignite/pull/3893 IGNITE-8342: When creating an index, unexpected non-default token cau… …ses an infinite loop. You can merge this pull request into a Git repository by running: $ git pull

Re: Service grid redesign

2018-04-20 Thread Valentin Kulichenko
Denis, > On the other hand, if exception is thrown from the *execute() *method, then service won't be undeployed. This is actually weird... What is going to happen in this case and how user would handle this? -Val On Fri, Apr 20, 2018 at 1:10 AM, Denis Mekhanikov wrote:

Re: GA Grid: Can IGNITE-8242 be include in 2.5 release?

2018-04-20 Thread Denis Magda
Those are isolated changes that shouldn't affect the rest of the platform. Andrey G., please approve the merge. I think it's fine to do. -- Denis On Fri, Apr 20, 2018 at 3:26 AM, Yury Babak wrote: > Sorry, https://issues.apache.org/jira/browse/IGNITE-7916 was done before

Re: Topology-wide notification on critical errors

2018-04-20 Thread Denis Magda
It might be useful if it's supported out of the box however usually DevOps and admins use tools like DynaTrace or Splunk to monitor all the logs, arrange logs in a meaningful way and set up special hooks for particular events. It means if an event happens only on 1 node the tool will still detect

GA Grid Documentation for 2.5

2018-04-20 Thread Denis Magda
Hi Turik, Are GA docs ready for 2.5 or you still working on them? https://apacheignite.readme.io/v2.4/docs/genetic-algorithms Please create a documentation ticket (component=documentation and fixVersion=2.5) and assign on Akmal for final review once you're done. He is our main ML docs editor.

[jira] [Created] (IGNITE-8349) Move GA Grid description to ML site page

2018-04-20 Thread Denis Magda (JIRA)
Denis Magda created IGNITE-8349: --- Summary: Move GA Grid description to ML site page Key: IGNITE-8349 URL: https://issues.apache.org/jira/browse/IGNITE-8349 Project: Ignite Issue Type: Task

[GitHub] ignite pull request #3892: Ignite-2.5.1.b5

2018-04-20 Thread agoncharuk
GitHub user agoncharuk opened a pull request: https://github.com/apache/ignite/pull/3892 Ignite-2.5.1.b5 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-2.5.1.b5 Alternatively you can review and

Re: Can't run CPP tests locally on linux machine

2018-04-20 Thread Nikolay Izhikov
I set one more enviromnent variable and now got success tests run. I see following output: *** 2 failures are detected in the test module "identity_resolver_test" Is it OK? В Пт, 20/04/2018 в 19:28 +0300, Nikolay Izhikov пишет: > Hello, Igor. > > As far as I can see from the Team City

Re: Can't run CPP tests locally on linux machine

2018-04-20 Thread Nikolay Izhikov
Hello, Igor. As far as I can see from the Team City settings the actual command to configure current master sources is `./configure --enable-odbc --enable-tests --prefix=%env.CPP_STAGING% CPPFLAGS=-I%env.CPP_STAGING%/include LDFLAGS=-L%env.CPP_STAGING%/lib` Can you give me content of

[GitHub] ignite pull request #3891: Ignite 8347 1

2018-04-20 Thread dspavlov
GitHub user dspavlov opened a pull request: https://github.com/apache/ignite/pull/3891 Ignite 8347 1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8347-1 Alternatively you can review and apply

Re: Ticket review checklist

2018-04-20 Thread Dmitry Pavlov
Hi Igniters, +1 to idea of checklist. +1 to refactoring and documenting code related to ticket in +/-20 LOC at least. If we start to do it as part of our regular contribution, code will be better, it would became common practice and part of Apache Ignite development culure. If we will hope we

Re: Ticket review checklist

2018-04-20 Thread Александр Меньшиков
4) Metrics. partially +1 It makes sense to have some minimal code coverage for new code in PR. IMHO. Also, we can limit the cyclomatic complexity of the new code in PR too. 6) Refactoring -1 I understand why people want to refactor old code. But I think refactoring should be always a separate

[GitHub] ignite pull request #3863: IGNITE-8134 fix service deployment from nodes out...

2018-04-20 Thread dmekhanikov
Github user dmekhanikov closed the pull request at: https://github.com/apache/ignite/pull/3863 ---

[GitHub] ignite pull request #3808: ignite-8205 make services be redeployed when clus...

2018-04-20 Thread dmekhanikov
Github user dmekhanikov closed the pull request at: https://github.com/apache/ignite/pull/3808 ---

[GitHub] ignite pull request #3890: IGNITE-8323 : Fixed discoveryEvent listener calls...

2018-04-20 Thread ilantukh
GitHub user ilantukh opened a pull request: https://github.com/apache/ignite/pull/3890 IGNITE-8323 : Fixed discoveryEvent listener calls. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8323

[jira] [Created] (IGNITE-8348) Debug information about discovery messages in TcpDiscoverySpiMBean

2018-04-20 Thread Vladislav Pyatkov (JIRA)
Vladislav Pyatkov created IGNITE-8348: - Summary: Debug information about discovery messages in TcpDiscoverySpiMBean Key: IGNITE-8348 URL: https://issues.apache.org/jira/browse/IGNITE-8348

[GitHub] ignite pull request #3889: IGNITE-8347 Memory leaks on restart Ignite node w...

2018-04-20 Thread tledkov-gridgain
GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/3889 IGNITE-8347 Memory leaks on restart Ignite node with enabled persistence at ThreadLocal You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (IGNITE-8347) Memory leaks on restart Ignite node with enabled persistence at ThreadLocal

2018-04-20 Thread Taras Ledkov (JIRA)
Taras Ledkov created IGNITE-8347: Summary: Memory leaks on restart Ignite node with enabled persistence at ThreadLocal Key: IGNITE-8347 URL: https://issues.apache.org/jira/browse/IGNITE-8347 Project:

[GitHub] ignite pull request #3888: IGNITE-8346 Add FileDownloaderTest to PDS 2 suit

2018-04-20 Thread DmitriyGovorukhin
GitHub user DmitriyGovorukhin opened a pull request: https://github.com/apache/ignite/pull/3888 IGNITE-8346 Add FileDownloaderTest to PDS 2 suit … + small refactoring. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (IGNITE-8346) FileDownloaderTest is not included in the test suite

2018-04-20 Thread Dmitriy Govorukhin (JIRA)
Dmitriy Govorukhin created IGNITE-8346: -- Summary: FileDownloaderTest is not included in the test suite Key: IGNITE-8346 URL: https://issues.apache.org/jira/browse/IGNITE-8346 Project: Ignite

Re: Ticket review checklist

2018-04-20 Thread Andrey Kuznetsov
What about adding the following item to the checklist: when the change adds new functionality, then unit tests should also be provided, if it's technically possible? As for refactorings, in fact they are strongly discouraged today for some unclear reason. Let's permit to make refactorings in the

[jira] [Created] (IGNITE-8345) Streamline tests' class names: mark Abstract and Load tests obviously so

2018-04-20 Thread Ilya Kasnacheev (JIRA)
Ilya Kasnacheev created IGNITE-8345: --- Summary: Streamline tests' class names: mark Abstract and Load tests obviously so Key: IGNITE-8345 URL: https://issues.apache.org/jira/browse/IGNITE-8345

[jira] [Created] (IGNITE-8344) Remove duplicate tests and suites

2018-04-20 Thread Ilya Kasnacheev (JIRA)
Ilya Kasnacheev created IGNITE-8344: --- Summary: Remove duplicate tests and suites Key: IGNITE-8344 URL: https://issues.apache.org/jira/browse/IGNITE-8344 Project: Ignite Issue Type: Bug

Re: Orphaned, duplicate, and main-class tests!

2018-04-20 Thread Ilya Kasnacheev
What's up with the following files: GridActivationAtomicCacheSuit GridActivationCacheAbstractTestSuit GridActivationLocalAndNearCacheSuit GridActivationPartitionedCacheSuit GridActivationReplicatedCacheSuit May I remove them? -- Ilya Kasnacheev 2018-04-19 16:41 GMT+03:00 Ilya Kasnacheev

[GitHub] ignite pull request #3879: IGNITE-8077 implemented getTxHoldingLockNum and g...

2018-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3879 ---

Re: Ticket review checklist

2018-04-20 Thread Vladimir Ozerov
Hi Ed, Unfortunately some of these points are not good candidates for the checklist because of these: - It must be clear and disallow *multiple interpretations* - It must be *lightweight*, otherwise Ignite development would become a nightmare We cannot have "nice to have" points here. Checklist

[GitHub] ignite pull request #3887: Ignite 1.8.19.b1

2018-04-20 Thread slukyano
GitHub user slukyano opened a pull request: https://github.com/apache/ignite/pull/3887 Ignite 1.8.19.b1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-1.8.19.b1 Alternatively you can review and

[GitHub] ignite pull request #3845: IGNITE-8078 New metrics for data store

2018-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3845 ---

[GitHub] ignite pull request #3886: IGNITE-7910 Improve transaction debugging support

2018-04-20 Thread ascherbakoff
GitHub user ascherbakoff opened a pull request: https://github.com/apache/ignite/pull/3886 IGNITE-7910 Improve transaction debugging support You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7910

Re: Ticket review checklist

2018-04-20 Thread Eduard Shangareev
Also, I want to add some technical requirement. Let's discuss them. 1) Code style. The code needs to be formatted according to coding guidelines . The code must not contain TODOs without a ticket reference. It is highly

[jira] [Created] (IGNITE-8343) InetSocketAddress.getAddress() returns null, should check it in TcpCommunicationSpi

2018-04-20 Thread Ilya Kasnacheev (JIRA)
Ilya Kasnacheev created IGNITE-8343: --- Summary: InetSocketAddress.getAddress() returns null, should check it in TcpCommunicationSpi Key: IGNITE-8343 URL: https://issues.apache.org/jira/browse/IGNITE-8343

[GitHub] ignite pull request #3821: IGNITE-8258 Fixed page acquire/write unlock order...

2018-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3821 ---

Re: Ticket review checklist

2018-04-20 Thread Eduard Shangareev
Hi, guys. I believe that we should update maintainers list before adding this review requirement. There should not be the situation when there is only one contributor who is responsible for a component. We already have issues with review speed and response time. On Fri, Apr 20, 2018 at 2:17 PM,

Re: Topology-wide notification on critical errors

2018-04-20 Thread Yakov Zhdanov
Of course, no guarantees, but at least an effort. --Yakov

[jira] [Created] (IGNITE-8342) Semi colon in CREATE INDEX causes infinite loop execution

2018-04-20 Thread Pavel Kuznetsov (JIRA)
Pavel Kuznetsov created IGNITE-8342: --- Summary: Semi colon in CREATE INDEX causes infinite loop execution Key: IGNITE-8342 URL: https://issues.apache.org/jira/browse/IGNITE-8342 Project: Ignite

[jira] [Created] (IGNITE-8341) .NET: Add new metrics for data storage

2018-04-20 Thread Dmitriy Govorukhin (JIRA)
Dmitriy Govorukhin created IGNITE-8341: -- Summary: .NET: Add new metrics for data storage Key: IGNITE-8341 URL: https://issues.apache.org/jira/browse/IGNITE-8341 Project: Ignite Issue

Re: Topology-wide notification on critical errors

2018-04-20 Thread Anton Vinogradov
P.s. Andrey Kuznetsov, corrected me that we have no warranty that failed node able to notify cluster. But, try{ sendDiscoveryMessageWithFail(...); } catch(){ // No-op; } is better than nothing, I think. 2018-04-20 14:22 GMT+03:00 Anton Vinogradov : > Sounds helpful and

[jira] [Created] (IGNITE-8340) .NET Implement new JMX metrics for transactions

2018-04-20 Thread Dmitriy Govorukhin (JIRA)
Dmitriy Govorukhin created IGNITE-8340: -- Summary: .NET Implement new JMX metrics for transactions Key: IGNITE-8340 URL: https://issues.apache.org/jira/browse/IGNITE-8340 Project: Ignite

[GitHub] ignite pull request #3885: IGNITE-8339 Do not log to WAL partition own durin...

2018-04-20 Thread Jokser
GitHub user Jokser opened a pull request: https://github.com/apache/ignite/pull/3885 IGNITE-8339 Do not log to WAL partition own during activation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

Re: Topology-wide notification on critical errors

2018-04-20 Thread Anton Vinogradov
Sounds helpful and easy to implement. 2018-04-20 5:39 GMT+03:00 Dmitriy Setrakyan : > On Thu, Apr 19, 2018 at 8:19 AM, Yakov Zhdanov > wrote: > > > Guys, > > > > We have activity to implement a set of mechanisms to handle critical > issues > > on

Re: Ticket review checklist

2018-04-20 Thread Anton Vinogradov
Vova, Everything you described sound good to me. I'd like to propose to create special page at AI Wiki and to describe checklist. In case we'll find something should be changed/improved it will be easy to update the page. 2018-04-20 0:53 GMT+03:00 Nikolay Izhikov : >

[jira] [Created] (IGNITE-8339) After cluster activation actual partition state restored from WAL may be lost

2018-04-20 Thread Pavel Kovalenko (JIRA)
Pavel Kovalenko created IGNITE-8339: --- Summary: After cluster activation actual partition state restored from WAL may be lost Key: IGNITE-8339 URL: https://issues.apache.org/jira/browse/IGNITE-8339

[jira] [Created] (IGNITE-8338) Cache operations hang after cluster deactivation and activation again

2018-04-20 Thread Pavel Kovalenko (JIRA)
Pavel Kovalenko created IGNITE-8338: --- Summary: Cache operations hang after cluster deactivation and activation again Key: IGNITE-8338 URL: https://issues.apache.org/jira/browse/IGNITE-8338 Project:

Re: Deprecate CacheRebalanceMode.NONE

2018-04-20 Thread Anton Vinogradov
+1 2018-04-17 19:29 GMT+03:00 Dmitry Pavlov : > +1 > > вт, 17 апр. 2018 г. в 19:14, Pavel Kovalenko : > > > +1 > > I also agree to remove this option in 3.0 > > > > 2018-04-17 19:00 GMT+03:00 Yakov Zhdanov : > > > > > +1 here > > >

Re: Transparent Data Encryption (TDE) in Apache Ignite

2018-04-20 Thread Nikolay Izhikov
Hello, Manu Thanks. I will take a look. В Пт, 20/04/2018 в 03:17 -0700, Manu пишет: > Hi, > > Have you think about implementing TDE per DataRegion instead of per Cache? > > And using a transparent encrypted java file system? > This GitHub project is interesting

Re: Transparent Data Encryption (TDE) in Apache Ignite

2018-04-20 Thread Manu
Hi, Have you think about implementing TDE per DataRegion instead of per Cache? And using a transparent encrypted java file system? This GitHub project is interesting https://github.com/usrflo/encfs4j . Hope it helps! Regards! -- Sent from:

[jira] [Created] (IGNITE-8337) Java ThinClient benchmark for yardstick

2018-04-20 Thread Sergey Kozlov (JIRA)
Sergey Kozlov created IGNITE-8337: - Summary: Java ThinClient benchmark for yardstick Key: IGNITE-8337 URL: https://issues.apache.org/jira/browse/IGNITE-8337 Project: Ignite Issue Type:

[jira] [Created] (IGNITE-8336) Web console: fix failing E2E notebooks test

2018-04-20 Thread Ilya Borisov (JIRA)
Ilya Borisov created IGNITE-8336: Summary: Web console: fix failing E2E notebooks test Key: IGNITE-8336 URL: https://issues.apache.org/jira/browse/IGNITE-8336 Project: Ignite Issue Type:

Re: [IGNITE-5714] Design proposal of suspend/resume for pessimistic tx

2018-04-20 Thread Кузнецов Алексей Львович
PR for this issue is ready to be reviewed. Changes are relatively small. 1. No network messages have been changed. 2. Thread id usage replaced with xid usage when we work with candidates. 3. All current tests are passed [3] Please, review. [1], [2] [1]

[GitHub] ignite pull request #3397: IGNITE-7077: Implementation of Spark query optimi...

2018-04-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3397 ---

[GitHub] ignite pull request #3884: Ignite 8322

2018-04-20 Thread oleg-ostanin
GitHub user oleg-ostanin opened a pull request: https://github.com/apache/ignite/pull/3884 Ignite 8322 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8322 Alternatively you can review and apply

[jira] [Created] (IGNITE-8335) TensorFlow integration

2018-04-20 Thread Yury Babak (JIRA)
Yury Babak created IGNITE-8335: -- Summary: TensorFlow integration Key: IGNITE-8335 URL: https://issues.apache.org/jira/browse/IGNITE-8335 Project: Ignite Issue Type: New Feature

[jira] [Created] (IGNITE-8334) Web console: add ability to show/hide password field value

2018-04-20 Thread Ilya Borisov (JIRA)
Ilya Borisov created IGNITE-8334: Summary: Web console: add ability to show/hide password field value Key: IGNITE-8334 URL: https://issues.apache.org/jira/browse/IGNITE-8334 Project: Ignite

Re: Service grid redesign

2018-04-20 Thread Denis Mekhanikov
Val, *init()* method is executed before a service is considered deployed. If any exception is thrown from it, then it will be handled as deployment failure. *execute() *method is run after the service is deployed, and it can keep running until the service is cancelled. This method has its own