Re: [DISCUSSION] Hot cache backup

2020-05-01 Thread Denis Magda
 https://twitter.com/ApacheIgnite/status/1256249943846576129 - Denis On Fri, May 1, 2020 at 2:05 AM Maxim Muzafarov wrote: > Folks, > > > I've merged the changes. > Thanks everyone for the help. > > Here are a few tasks that I'm going to complete too. > >

Re: [DISCUSSION] Hot cache backup

2020-05-01 Thread Maxim Muzafarov
Folks, I've merged the changes. Thanks everyone for the help. Here are a few tasks that I'm going to complete too. https://issues.apache.org/jira/browse/IGNITE-12968 https://issues.apache.org/jira/browse/IGNITE-12967 https://issues.apache.org/jira/browse/IGNITE-12961 On Wed, 29 Apr 2020 at

Re: [DISCUSSION] Hot cache backup

2020-04-29 Thread Denis Magda
Maxim, Ok, let's follow your plan. Ping me once the docs are ready. It's definitely not a blocker for merging the feature into the master. We can always adjust the implementation in the master before a public release. Btw, could you please fill in the "readiness estimated data" column in the

Re: [DISCUSSION] Hot cache backup

2020-04-29 Thread Maxim Muzafarov
Denis, No, I don't. I'm planning to work on documentation pages right after we'll finish with the source code changes. I will be very grateful if you will help with the review of the documentation. Currently, the approach is very straightforward and simple and I doubt we can change anything from

Re: [DISCUSSION] Hot cache backup

2020-04-29 Thread Denis Magda
Hi Maxim, Do you have a draft of docs in any form explaining how the feature is supposed to be used (snapshots creation, restore procedure, setting/changing snapshots location, etc. - essential operations for such capabilities)? I can help with the review from the user standpoint and might advise

Re: [DISCUSSION] Hot cache backup

2020-04-29 Thread Maxim Muzafarov
Folks, I'm going to merge this issue [1] on the 1-st day of May. If you still have any questions or PR improvement suggestions, please let me know. [1] https://issues.apache.org/jira/browse/IGNITE-11073 On Mon, 27 Apr 2020 at 18:27, Maxim Muzafarov wrote: > > Alexey, > > > From my point of

Re: [DISCUSSION] Hot cache backup

2020-04-27 Thread Alexey Goncharuk
Maxim, I saw the list of the tickets you want to work on in the PR, it looks nice. I was wondering, what part of that list are you planning to implement before the feature is released to end users? For example, I agree with Slava that we should implement a command-line utility part for snapshots

Re: [DISCUSSION] Hot cache backup

2020-04-27 Thread Maxim Muzafarov
Folks, Are there any cases left which we need to discuss? Do you have any questions? I'm ready to provide all the details you need for the review. Who else what to take a look at my changes [1] [2]? [1] https://issues.apache.org/jira/browse/IGNITE-11073 [2]

Re: [DISCUSSION] Hot cache backup

2020-04-24 Thread Maxim Muzafarov
Alexey, I've addressed all your comments, please, take a look at the PR [1]. Additional tests were added. Additional comments with further steps were added. [1] https://github.com/apache/ignite/pull/7607 [2] https://issues.apache.org/jira/browse/IGNITE-11073 On Tue, 21 Apr 2020 at 09:53,

Re: [DISCUSSION] Hot cache backup

2020-04-21 Thread Alexey Goncharuk
Maxim, I've left my comments in the PR. пн, 20 апр. 2020 г. в 12:52, Maxim Muzafarov : > Alex P, > Thank you for the great sophisticated review. > > > Alexey G, > Will you take a look at my changes[1]? > The fresh TC.Bot visa attached. > > > [1]

Re: [DISCUSSION] Hot cache backup

2020-04-20 Thread Maxim Muzafarov
Alex P, Thank you for the great sophisticated review. Alexey G, Will you take a look at my changes[1]? The fresh TC.Bot visa attached. [1] https://issues.apache.org/jira/browse/IGNITE-11073 On Mon, 20 Apr 2020 at 11:54, Alex Plehanov wrote: > > Maxim, I've reviewed your PR and it looks good

Re: [DISCUSSION] Hot cache backup

2020-04-20 Thread Alex Plehanov
Maxim, I've reviewed your PR and it looks good to me. Good job! пт, 10 апр. 2020 г. в 19:43, Alexey Goncharuk : > Maxim, > > Thanks for raising this PR. I will do a review during next week. > > --AG >

Re: [DISCUSSION] Hot cache backup

2020-04-10 Thread Alexey Goncharuk
Maxim, Thanks for raising this PR. I will do a review during next week. --AG

Re: [DISCUSSION] Hot cache backup

2020-04-09 Thread Maxim Muzafarov
Andrey, > What about primary/backup node data consistency. Primary and backup partitions must be fully consistent in a snapshot, additional recovery procedures not required. So, when we restore a snapshot on the same topology everything will work right out of the box - no WAL needed. This is

Re: [DISCUSSION] Hot cache backup

2020-04-08 Thread Andrey Dolmatov
I would like to understand your solution deeper. Hope, that my questions are interesting not only for me: - What about primary/backup node data consistency. I found, that [1] Cassandra uses eventually consistent backups, so some backup data could miss from snapshot. If I apply snapshot,

Re: [DISCUSSION] Hot cache backup

2020-04-08 Thread Maxim Muzafarov
Andrey, Thanks for your questions, I've also clarified some details on the IEP-43 [1] page according to them. > Does snapshot contain only primary data or backup partitions or both? A snapshot contains a full copy of persistence data on each local node. This means all primary, backup

Re: [DISCUSSION] Hot cache backup

2020-04-08 Thread Andrey Dolmatov
Hi, Maxim! It is very useful feature, great job! But could you explain me some aspects? - Does snapshot contain only primary data or backup partitions or both? - Could I create snapshot from m-node cluster and apply it to n-node cluster (n<>m)? - Should data node has extra space on

Re: [DISCUSSION] Hot cache backup

2020-04-08 Thread Surkov
That's cool. I'm waiting for this thing. -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: [DISCUSSION] Hot cache backup

2020-04-07 Thread Nikolay Izhikov
Hello, Maxim. Great to see such an important feature in Ignite! Please, let me know if you need any help with review. > 7 апр. 2020 г., в 22:10, Maxim Muzafarov написал(а): > > Igniters, > > > I'd like to back to the discussion of a snapshot operation for Apache > Ignite for persistence

Re: [DISCUSSION] Hot cache backup

2020-04-07 Thread Maxim Muzafarov
Igniters, I'd like to back to the discussion of a snapshot operation for Apache Ignite for persistence cache groups and I propose my changes below. I have prepared everything so that the discussion is as meaningful and specific as much as possible: - IEP-43: Cluster snapshot [1] - The Jira task

Re: [DISCUSSION] Hot cache backup

2019-02-28 Thread Dmitriy Pavlov
Hi Maxim, I agree with Denis and I have just one concern here. Apache Ignite has quite a long story (started even before Apache), and now it has a way too huge number of features. Some of these features - are developed and well known by community members, - some of them were contributed a long

Re: [DISCUSSION] Hot cache backup

2019-02-27 Thread Denis Magda
Maxim, GridGain has this exact feature available for Ignite native persistence deployments. It's not as easy as it might have been seen from the enablement perspective. Took us many years to make it production ready, involving many engineers. If the rest of the community wants to create something

[DISCUSSION] Hot cache backup

2019-02-27 Thread Maxim Muzafarov
Igniters, Some of the stores with which the Apache Ignite is often compared has a feature called Snapshots [1] [2]. This feature provides an eventually consistent view on stored data for different purposes (e.g. moving data between environments, saving a backup of data for the further restore