Re: [DISCUSSION] Unified CLI tool

2020-12-21 Thread Petr Ivanov
Nikita, let me disagree with you. Although, nested commands seem to be overcomplicated, they are widely used in industry in tools like GIT, DOCKER, K8S, etc. May be I am wrong, but it looks like that professional engineering community has already get used to them and such syntax would not be a

Re: [DISCUSSION] Unified CLI tool

2020-12-21 Thread Nikita Ivanov
When it comes to CLI commands - I would highly recommend to stick to a traditional Unix/Linux approach of command line interfaces and REPLs (i.e. command + zero or more parameters). Nested commands are not a good idea IMHO as they are very hard to document or remember. aws-cli or az have them -

Re: [DISCUSSION] Unified CLI tool

2020-12-21 Thread Kirill Gusakov
Hey. 1. Sure, will remove demo suffixes. 2. I thought about it. Not sure why “node-start” is better than “node start”. In general, we really have a subcommands hierarchy and I think it is ok not to hide it. Many tools with subcommands use the same approach: az (azure), aws, docker, kubectl,

Re: [DISCUSSION] Unified CLI tool

2020-12-20 Thread Valentin Kulichenko
Hi Kirill, It looks like the PR has been merged - thanks a lot for the effort! A couple of things: 1. Can we get rid of the word "demo" in the module name? It looks like this is an artifact from the times when it was merely a prototype. This is not the case anymore. 2. The command

Re: [DISCUSSION] Unified CLI tool

2020-12-17 Thread Valentin Kulichenko
Thanks, Kirill! Hopefully, this will be merged soon. -Val On Wed, Dec 16, 2020 at 4:54 AM Kirill Gusakov wrote: > Hi, Valentin. > > PR is ready for review, some smoke tests added. > > On Sat, Dec 12, 2020 at 2:40 AM Valentin Kulichenko < > valentin.kuliche...@gmail.com> wrote: > > > Hi Kirill,

Re: [DISCUSSION] Unified CLI tool

2020-12-16 Thread Kirill Gusakov
Hi, Valentin. PR is ready for review, some smoke tests added. On Sat, Dec 12, 2020 at 2:40 AM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Hi Kirill, > > I've played with the tool a little bit and it looks great! I definitely > like the overall approach of a single script

Re: [DISCUSSION] Unified CLI tool

2020-12-11 Thread Valentin Kulichenko
Hi Kirill, I've played with the tool a little bit and it looks great! I definitely like the overall approach of a single script responsible for all the operations. This should significantly improve the usability of the product. Looks like there is a significant amount of functionality already

[DISCUSSION] Unified CLI tool

2020-12-11 Thread Kirill Gusakov
Hi, everyone. I want to propose for discussion the PoC cli tool, which was born to check and demonstrate approaches explained in [0] and [1]. This tool will be the all-in-one cli tool for ignite cluster management and ignite installation/update. One unified tool will: - lower the entry threshold