Hi Roman,
thank you for stepping in and fixing tests.
The fix was merged into all branches.
Sincerely,
Dmitriy Pavlov
ср, 3 окт. 2018 г. в 22:30, Roman Kondakov :
> Dmitriy, Vladimir,
>
> We added an extra memory region for TxLog and this change wasn't
> reflected in .Net tests.
>
> I've made
Dmitriy, Vladimir,
We added an extra memory region for TxLog and this change wasn't
reflected in .Net tests.
I've made a trivial fix for these issues:
https://github.com/apache/ignite/pull/4910
Tests are OK:
https://ci.ignite.apache.org/viewLog.html?buildId=1999429&tab=queuedBuildOverviewT
Hi Igniters,
I see that https://issues.apache.org/jira/browse/IGNITE-9390 was resolved, but
.Net metrics tests are failing.
*New test failure in master DataRegionMetricsTest.TestMemoryMetrics
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6742613397597284603
Vladimir, I agree more with Andrey's fix in the parity test, because it
disables only specific property failure.
If we keep .NET parity test failed for a long time, some other
contributor will introduce new property- it will begin to fail always - it
is like a snowball.
I hope the metrics test wi
Hi guys!
By the way, is it practically feasible to revert a single commit without
making harm? If I am getting it right in current case reverting commit will
lead to compilation errors for commits depending on commit in question.
2018-09-28 14:22 GMT+03:00 Dmitriy Pavlov :
> Hi Dmitriy S.,
>
> I
Hi Dmitriy S.,
I really prefer avoiding reverts, which why I've started this topic. If I
were reverting-fan, I could just write: "Vetoing commit because of
test failures , commit reverted, ticket IGNITE- reopened."
But some time ago I several times asked newbie contributors to fix mi
Andrey,
This is not a fix, but a hack, which covers real state of affairs.
пт, 28 сент. 2018 г. в 13:00, Andrey Mashenkov :
> Hi,
>
> Fix is trivial and ready.
> Hope, it will be merged within IGNITE-7764 today.
>
> https://issues.apache.org/jira/browse/IGNITE-7764
>
> On Fri, Sep 28, 2018 at 12
Hi,
Fix is trivial and ready.
Hope, it will be merged within IGNITE-7764 today.
https://issues.apache.org/jira/browse/IGNITE-7764
On Fri, Sep 28, 2018 at 12:26 PM Dmitriy Setrakyan
wrote:
> Guys, let's just fix the tests without reverting commits. Reverting a
> commit may trigger a time machin
Guys, let's just fix the tests without reverting commits. Reverting a
commit may trigger a time machine, where all following commits may be
broken because of it. Fixing that scenario will be much harder.
Going forward, I would agree that we should not merge anything that breaks
tests. This is abou
Yep, we're humans and we constantly make mistakes. It is a very human thing
to do mistakes.
So I suggest we will be under the control and protection of robot to avoid
mistakes, I suggest robot will revert such commits in 72h without its own
personal attitudes, emotions, etc.
Someone who is intere
Because a lot of other activities depended on configuration in Java, and we
didn't have expertise to fix .NET immediately.
If you want to revert it - please go ahead. But I'd better suggest you to
think about the impact and project priorities first, instead of trying to
apply the some sort rules b
Hi Dmitriy,
Why not revert the change?
This test failure was appropriately reported to the dev list, and the
contributor did not fix it:
http://apache-ignite-developers.2346864.n4.nabble.com/MTCGA-new-failures-in-builds-1888723-needs-to-be-handled-td35239.html
It seems this idea of filing block
Hi Vladimir,
https://issues.apache.org/jira/browse/IGNITE-9320 is named configuration
finalization.
Why finalization was considered as done without tests passing?
Why can't ve revert finalization change, re-do finalization with passing
tests and merge changes?
Sincerely,
Dmitriy Pavlov
пт, 28
Test is going to be fixed in the scope of AI 2.7 [1]. This is not
one-minute fix as there are multiple places where configuration should be
passed, and changes should be covered with tests. I muted the test for now.
[1] https://issues.apache.org/jira/browse/IGNITE-9390
On Fri, Sep 28, 2018 at 2:4
Let's not revert any commits yet. Can we find out who did the commit and
why he/she is not fixing the test?
D.
On Thu, Sep 27, 2018 at 4:21 PM Vyacheslav Daradur
wrote:
> Hi,
>
> Are you talking about
> 'IgniteConfigurationParityTest#TestIgniteConfiguration'?
>
> Seems it's not hard to fix this
Hi,
Are you talking about 'IgniteConfigurationParityTest#TestIgniteConfiguration'?
Seems it's not hard to fix this test, it's necessary just to implement
missing members (at least as stubs) on .NET side in
IgniteConfiguration class.
Is there a Jira issue?
On Fri, Sep 28, 2018 at 2:12 AM Dmitriy
Hi,
I'm grateful for contributions made in that area, but it seems folks don't
have time to fix the test.
Tomorrow I'm going to revert commit.
It seems it is the only way we can keep master more or less green.
https://ci.ignite.apache.org/viewLog.html?buildId=1888723&tab=buildChangesDiv&buildT
17 matches
Mail list logo
