Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Alexander Polovtcev
> We can run dependency:tree command and search for guava in transitive dependencies. It is ok to have Guava as a transitive dependency (at least for now), so this step is not necessary. > Can you describe how it should be and where should this explicit dependency reside? As I see it, we will

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Petr Ivanov
We can run dependency:tree command and search for guava in transitive dependencies. Can you describe how it should be and where should this explicit dependency reside? > On 13 Sep 2021, at 17:15, Alexander Polovtcev wrote: > > Petr, > In the original thread we decided to add Guava as an

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Alexander Polovtcev
Petr, In the original thread we decided to add Guava as an explicit dependency in order to avoid dependency conflicts and to possibly shade it later. If there exists a check that will scan for Guava imports in Ignite code, that would probably be nice to have. On Mon, Sep 13, 2021 at 12:54 PM Petr

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Petr Ivanov
Should we somehow restrict using this dependency in the project with Maven (or any other tools)? > On 13 Sep 2021, at 12:47, Alexander Polovtcev wrote: > > The voting has finished and the results are the following: > > [+1 Allow]: 1 > [-1 Prohibit]: 5 > > Therefore it is decided to prohibit

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-13 Thread Alexander Polovtcev
The voting has finished and the results are the following: [+1 Allow]: 1 [-1 Prohibit]: 5 Therefore it is decided to prohibit using Guava in Ignite 3 codebase, even if it is included as a direct dependency. I will add this to the Ignite 3 code style document (or similar) as soon as it is

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-09 Thread Alexei Scherbakov
I've checked Guava's feature list and came to a conclusion it's usefulness has been diminished by switching to base java 11. -1 for general use, but we can use some code parts then needed. ср, 8 сент. 2021 г. в 14:09, Вячеслав Коптилин : > -1 > I am leaning toward -1 because of

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-08 Thread Вячеслав Коптилин
-1 I am leaning toward -1 because of vulnerability issues (that is a possible case in general). Thanks, S. ср, 8 сент. 2021 г. в 12:13, Andrey Mashenkov : > -1 > Supporting few copy-pasted methods is much easier than support dependencies > compatibility. > > On Tue, Sep 7, 2021 at 7:42 PM

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-08 Thread Andrey Mashenkov
-1 Supporting few copy-pasted methods is much easier than support dependencies compatibility. On Tue, Sep 7, 2021 at 7:42 PM Zhenya Stanilovsky wrote: > > Aleksandr, thanks for this activity. > -1 from my side, all my decisions are in linked discussion. > > >Dear Igniters, > > > >In this thread

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-07 Thread Zhenya Stanilovsky
Aleksandr, thanks for this activity. -1 from my side, all my decisions are in linked discussion.   >Dear Igniters, > >In this thread >< >https://lists.apache.org/thread.html/r4120a03a2bf32098e54e21ae02e509b0d68f413bc7cc1f8f6d85c93d%40%3Cdev.ignite.apache.org%3E > > >we've been discussing the

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-07 Thread Andrey Gura
-1 Potential compatibility issues which are related to user specific code (services, jobs). Potential vulnerabilities which are a problem because we can't manage the Guava release cycle. Arguable approach with unnecessary immutability and unmanageable GC pressure. It's too hard to manage the

Re: [VOTE] Allow or prohibit usages of the Guava library methods

2021-09-07 Thread Alexander Polovtcev
+1 We already have some utility methods that are copy-pasted from Guava, which can be removed, and I believe that *reasonable* usage of this library can benefit the code and the product quality. On Tue, Sep 7, 2021 at 6:27 PM Alexander Polovtcev wrote: > Dear Igniters, > > In this thread >

[VOTE] Allow or prohibit usages of the Guava library methods

2021-09-07 Thread Alexander Polovtcev
Dear Igniters, In this thread we've been discussing the problems and opportunities of using Guava in Ignite 3. We have agreed that it