Pavel, Dmitry G.,
Thank you for the help and review this improvement!
Igniters,
I'd like to finalize this topic with the following changes [1] `Update
Grid(Ignite)CacheDatabaseSharedManager
according to accepted coding guidelines`. I've consciously excluded them
from the original PR not to
Igniters,
I would like this issue to be part of release 2.7. There is not much time
left
considering that I will have to correct comments after the review.
Will anyone help with review?
PR: https://github.com/apache/ignite/pull/4520/files
Upsource:
Igniters,
I need your help with the review of this patch. In general, it will help to
reduce PME duration. I've moved binary
memory recovery at the moment of node startup as we've discussed it with
Pavel previously this topic.
Changes are relatively small (+299 −95) and they are ready. I've left
Hello Maxim,
I think you're going in the right direction, but why you perform binary
recovery only in the case when a node in the baseline?
I think that node can also perform binary recovery before the first
exchange is started in case of
1) First activation
2) Baseline change
In all of these
Hello Maxim,
Thank you for your work. I will review your changes within the next several
days.
2018-08-22 11:12 GMT+03:00 Maxim Muzafarov :
> Pavel,
>
> Thank you for so detailed introduction into the root of the problem of
> ticket IGNITE-7196.
> As you mentioned before, we can divide this
Pavel,
Thank you for so detailed introduction into the root of the problem of
ticket IGNITE-7196.
As you mentioned before, we can divide this ticket into two sub-tasks. So,
I will
file new issue for `Logical consistency recovery`. I think it's more
convenient way
for reviewing and merging each of
Hello Maxim,
1) Yes, Discovery Manager is starting after GridCacheProcessor, which
starts GridCacheDatabaseSharedManager which invokes readMetastorage on
start.
2) Before we complete the local join future, we create and add Exchange
future on local node join to ExchangeManager. So, when local
Hello, Maxim.
> 1) Is it correct that readMetastore() happens after node starts> but before
> including node into the ring?>
I think yes.
You can have some kind of metainformation required on node join.
> 5) Does in our final solution for new joined node readMetastore> and
> restoreMemory
Hi Igniters,
I'm working on bug [1] and have some questions about the final
implementation. Probably, I've already found answers on some of
them but I want to be sure. Please, help me to clarify details.
The key problem here is that we are reading WAL and restoring
memory state of new joined
