Re: JetBrains Annotaions usage.

2016-07-29 Thread Anton Vinogradov
Alexey, thanks for tips. Seems maven dependency's "optional" tag can handle this. See pullrequest for details. P.s. I'm not pretty sure this change will not brake something, need to recheck it twice. On Thu, Jul 28, 2016 at 5:15 PM, Alexey Goncharuk <

Re: JetBrains Annotaions usage.

2016-07-28 Thread Alexey Goncharuk
According to the JLS [1], adding or removing annotations has no effect on the correct linkage of the binary representations of programs in the Java programming language. Even if these annotations were RUNTIME, a user could successfully use Ignite unless he explicitly uses those classes in runtime.

Re: JetBrains Annotaions usage.

2016-07-28 Thread Anton Vinogradov
Dmitriy, Annotations have @Retention(RetentionPolicy.CLASS) which means * Annotations are to be recorded in the class file by the compiler * but need not be retained by the VM at run time. This is the default * behavior. So, from what I understand, everyone using ignite API with

Re: JetBrains Annotaions usage.

2016-07-28 Thread Dmitriy Setrakyan
Anton, compile-time annotations should mean that Ignite should not require these libraries at runtime. Did you try it already and run into issues? On Thu, Jul 28, 2016 at 4:34 AM, Anton Vinogradov wrote: > Possible, what's the solution in this case? > > On Thu, Jul 28,

Re: JetBrains Annotaions usage.

2016-07-28 Thread Anton Vinogradov
Possible, what's the solution in this case? On Thu, Jul 28, 2016 at 11:17 AM, Sergi Vladykin wrote: > I don't think that JB annotations is a runtime dependency, we should need > them only at compile time, no? > > Sergi > > 2016-07-28 11:09 GMT+03:00 Anton Vinogradov

Re: JetBrains Annotaions usage.

2016-07-28 Thread Sergi Vladykin
I don't think that JB annotations is a runtime dependency, we should need them only at compile time, no? Sergi 2016-07-28 11:09 GMT+03:00 Anton Vinogradov : > Igniters, > > As you may know we had only 2 dependencies at ignite-core: jcache and > ignite-shmen. > > IGNITE-3323 Get

JetBrains Annotaions usage.

2016-07-28 Thread Anton Vinogradov
Igniters, As you may know we had only 2 dependencies at ignite-core: jcache and ignite-shmen. IGNITE-3323 Get rid of copypasted JB annotations, use dependency instead. brings one more dependency to org.jetbrains.annotations. This solves