Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-07-20 Thread Andrey Gura
One more change to the original IEP. The "Dependency resolving and class loading" section [1] proposes to throw an instance of ClassNotFoundException for cases where a deployment unit is not found or can't be used. The same exception should be thrown in cases where a class loader is not able to

Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-07-10 Thread Andrey Gura
Folks, due to the impossibility of timely detection of changing of a leader in a replication group I've changed the section "Unit deployment process" [1]. Now it is enough to deploy a deployment unit to a replica group majority without mandatory inclusion of a leader. 1.

Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-05-30 Thread Vadim Pakhnushev
Let me also include the long descriptions so it should hopefully be clearer now: In REPL mode: Usage: cluster unit list [-hv] [-u=] [--status=[, ...]]... [ [--version=]] Shows a list of deployed units Deployment unit id -h, --help

Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-05-29 Thread Vadim Pakhnushev
Andrey, For reference, this is the short usage help of these commands in REPL mode: Usage: cluster unit list [-hv] [-u=] [--status=[,...]]... [ [--version=]] Usage: node unit list [-hv] [-u= | -n=] [--status=[,...]]... [ [--version=]] And in

Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-05-26 Thread Vadim Pakhnushev
Andrey, Sorry, I omitted the `--node-url` option which is common for all `node ...` commands. So in the non-REPL mode there's a `--node-url` option, and in the REPL mode there's also a `--node-name`, which takes a consistent id. On Thu, May 25, 2023 at 11:03 PM Andrey Gura wrote: > Vadim, > > >

Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-05-25 Thread Andrey Gura
Vadim, > Likewise, the `node unit list` command will list only node statuses so the `nodeId` is redundant because it will be called on the particular node endpoint. I still don't understand about the `node unit list`. The suggested syntax is: node unit list [nodeId [--version version]]

Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-05-25 Thread Vadim Pakhnushev
The `nodeId` parameter is not required for the `cluster unit list` because we will list only cluster statuses. Likewise, the `node unit list` command will list only node statuses so the `nodeId` is redundant because it will be called on the particular node endpoint. On Thu, May 25, 2023 at 6:18 

Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-05-25 Thread Andrey Gura
Hi, Vadim! Why is the `nodeId` parameter not required in the suggested syntax of `cluster unit list` and `node unit list` commands? What does the `nodeId` parameter mean in the `cluster unit list` command? On Thu, May 25, 2023 at 12:34 PM Vadim Pakhnushev wrote: > > Hi Andrey! > > I have a

Re: [DISCUSSION] IEP-103: Code Deployment in Apache Ignite 3

2023-05-25 Thread Vadim Pakhnushev
Hi Andrey! I have a small suggestion regarding the design of the CLI commands. Since we already have a cluster/node namespaces in the CLI, I'd suggest moving the deploy/undeploy/list commands to the cluster subcommand, and rather than using --node option to list the units on the particular node,