Re: Adding sqlline tool to Apache Ignite project

2017-10-20 Thread Denis Magda
Has the tool been renamed? Give us an intermediate build. We need to finalize the doc and screencast. — Denis > On Oct 19, 2017, at 10:26 AM, Denis Magda wrote: > >>> How about renaming it to "sqlline”? > > No objections from my side. Who will do the renaming? Please send

Re: Adding sqlline tool to Apache Ignite project

2017-10-19 Thread Denis Magda
>> How about renaming it to "sqlline”? No objections from my side. Who will do the renaming? Please send a note once it happens so that Prachi can update the doc and screencast. Prachi, The doc looks good, thanks! Please keep an eye on the discussion and rename the script both in the docs

Re: Adding sqlline tool to Apache Ignite project

2017-10-19 Thread Dmitriy Setrakyan
On Wed, Oct 18, 2017 at 11:30 PM, Vladimir Ozerov wrote: > Igniters, > > We named the script "Ignitesql.sh" because initially we thought that it > would have additional logic. But now it is merely a thin wrapper around > sqlline which only contains classpath creation logic

Re: Adding sqlline tool to Apache Ignite project

2017-10-19 Thread Anton Vinogradov
Prachi, Seems, documentation should point to 2.3 instead of 2.1? On Thu, Oct 19, 2017 at 9:30 AM, Vladimir Ozerov wrote: > Igniters, > > We named the script "Ignitesql.sh" because initially we thought that it > would have additional logic. But now it is merely a thin

Re: Adding sqlline tool to Apache Ignite project

2017-10-19 Thread Vladimir Ozerov
Igniters, We named the script "Ignitesql.sh" because initially we thought that it would have additional logic. But now it is merely a thin wrapper around sqlline which only contains classpath creation logic and some convenient defaults. How about renaming it to "sqlline"? чт, 19 окт. 2017 г. в

Re: Adding sqlline tool to Apache Ignite project

2017-10-18 Thread Prachi Garg
Here is the link for SQLLine documentation - https://apacheignite-sql.readme.io/v2.1/docs/sqlline -P On Tue, Oct 17, 2017 at 11:54 AM, Denis Magda wrote: > Looks good to me. Prachi will help us documenting the tool usage: > https://issues.apache.org/jira/browse/IGNITE-6656 <

Re: Adding sqlline tool to Apache Ignite project

2017-10-17 Thread Denis Magda
Looks good to me. Prachi will help us documenting the tool usage: https://issues.apache.org/jira/browse/IGNITE-6656 However, I can’t conceive how to see a table structure (columns and their types, indexes with names and types) using SQLLine.

Re: Adding sqlline tool to Apache Ignite project

2017-10-17 Thread Oleg Ostanin
New example build with sqlline: https://ci.ignite.apache.org/viewLog.html?buildId=894407=artifacts=IgniteRelease_XxxFromMirrorIgniteRelease3PrepareVote#!1rrb2,1esn4zrslm4po,-h8h0hn9vvvxp On Wed, Oct 11, 2017 at 1:00 AM, Denis Magda wrote: > Oleg, > > Looks good to me.

Re: Adding sqlline tool to Apache Ignite project

2017-10-10 Thread Denis Magda
Oleg, Looks good to me. Please consider the notes left in the ticket. I want us to prepare a script for Windows, review the language for help notice and errors, put together documentation. Prachi will be able to help with the editing and documentation. — Denis > On Oct 9, 2017, at 10:13 AM,

Re: Adding sqlline tool to Apache Ignite project

2017-10-09 Thread Oleg Ostanin
New build with fixed argument parsing: https://ci.ignite.apache.org/viewLog.html?buildId=882282=artifacts=IgniteRelease_XxxFromMirrorIgniteRelease3PrepareVote#!1rrb2,1esn4zrslm4po,-h8h0hn9vvvxp On Mon, Oct 9, 2017 at 5:38 PM, Denis Magda wrote: > I think it’s a must have

Re: Adding sqlline tool to Apache Ignite project

2017-10-09 Thread Denis Magda
I think it’s a must have for the ticket resolution. Denis On Monday, October 9, 2017, Anton Vinogradov wrote: > Any plans to have ignitesql.bat? > > On Mon, Oct 9, 2017 at 5:29 PM, Oleg Ostanin > wrote: > > > Another build with

Re: Adding sqlline tool to Apache Ignite project

2017-10-09 Thread Anton Vinogradov
Any plans to have ignitesql.bat? On Mon, Oct 9, 2017 at 5:29 PM, Oleg Ostanin wrote: > Another build with sqlline included: > https://ci.ignite.apache.org/viewLog.html?buildId=881120; > tab=artifacts=IgniteRelease_XxxFromMirrorIgniteRelease3Pre >

Re: Adding sqlline tool to Apache Ignite project

2017-10-09 Thread Oleg Ostanin
Another build with sqlline included: https://ci.ignite.apache.org/viewLog.html?buildId=881120=artifacts=IgniteRelease_XxxFromMirrorIgniteRelease3PrepareVote#!1rrb2,-wpvx2aopzexz,1esn4zrslm4po,-h8h0hn9vvvxp On Sun, Oct 8, 2017 at 5:11 PM, Denis Magda wrote: > No more doubts

Re: Adding sqlline tool to Apache Ignite project

2017-10-08 Thread Denis Magda
No more doubts on my side. +1 for Vladimir’s suggestion. Denis On Saturday, October 7, 2017, Dmitriy Setrakyan wrote: > I now tend to agree with Vladimir. We should always require that some > address is specified. The help menu should clearly state how to connect to > a

Re: Adding sqlline tool to Apache Ignite project

2017-10-07 Thread Dmitriy Setrakyan
I now tend to agree with Vladimir. We should always require that some address is specified. The help menu should clearly state how to connect to a localhost. D. On Sat, Oct 7, 2017 at 12:44 AM, Vladimir Ozerov wrote: > Denis, > > Default Ignite configuration uses

Re: Adding sqlline tool to Apache Ignite project

2017-10-07 Thread Vladimir Ozerov
Denis, Default Ignite configuration uses multicast, this is why you do not need to change anything. Ignite node is always both a server (listens) and a client (connects). This will not work for ignitesql, as this is a client. And in real deployments it will connect to remote nodes, not local. So

Re: Adding sqlline tool to Apache Ignite project

2017-10-06 Thread Dmitriy Setrakyan
How does the binding happen? Can we bind to everything, like we do in Ignite? On Fri, Oct 6, 2017 at 2:51 PM, Denis Magda wrote: > Thought over 127.0.0.1 as a default host once again. The bad thing about > it is that the user gets a lengthy exception stack trace if Ignite is

Re: Adding sqlline tool to Apache Ignite project

2017-10-06 Thread Dmitriy Setrakyan
On Fri, Oct 6, 2017 at 9:04 AM, Anton Vinogradov wrote: > How about sqlconsole.sh or sqlcmd.sh ? > Shouldn't we have "ignite" in the name?

Re: Adding sqlline tool to Apache Ignite project

2017-10-06 Thread Denis Magda
> But, we need to support “help” (-h, -help) argument listing all the > parameters accepted by the tools. Meant accepted by the ignitesql script only such as host name. — Denis > On Oct 6, 2017, at 12:20 PM, Denis Magda wrote: > > Really nice, could click through the

Re: Adding sqlline tool to Apache Ignite project

2017-10-06 Thread Denis Magda
Really nice, could click through the getting started [1] in a minute! +1 to rename the script to “ignitesql”. Vladimir’s point makes total sense. However, tend to disagree that the host has to be requested all the times. We never request a configuration or host name for ignite.sh, visor or web

Re: Adding sqlline tool to Apache Ignite project

2017-10-06 Thread Anton Vinogradov
How about sqlconsole.sh or sqlcmd.sh ? On Fri, Oct 6, 2017 at 6:04 PM, wrote: > I like ignitesql. > > ⁣D.​ > > On Oct 6, 2017, 4:49 PM, at 4:49 PM, Vladimir Ozerov > wrote: > >Denis, > > > >Setting default host to 127.0.0.1 is bad idea, because it

Re: Adding sqlline tool to Apache Ignite project

2017-10-06 Thread dsetrakyan
I like ignitesql. ⁣D.​ On Oct 6, 2017, 4:49 PM, at 4:49 PM, Vladimir Ozerov wrote: >Denis, > >Setting default host to 127.0.0.1 is bad idea, because it mean that in >practice users would have to change the script always. Instead, we >should >accept host name as argument.

Re: Adding sqlline tool to Apache Ignite project

2017-10-06 Thread Vladimir Ozerov
Denis, Setting default host to 127.0.0.1 is bad idea, because it mean that in practice users would have to change the script always. Instead, we should accept host name as argument. This is perfectly fine from usability perspective, most tools work this way (i.e. throw error when started without

Re: Adding sqlline tool to Apache Ignite project

2017-10-06 Thread Sergey Kozlov
Denis The link below has included sqlline. Please take a look: https://ci.ignite.apache.org/viewLog.html?buildId=875441=IgniteRelease_XxxFromMirrorIgniteRelease3PrepareVote=artifacts#!1rrb2,-wpvx2aopzexz On Thu, Oct 5, 2017 at 7:48 PM, Denis Magda wrote: > Here is the

Re: Adding sqlline tool to Apache Ignite project

2017-10-05 Thread Denis Magda
Here is the original ticket [1]. Ilya, closed the one created by you as a duplicate. In addition to the tool’s jar inclusion in Ignite’s binary releases let’s create a shell script to simplify the connectivity phase: name the script as ignitedb.sh for Unix and ignitedb.bat for Windows. the

Re: Adding sqlline tool to Apache Ignite project

2017-10-05 Thread Sergey Kozlov
Dmitriy, Denis We're in progress to add sqlline in upcoming 2.3 On Thu, Oct 5, 2017 at 5:30 PM, Dmitriy Setrakyan wrote: > Would be nice to get it in 2.3. This is critical functionality for our > users and 2.4 seems too far to give anyone comfort. > > On Thu, Oct 5, 2017

Re: Adding sqlline tool to Apache Ignite project

2017-10-05 Thread Dmitriy Setrakyan
Would be nice to get it in 2.3. This is critical functionality for our users and 2.4 seems too far to give anyone comfort. On Thu, Oct 5, 2017 at 11:33 AM, Ilya Suntsov wrote: > Guys, > > I've created the ticket for 2.4 release: >

Re: Adding sqlline tool to Apache Ignite project

2017-10-05 Thread Ilya Suntsov
Guys, I've created the ticket for 2.4 release: https://issues.apache.org/jira/browse/IGNITE-6561 2017-08-30 22:21 GMT+03:00 Julian Hyde : > Denis, > > I’m glad you’re thinking of using SQLLine. Under the BSD license, you > don’t need my permission to distribute, but I grant

Re: Adding sqlline tool to Apache Ignite project

2017-10-05 Thread Ilya Suntsov
Guys, I've created ticket [1] for version 2.4. https://issues.apache.org/jira/browse/IGNITE-6561 2017-08-30 22:21 GMT+03:00 Julian Hyde : > Denis, > > I’m glad you’re thinking of using SQLLine. Under the BSD license, you > don’t need my permission to distribute, but I grant

Re: Adding sqlline tool to Apache Ignite project

2017-08-30 Thread Julian Hyde
Denis, I’m glad you’re thinking of using SQLLine. Under the BSD license, you don’t need my permission to distribute, but I grant that permission. Drill, Phoenix and Calcite already distribute SQLLine, so Ignite is in good company. If you need extensions, please discuss on the dev list, or

Re: Adding sqlline tool to Apache Ignite project

2017-08-29 Thread Denis Magda
Igniters, Let me introduce Julian Hyde [1], creator of SQLLine tool and our Apache mate, Julian, Please grant that Apache Ignite community a permission to include SQLLine [2] it in every Ignite deliverable (source, binary). It’s planned to suggest the tool as a default command line SQL

Re: Adding sqlline tool to Apache Ignite project

2017-08-25 Thread Denis Magda
Hi Ilya, Thanks for the clarification! Referring to the page shared by you [1] if we need to get author’s consent in a written form: A permissive license similar to the BSD 2-Clause License, but with a 3rd clause that prohibits others from using the name of the project or its contributors to

Re: Adding sqlline tool to Apache Ignite project

2017-08-25 Thread Ilya Kasnacheev
Hi Denis, There are two kinds of BSD license, 3-clause and 4-clause. The difference between them is advertising clause: "3. All advertising materials mentioning features or use of this software must display the following acknowledgement: This product includes software developed by the University

Re: Adding sqlline tool to Apache Ignite project

2017-08-25 Thread Denis Magda
Hi Ilya, It will be a useful addition to Ignite. I would include the tool in one of the nearest releases. It’s license is BSD-3 which is compatible with ours. However, there is a note on ASF side saying that BSD licenses can be included without advertising clause [1]. What does it mean for us?